Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop - Blank screen appears when exiting the onfido page in IOU flow #6082

Closed
kavimuru opened this issue Oct 27, 2021 · 9 comments
Closed
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch Desktop app and login
  2. Tap on [+] and select 'Send money" > enter amount > next
  3. Enter email in the field 'Name, email or phone"
  4. Tap on Continue for "Verify identity" page
  5. Close 'Verify identity" modal

Expected Result:

"Send to" modal page should be open.

Actual Result:

App is shown blank screen after closing "Verify identity" page

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Desktop App

Version Number: v1.1.10-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5300013_Blank_page_Desktop_App.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Oct 27, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@nickmurray47
Copy link
Contributor

nickmurray47 commented Oct 27, 2021

@madmax330 the SendMoney flow is behind a beta, by the way, so think we can reasonably remove the deploy blocker label, put Daily and I can assign myself or the original PR author.

@madmax330 madmax330 added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment labels Oct 27, 2021
@madmax330 madmax330 added Improvement Item broken or needs improvement. and removed Hourly KSv2 labels Oct 27, 2021
@madmax330
Copy link
Contributor

Thanks man.

CC @jasperhuangg

@nickmurray47
Copy link
Contributor

Tested on reguler web and the blank screen doesn't occur there in this flow, which makes me think we need to add index.desktop.js logic to the existing Onfido flow.

@MelvinBot MelvinBot removed the Overdue label Nov 1, 2021
@mvtglobally
Copy link

Issue reproducible during KI retests.

@nickmurray47
Copy link
Contributor

also going to demote for weekly for the time being considering this is behind a beta rn

@MelvinBot MelvinBot removed the Overdue label Nov 4, 2021
@nickmurray47 nickmurray47 added Weekly KSv2 and removed Daily KSv2 labels Nov 4, 2021
@nickmurray47
Copy link
Contributor

Going to put this back in the pool for now and can pick back up later

@nickmurray47 nickmurray47 removed their assignment Nov 15, 2021
@luacmartins luacmartins self-assigned this Nov 23, 2021
@luacmartins
Copy link
Contributor

Issue is also present in the VBA flow. It doesn't seem to be a navigation issue, since it goes away when replacing the Onfido component. Looking for more help https://expensify.slack.com/archives/C03TQ48KC/p1637718164105600?thread_ts=1635347185.233000&cid=C03TQ48KC

@luacmartins luacmartins added the Reviewing Has a PR in review label Nov 24, 2021
@botify botify closed this as completed Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants