[$250] Tags - Background report changes to Tags page after clicking Custom tag name in RHP #49883

lanitochka17 · 2024-09-28T14:38:16Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: N/A Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

User is logged in to two devices
Workspace has tags

Go to staging.new.expensify.com
[Device A] Go to workspace chat
[Device A] Click + > Submit expense > Manual
[Device A] Proceed to confirmation page and click Tag
[Device B] Go to workspace settings > Tags
[Device B] Disable all tags
[Device A] Click Edit tags
[Device A] Click Settings > Custom tag name

Expected Result:

The report in the background will remain after clicking Custom tag name

Actual Result:

The report in the background changes to Tags page after clicking Custom tag name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6617841_1727469118066.20240928_042600.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021840631550279932147
Upwork Job ID: 1840631550279932147
Last Price Increase: 2024-09-30
Automatic offers:

paultsimura | Reviewer | 104272735

Issue Owner

Current Issue Owner: @paultsimura

melvin-bot · 2024-09-28T14:38:29Z

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions · 2024-09-28T14:38:31Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2024-09-28T14:38:31Z

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

roryabraham · 2024-09-29T00:52:54Z

Looks pretty NAB to me

NJ-2020 · 2024-09-29T05:59:36Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tags - Background report changes to Tags page after clicking Custom tag name in RHP

What is the root cause of that problem?

We're not passing the backTo param when navigating to the Custom tag name page

App/src/pages/workspace/tags/WorkspaceTagsSettingsPage.tsx

Line 85 in 3047c1b

    
           onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EDIT_TAGS.getRoute(policyID, policyTagLists[0].orderWeight))}

App/src/ROUTES.ts

Lines 847 to 850 in 3047c1b

    
           WORKSPACE_EDIT_TAGS: { 
        
               route: 'settings/workspaces/:policyID/tags/:orderWeight/edit', 
        
               getRoute: (policyID: string, orderWeight: number) => `settings/workspaces/${policyID}/tags/${orderWeight}/edit` as const, 
        
           },

And same when navigating to the Settings page

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Lines 174 to 176 in 3047c1b

    
           const navigateToTagsSettings = () => { 
        
               Navigation.navigate(ROUTES.WORKSPACE_TAGS_SETTINGS.getRoute(policyID)); 
        
           };

App/src/ROUTES.ts

Lines 843 to 846 in 3047c1b

    
           WORKSPACE_TAGS_SETTINGS: { 
        
               route: 'settings/workspaces/:policyID/tags/settings', 
        
               getRoute: (policyID: string) => `settings/workspaces/${policyID}/tags/settings` as const, 
        
           },

What changes do you think we should make in order to solve the problem?

We can add the backTo param inside the getRoute function and pass the backTo param by using route.params.backTo

WORKSPACE_TAGS_SETTINGS: {
    route: 'settings/workspaces/:policyID/tags/settings',
    getRoute: (policyID: string, backTo?: string) => getUrlWithBackToParam(`settings/workspaces/${policyID}/tags/settings` as const, backTo),
},
WORKSPACE_EDIT_TAGS: {
    route: 'settings/workspaces/:policyID/tags/:orderWeight/edit',
    getRoute: (policyID: string, orderWeight: number, backTo?: string) => getUrlWithBackToParam(`settings/workspaces/${policyID}/tags/${orderWeight}/edit` as const, backTo),
},

WorkspaceTagsPage.tsx when navigating to Settings page

const backTo = route.params.backTo;
const navigateToTagsSettings = () => {
    Navigation.navigate(ROUTES.WORKSPACE_TAGS_SETTINGS.getRoute(policyID, backTo));
};

// ...types for route.params
[SCREENS.WORKSPACE.TAGS]: {
    policyID: string;
    backTo?: Routes;
};

And same for WorkspaceTagsSettingsPage when navigating to Custom tag name page

<MenuItemWithTopDescription
    title={policyTagLists[0]?.name}
    description={translate(`workspace.tags.customTagName`)}
    onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EDIT_TAGS.getRoute(policyID, policyTagLists[0].orderWeight, backTo))}
    shouldShowRightIcon
/>

Result

Screen.Recording.2024-09-28.at.22.57.04.mov

What alternative solutions did you explore? (Optional)

Christinadobrzyn · 2024-09-30T02:57:12Z

What does NAB mean?

NJ-2020 · 2024-09-30T03:06:52Z

@Christinadobrzyn NAB stands for Not a blocker

truph01 · 2024-09-30T05:26:09Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The report in the background changes to Tags page after clicking Custom tag name

What is the root cause of that problem?

We have logic to push a new full screen navigator to the stacks if the RHN is in FULL_SCREEN_TO_RHP_MAPPING list:

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 146 to 153 in d187665

    
           // Check for FullScreenNavigator 
        
           for (const [fullScreenName, RHPNames] of Object.entries(FULL_SCREEN_TO_RHP_MAPPING)) { 
        
               if (RHPNames.includes(route.name)) { 
        
                   const paramsFromRoute = getParamsFromRoute(fullScreenName); 
        
                   return createFullScreenNavigator({name: fullScreenName as FullScreenName, params: pick(route.params, paramsFromRoute)}); 
        
               } 
        
           }

When we click on "Custom tag name", the custom tag name screen is in FULL_SCREEN_TO_RHP_MAPPING:

App/src/libs/Navigation/linkingConfig/FULL_SCREEN_TO_RHP_MAPPING.ts

Line 134 in d187665

SCREENS.WORKSPACE.TAGS_EDIT,

hence we push a new full screen navigator to stacks.

What changes do you think we should make in order to solve the problem?

In general, we should add a backTo param to the route when we click "Custom tag name". With this, in:

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Line 112 in d187665

    
           function getMatchingRootRouteForRHPRoute(route: NavigationPartialRoute): NavigationPartialRoute<CentralPaneName | typeof NAVIGATORS.FULL_SCREEN_NAVIGATOR> | undefined {

logic:

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 113 to 114 in d187665

    
           // Check for backTo param. One screen with different backTo value may need diferent screens visible under the overlay. 
        
           if (route.params && 'backTo' in route.params && typeof route.params.backTo === 'string') {

is called instead of pushing a new full screen navigator to stacks:

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 146 to 147 in d187665

    
           // Check for FullScreenNavigator 
        
           for (const [fullScreenName, RHPNames] of Object.entries(FULL_SCREEN_TO_RHP_MAPPING)) {

In detail:
First, update the getRoute function so that it can receive the additional backTo param:

App/src/ROUTES.ts

Lines 843 to 850 in d187665

    
           WORKSPACE_TAGS_SETTINGS: { 
        
               route: 'settings/workspaces/:policyID/tags/settings', 
        
               getRoute: (policyID: string) => `settings/workspaces/${policyID}/tags/settings` as const, 
        
           }, 
        
           WORKSPACE_EDIT_TAGS: { 
        
               route: 'settings/workspaces/:policyID/tags/:orderWeight/edit', 
        
               getRoute: (policyID: string, orderWeight: number) => `settings/workspaces/${policyID}/tags/${orderWeight}/edit` as const, 
        
           },

Then, update:

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Line 175 in d187665

Navigation.navigate(ROUTES.WORKSPACE_TAGS_SETTINGS.getRoute(policyID));

    const navigateToTagsSettings = () => {
        Navigation.navigate(ROUTES.WORKSPACE_TAGS_SETTINGS.getRoute(policyID, Navigation.getActiveRoute()));
    };

and:

App/src/pages/workspace/tags/WorkspaceTagsSettingsPage.tsx

Line 85 in d187665

    
           onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EDIT_TAGS.getRoute(policyID, policyTagLists[0].orderWeight))}

                        onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EDIT_TAGS.getRoute(policyID, policyTagLists[0].orderWeight, Navigation.getActiveRoute()))}

It will add new backTo param to the route when we click "Custom tag name"

What alternative solutions did you explore? (Optional)

Christinadobrzyn · 2024-09-30T05:55:18Z

Ah thanks @NJ-2020! That makes sense. Given that, I think this can be external so adding the label.

melvin-bot · 2024-09-30T05:55:35Z

Job added to Upwork: https://www.upwork.com/jobs/~021840631550279932147

melvin-bot · 2024-09-30T05:55:39Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

Christinadobrzyn · 2024-10-01T01:16:21Z

@paultsimura can you check out the proposals when you have a moment? TY!

paultsimura · 2024-10-01T06:05:44Z

Sure, I will check later today or early tomorrow 👍

Christinadobrzyn · 2024-10-02T03:12:20Z

Thanks @paultsimura! Note for Melvin - we're reviewing proposals.

paultsimura · 2024-10-02T15:52:48Z

Reviewing now 👀

paultsimura · 2024-10-02T18:18:49Z

Thanks for the proposals.
@NJ-2020 could you please provide a test branch with your solution?

twilight294 · 2024-10-03T12:17:39Z

Edited by proposal-police: This proposal was edited at 2024-10-03 12:44:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Background report changes to Tags page after clicking Custom tag name in RHP

What is the root cause of that problem?

The bug occurs because we do not have a ModalStackNavigator for tags, here we have not defined the behaviour how the RHP should act if it is coming from another RHP.

What changes do you think we should make in order to solve the problem?

We created a ModalStackNavigator for categories in this PR #41344. Following similar approach, we can make one for tags as well

Skeleton implementation would be:

Like we did for categories, create new screens for tags as well:

    SETTINGS_TAGS: {
        SETTINGS_TAGS_SETTINGS: 'Settings_Tags_Settings',
        SETTINGS_TAG_SETTINGS: 'Settings_Tag_Settings',
        SETTINGS_TAG_Create: 'Settings_Tag_Create',
        SETTINGS_TAG_EDIT: 'Settings_Tag_Edit',
        SETTINGS_TAGS_ROOT: 'Settings_Tags',
    },

Then we will create routes for the above screens:

    SETTINGS_TAG_EDIT: {
        route: 'settings/workspaces/:policyID/tag/:orderWeight/:tagName/edit',
        getRoute: (policyID: string, orderWeight: number, tagName: string) => `settings/workspaces/${policyID}/tag/${orderWeight}/${encodeURIComponent(tagName)}/edit` as const,
    },
    .....
    })

We also have to update RIGHT_MODAL to add SETTINGS_TAGS, Then in linkingConfig/config.ts, we will update similar to:

[SCREENS.RIGHT_MODAL.SETTINGS_TAGS]: {
                    screens: {
                        [SCREENS.SETTINGS_TAGS.SETTINGS_TAG_EDIT]: {
                            path: ROUTES.SETTINGS_TAG_EDIT.route,
                            parse: {
                                TagName: (tagName: string) => decodeURIComponent(categoryName),
                            },
                        },
                    },
                },
                ...

In RightModalNavigator we also need to map the modal for tags , we would then need to check whether back to is passed if so then use SETTINGS_TAG_SETTINGS else use the original navigation
The above is just rough idea, details will be provided during PR.

What alternative solutions did you explore? (Optional)

.

ZhenjaHorbach · 2024-10-03T12:19:49Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tags - Background report changes to Tags page after clicking Custom tag name in RHP

What is the root cause of that problem?

When we try to open a RHN screen from FULL_SCREEN_TO_RHP_MAPPING
Workspace screen is used as a fullscreen

App/src/libs/Navigation/linkingConfig/FULL_SCREEN_TO_RHP_MAPPING.ts

Line 60 in a991b39

    
           [SCREENS.WORKSPACE.TAGS]: [SCREENS.WORKSPACE.TAGS_SETTINGS, SCREENS.WORKSPACE.TAGS_EDIT, SCREENS.WORKSPACE.TAG_CREATE, SCREENS.WORKSPACE.TAG_SETTINGS, SCREENS.WORKSPACE.TAG_EDIT],

What changes do you think we should make in order to solve the problem?

To fix this issue we can create new routes for tags which we will use in case if we use these screens not from workspace

We did the same for categories

What alternative solutions did you explore? (Optional)

NA

paultsimura · 2024-10-03T12:32:28Z

@twilight294 thanks for your proposal. It looks very generic, could you please add some clarifications, e.g., which specific changes you would copy from #41344?

twilight294 · 2024-10-03T12:44:26Z

@paultsimura I updated proposal, do you need more details ?

paultsimura · 2024-10-03T12:56:23Z

Thanks for the update.
The proposal by @twilight294 looks good to me.

🎀👀🎀 C+ reviewed

melvin-bot · 2024-10-03T12:56:34Z

Current assignee @stitesExpensify is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

melvin-bot · 2024-10-04T22:02:27Z

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-10-04T22:02:29Z

📣 @twilight294 You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

twilight294 · 2024-10-07T15:20:48Z

PR ready for review @paultsimura

lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Sep 28, 2024

melvin-bot bot assigned Christinadobrzyn Sep 28, 2024

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 28, 2024

melvin-bot bot assigned stitesExpensify Sep 28, 2024

github-actions bot mentioned this issue Sep 28, 2024

Deploy Checklist: New Expensify 2024-09-27 #49855

Closed

roryabraham added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Sep 29, 2024

Christinadobrzyn added the External Added to denote the issue can be worked on by a contributor label Sep 30, 2024

melvin-bot bot changed the title ~~Tags - Background report changes to Tags page after clicking Custom tag name in RHP~~ [$250] Tags - Background report changes to Tags page after clicking Custom tag name in RHP Sep 30, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 30, 2024

melvin-bot bot assigned paultsimura Sep 30, 2024

stitesExpensify assigned twilight294 Oct 4, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 4, 2024

truph01 mentioned this issue Oct 6, 2024

Pay Someone - Wallet page opens when refreshing in "Validate your account" page #50285

Open

6 tasks

twilight294 mentioned this issue Oct 7, 2024

Fix: Background report changes to Tags page after clicking Custom tag name in RHP #50332

Open

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$250] Tags - Background report changes to Tags page after clicking Custom tag name in RHP #49883

[$250] Tags - Background report changes to Tags page after clicking Custom tag name in RHP #49883

lanitochka17 commented Sep 28, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 28, 2024

github-actions bot commented Sep 28, 2024

melvin-bot bot commented Sep 28, 2024

roryabraham commented Sep 29, 2024

NJ-2020 commented Sep 29, 2024

Christinadobrzyn commented Sep 30, 2024 •

edited

Loading

NJ-2020 commented Sep 30, 2024

truph01 commented Sep 30, 2024

Christinadobrzyn commented Sep 30, 2024

melvin-bot bot commented Sep 30, 2024

melvin-bot bot commented Sep 30, 2024

Christinadobrzyn commented Oct 1, 2024

paultsimura commented Oct 1, 2024

Christinadobrzyn commented Oct 2, 2024

paultsimura commented Oct 2, 2024

paultsimura commented Oct 2, 2024

twilight294 commented Oct 3, 2024 •

edited

Loading

ZhenjaHorbach commented Oct 3, 2024

paultsimura commented Oct 3, 2024

twilight294 commented Oct 3, 2024

paultsimura commented Oct 3, 2024

melvin-bot bot commented Oct 3, 2024

melvin-bot bot commented Oct 4, 2024

melvin-bot bot commented Oct 4, 2024

twilight294 commented Oct 7, 2024

[$250] Tags - Background report changes to Tags page after clicking Custom tag name in RHP #49883

[$250] Tags - Background report changes to Tags page after clicking Custom tag name in RHP #49883

Comments

lanitochka17 commented Sep 28, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Sep 28, 2024

github-actions bot commented Sep 28, 2024

melvin-bot bot commented Sep 28, 2024

roryabraham commented Sep 29, 2024

NJ-2020 commented Sep 29, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

Christinadobrzyn commented Sep 30, 2024 • edited Loading

NJ-2020 commented Sep 30, 2024

truph01 commented Sep 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Christinadobrzyn commented Sep 30, 2024

melvin-bot bot commented Sep 30, 2024

melvin-bot bot commented Sep 30, 2024

Christinadobrzyn commented Oct 1, 2024

paultsimura commented Oct 1, 2024

Christinadobrzyn commented Oct 2, 2024

paultsimura commented Oct 2, 2024

paultsimura commented Oct 2, 2024

twilight294 commented Oct 3, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ZhenjaHorbach commented Oct 3, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

paultsimura commented Oct 3, 2024

twilight294 commented Oct 3, 2024

paultsimura commented Oct 3, 2024

melvin-bot bot commented Oct 3, 2024

melvin-bot bot commented Oct 4, 2024

melvin-bot bot commented Oct 4, 2024

twilight294 commented Oct 7, 2024

lanitochka17 commented Sep 28, 2024 •

edited by melvin-bot bot

Loading

Christinadobrzyn commented Sep 30, 2024 •

edited

Loading

twilight294 commented Oct 3, 2024 •

edited

Loading