-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Invoices - Workspace settings can be opened from "workspace" link when workspace is deleted #49093
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
We think that this bug might be related to #vip-bills |
Removed blocker, see https://expensify.slack.com/archives/C9YU7BX5M/p1726158576447559 |
Triggered auto assignment to @srikarparsi ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@IuliiaHerets I think the uploaded video is incorrect. Can you please check? |
@luacmartins fixed, sorry for this |
No problem. Thank you! |
This is also reproducible in prod if we just copy/paste the workspace link |
Just by having the workspace link in any chat the problem also happens in prod: Screen.Recording.2024-09-12.at.14.46.18.mov |
We can't pay the invoice using Pay as a business in prod, so I marked it as N/A - can't check on prod |
Edited by proposal-police: This proposal was edited at 2023-10-06T15:00:00Z. ProposalPlease re-state the problem that we are trying to solve in this issue.The link can open workspace settings page and Members tab leads to not here page. What is the root cause of that problem?After deleting the workspace, we still retain some workspace information to show the invoice report's avatars and name: These information is returned by The not found page condition here simply checks for empty/delete-pending App/src/pages/workspace/WorkspacePageWithSections.tsx Lines 171 to 174 in c6ce0f8
What changes do you think we should make in order to solve the problem?
Lines 180 to 187 in 7748eff
This condition is also used in
|
Job added to Upwork: https://www.upwork.com/jobs/~021834598579747458653 |
@ntdiary, @srikarparsi, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@ntdiary can you review proposals here? |
Ah, @joekaufmanexpensify, sorry, under review. I missed this issue. 😅 |
Taking over this issue (slack), can you please assign me here @joekaufmanexpensify @srikarparsi |
We ended up rolling the dice for this one since there was a lot of interest, and @ishpaul777 was selected, so going with them! |
📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Pending @ishpaul777 review of proposals |
Looking 👀 |
@nkdengineer I dont understand the usage for prevShouldShowPolicy in your proposal could you clarify the usage please ? |
@ishpaul777 Here is the old condition and we should replace it with
|
Thanks for clarifying @nkdengineer. 👍 I dont think there are any major difference between @nkdengineer solution and @gijoe0295's solution, since @gijoe0295 Proposed this first lets assign them 🎀 👀 🎀 C+ reviewed |
Current assignee @srikarparsi is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@gijoe0295 is there an ETA for PR here? |
Will complete in 5 hours. |
PR in review |
PR still in review |
Still in review, found a bug that is taking sometime to fix, @gijoe0295 is still looking into it |
Sounds good! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #48275
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
The link should lead to not here page because workspace is deleted.
Actual Result:
The link can open workspace settings page and Members tab leads to not here page.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6601039_1726148441534.20240912_213050.1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ntdiaryThe text was updated successfully, but these errors were encountered: