[Hold for Payment 2024-09-19][$250][Search v2.1] Filters button should not be shown on Search page during "select mode".

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.28-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dannymcclain
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1725380044951249

Action Performed:

1. Go to staging.new.expensify.com
2. Click Search and select few expenses

Expected Result:

Filters button should not be shown on search during select mode

Actual Result:

Filters button are shown on search during select mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021832173197655902215
• Upwork Job ID: 1832173197655902215
• Last Price Increase: 2024-09-06
• Automatic offers:
• jjcoffee | Reviewer | 103886050

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

Edited by proposal-police: This proposal was edited at 2024-09-07 20:52:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

Filters button should not be shown on Search page during "select mode".

What changes do you think we should make in order to solve the problem?

currently the filter button is always shown

App/src/components/Search/SearchPageHeader.tsx

Lines 314 to 319 in adc29ab

	<Button
	text={translate('search.filtersHeader')}
	icon={Expensicons.Filters}
	onPress={() => Navigation.navigate(ROUTES.SEARCH_ADVANCED_FILTERS)}
	medium
	/>

What alternative solutions did you explore? (Optional)

We should modify this to ensure the button is only shown if selectedTransactionsKeys.length==0

or Alternatively, we can use headerButtonsOptions.length == 0 unlike the condition of the selected button :

        {selectedTransactionsKeys.length === 0 && (
            <Button
                text={translate('search.filtersHeader')} 
                icon={Expensicons.Filters}
                onPress={() => Navigation.navigate(ROUTES.SEARCH_ADVANCED_FILTERS)}
                medium
            />
        )}

POC

Screen.Recording.2024-09-03.at.23.22.35.mov

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Filters button should not be shown on Search page during "select mode".

What is the root cause of that problem?

We show the selected button if headerButtonsOptions.length > 0 and always showing the filters button without any conditioning

App/src/components/Search/SearchPageHeader.tsx

Lines 303 to 319 in 6e500c2

	{headerButtonsOptions.length > 0 && (
	<ButtonWithDropdownMenu
	onPress={() => null}
	shouldAlwaysShowDropdownMenu
	pressOnEnter
	buttonSize={CONST.DROPDOWN_BUTTON_SIZE.MEDIUM}
	customText={translate('workspace.common.selected', {selectedNumber: selectedTransactionsKeys.length})}
	options={headerButtonsOptions}
	isSplitButton={false}
	/>
	)}
	<Button
	text={translate('search.filtersHeader')}
	icon={Expensicons.Filters}
	onPress={() => Navigation.navigate(ROUTES.SEARCH_ADVANCED_FILTERS)}
	medium
	/>

What changes do you think we should make in order to solve the problem?

We should update it to if-else condition, to show the selected button if headerButtonsOptions.length > 0, and else show the filters button

{headerButtonsOptions.length > 0 ? (
    <ButtonWithDropdownMenu
        onPress={() => null}
        shouldAlwaysShowDropdownMenu
        pressOnEnter
        buttonSize={CONST.DROPDOWN_BUTTON_SIZE.MEDIUM}
        customText={translate('workspace.common.selected', {selectedNumber: selectedTransactionsKeys.length})}
        options={headerButtonsOptions}
        isSplitButton={false}
    />
) : (
    <Button
        text={translate('search.filtersHeader')}
        icon={Expensicons.Filters}
        onPress={() => Navigation.navigate(ROUTES.SEARCH_ADVANCED_FILTERS)}
        medium
    />
)}

What alternative solutions did you explore? (Optional)

[Guccio163]

Hi, I'm Wiktor Gut from SWM agency, please assign me this issue!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021832173197655902215

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[mallenexpensify]

@jjcoffee plz review the proposals above, thx

[abzokhattab]

Updated proposal

Added a minor clarification explaining why I used the headerButtonsOptions.length == 0 condition, but the overall solution idea remains unchanged

[Guccio163]

Hi @luacmartins, can you please take a peek at this bug and assign it? It's a pretty small thing connected directly to Search, so I'd love to handle it quickly as part of SWM 🙏

[jjcoffee]

Sounds like @Guccio163 is going to work on this!

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[nyomanjyotisa]

I think the existing proposals need to be reviewed first base on this contributing guideline

[jjcoffee]

@nyomanjyotisa Oh sorry, I hadn't encountered that before! In that case both proposals are basically the same, so I think we're good to go with @abzokhattab's proposal since his was first.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @thienlnam is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[nyomanjyotisa]

I believe the if-else condition proposed in my solution is necessary, since we want to prevent redundant/unnecessary checks and optimize performance

[luacmartins]

Sorry everyone, this is part of the Search project and @Guccio163 is working on this already.

[mallenexpensify]

@abzokhattab and @nyomanjyotisa , once the linked PR has been on production for 7 days, without a regression, I'll review this issue for potential payment. One key point to consider here is this from CONTRIBUTING.md .

You can propose solutions on any issue at any time, but if you propose solutions to jobs before the Help Wanted label is applied, you do so at your own risk. Proposals will not be reviewed until the label is added and there is always a chance that we might not add the label or hire an external contributor for the job.

That doesn't guarantee that no one else will be eligible for compensation, I'll update everyone at the end.

[jjcoffee]

@luacmartins I think you closed this by mistake?

[luacmartins]

Oh for some reason my merge commit closed the issue. Reopening.

[jjcoffee]

Deployed to production Sept 12 so payment should be due 2024-09-19. cc @mallenexpensify

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: N/A - just a missed feature
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: B/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open Search page
2. Ensure no reports are selected
3. Verify that the Filters button is visible and that X selected is not visible
4. Select a few reports
5. Verify that the Filters button is no longer visible and that the X selected button becomes visible

Do we agree 👍 or 👎

[luacmartins]

Thanks! No need for regression tests at this time, we'll add them as part of the project wrap up

[mallenexpensify]

Contributor: @jjcoffee paid $250 via Upwork

Thx!

[nyomanjyotisa]

@mallenexpensify Any update about potential payment based on this?
Since the solution in my proposal was used in the PR

[abzokhattab]

same, since my proposal was the selected solution. please let us know about any potential payments.

Thx!!

[luacmartins]

@nyomanjyotisa @abzokhattab sorry, but this was within the regression period and the Search project is being handled by SWM and myself, so we won't be able to issue additional payments at this time.

[mallenexpensify]

To provide more details...

• Proposals were submitted before Help Wanted was added.
• @Guccio163 from SWM posts that they want to work on it.
• I add the External label to assign a C+
• I remove the Help Wanted label

Based on the above, compensation isn't due.
@Guccio163 if you referenced the proposals and used any code from those (for all or part of the PR), please comment and provide details. Thx