[$250] iOS Report fields - Delete pop-up does not open when trying to delete report field from 3-dot

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.25-11
**Reproducible in staging?:**Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to workspace settings > Report fields
3. Add any type of report field
4. Go to workspace chat
5. Submit an expense
6. Go to workspace settings > Report fields
7. Delete the report field added in Step 3
8. Go back to workspace chat
9. Tap on the expense preview
10. Tap on the report field added in Step 3
11. Tap 3-dot menu (if it does not appear, reopen the app until it appears)
12. Tap Delete

Expected Result:

Delete pop-up will open

Actual Result:

Delete pop-up does not open when trying to delete report field from 3-dot menu

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6585385_1724858161827.ScreenRecording_08-28-2024_23.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0134b2508ecc084f72
• Upwork Job ID: 1830962412826415347
• Last Price Increase: 2024-09-10

Issue Owner

Current Issue Owner: @Pujan92

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to ##wave-control

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delete confirmation for report fields doesn't show when we try to delete it from expense report.

What is the root cause of that problem?

When we select the delete option, we set the visibility of the confirmation modal to true.

App/src/pages/EditReportFieldPage.tsx

Line 101 in c12adce

menuItems.push({icon: Expensicons.Trashcan, text: translate('common.delete'), onSelected: () => setIsDeleteModalVisible(true)});

However, we don't wait until the current modal to hide, so the confirmation modal won't show.

What changes do you think we should make in order to solve the problem?

We need to wait for the current modal to hide first before showing the 2nd one.

We can use Modal.close

Modal.close(() => setIsDeleteModalVisible(true))

OR

Wait for this PR and pass shouldCallAfterModalHide as true.

[melvin-bot]

@bfitzexpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0134b2508ecc084f72

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[bfitzexpensify]

I am heading out of office until September 21st, so assigning a buddy to watch over this in my absence.

Current status: waiting on proposals

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@Pujan92, @bfitzexpensify, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Pujan92]

@bernhardoj's proposal looks good to me and we can use prop shouldCallAfterModalHide for the item.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[bernhardoj]

PR is ready

cc: @Pujan92

[melvin-bot]

This issue has not been updated in over 15 days. @AndrewGable, @Pujan92, @bfitzexpensify, @bernhardoj, @zanyrenney eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[AndrewGable]

@zanyrenney @bfitzexpensify - Looks like automation failed here, can we pay this out? Been on production for 3 weeks.