-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Awaiting Payment Sept 15th][$125] Room-mWeb-Inconsistency in Character allowed to create room from fab & via mentions #48168
Comments
Triggered auto assignment to @trjExpensify ( |
@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Edited by proposal-police: This proposal was edited at 2024-08-29 14:11:05 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Room-mWeb-Inconsistency in Character allowed to create room from fab & via mentions What is the root cause of that problem?Inside the expensify-common, we limit up to 80 characters only {
name: 'reportMentions',
regex: /(?<![^ \n*~_])(#[\p{Ll}0-9-]{1,80})(?![^<]*(?:<\/pre>|<\/code>|<\/a>))/gimu,
replacement: '<mention-report>$1</mention-report>',
}, But here in our case we mention the room name more than 80 characters, which 87 in our case What changes do you think we should make in order to solve the problem?We can change the limit to 99 to match in our FE as the max of the room name length, so it will be: {
name: 'reportMentions',
regex: /(?<![^ \n*~_])(#[\p{Ll}0-9-]{1,99})(?![^<]*(?:<\/pre>|<\/code>|<\/a>))/gimu,
replacement: '<mention-report>$1</mention-report>',
}, I also think we don't need to update the react-native-live-markdown because it already synced with expensify-common meaning the limit for reportMentions is up to expensify-common so when we fix the expensify-common, the react-native-live-markdown will be automatically fixed by updating to expensify-common to the latest version and build it again What alternative solutions did you explore? (Optional) |
Edited by proposal-police: This proposal was edited at 2024-08-28 13:01:34 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Room-mWeb-Inconsistency in Character allowed to create room from fab & via mentions What is the root cause of that problem?We are allowing only 80 characters when we parse reportMenions in common But the room name character limit we are using in FE is 99 here Line 917 in ac5ee2e
What changes do you think we should make in order to solve the problem?We need to be consistent and pick a max limit value and ensure that same value is used in both places Line 917 in ac5ee2e
but if we want the reverse we can update the expensify-common code
What alternative solutions did you explore? (Optional) |
Edited by proposal-police: This proposal was edited at 2024-08-29 09:13:32 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional) |
|
I agree we should be consistent here, but this is a quick fix, so I'm dropping the price. |
Job added to Upwork: https://www.upwork.com/jobs/~018f61735c851b2aec |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov ( |
Proposal Updated
|
Proposal updated
|
Proposal updated
|
Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@alitoshmatov PR ready for review |
@trjExpensify, @stitesExpensify, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Payment summary as follows:
Doesn't look like @alitoshmatov actually reviewed the PR here, so I reduced partial payment of $75 for the proposal review only. Let me know if that's correct, and I'll issue payments after the regression period. |
Melv, go away. @alitoshmatov @NJ-2020, we might need a version bump of expensify-common here actually? |
@trjExpensify Yes we need to bump the expensify-common to the latest version |
Cool, and will you raise a PR for that? |
@trjExpensify PR ready Just to confirm that we only need to update the expensify-common version to the latest version inside react-native-live-markdown only? |
I'll defer to @alitoshmatov on that. 👍 |
@trjExpensify Everything looks good for me |
@trjExpensify @stitesExpensify @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Great, so we should be good here when payment is due. |
📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @NJ-2020 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Okay, offers have been sent. Please accept, and I'll modify accordingly to match this payment summary and close it out. |
Settled up, closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.25
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4896867
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
There must be consistency in Character allowed to create room from fab & via mentions.
Actual Result:
Inconsistency in Character allowed to create room from fab & via mentions.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6584877_1724817879076.bug.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @trjExpensifyThe text was updated successfully, but these errors were encountered: