[$50] "Your data is protected" link is broken

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.24-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @hannojg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724679642375049

Action Performed:

1. Go to staging.new.expensify.com
2. Initiate Add Business Account flow
3. Click Your Data Is Secure link

Expected Result:

https://community.expensify.com/discussion/5677/deep-dive-how-expensify-protects-your-information/ opens without any issue

Actual Result:

Link broken and Error 1014 displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-08-26.at.15.40.09.mov

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0194501906e3889a0d
• Upwork Job ID: 1828335152483406949
• Last Price Increase: 2024-08-27

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0194501906e3889a0d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Upwork job price has been updated to $50

[ijmalik]

Edited by proposal-police: This proposal was edited at 2024-08-27 09:59:28 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.
"Your data is protected" link is not working.

What is the root cause of that problem?

The error persists even when the link is manually pasted into a new browser tab, indicating a problem outside of the our Expensify application.

The root cause of "Error 1014" is likely related to a CNAME Cross-User Banned issue on Cloudflare. This error typically occurs when one domain points to another via a CNAME record, and the domains are managed under different Cloudflare accounts. The issue seems to originate from the configuration of the community.expensify.com domain or its Cloudflare settings.

What changes do you think we should make in order to solve the problem?

If we want to use the same link then contact the administrators responsible for community.expensify.com. Inform them of the "Error 1014" and request that they review the CNAME configurations within their Cloudflare account.

What alternative solutions did you explore?

App/src/pages/ReimbursementAccount/BankAccountStep.tsx

Lines 168 to 173 in d5cfecf

	onPress={() => Link.openExternalLink('https://community.expensify.com/discussion/5677/deep-dive-how-expensify-protects-your-information/')}
	style={[styles.flexRow, styles.alignItemsCenter]}
	accessibilityLabel={translate('bankAccount.yourDataIsSecure')}
	>
	<TextLink href="https://community.expensify.com/discussion/5677/deep-dive-how-expensify-protects-your-information/">
	{translate('bankAccount.yourDataIsSecure')}

Consider providing an alternative link for users to access the content.
Replace above link with https://help.expensify.com/articles/new-expensify/settings/Encryption-and-Data-Security

[github-actions]

Expensify/App Your proposal will be dismissed because you did not follow the proposal template.

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Link is broken when clicking Your Data Is Secure

What is the root cause of that problem?

I think we already migrated from https://community.expensify.com/discussion/5677/deep-dive-how-expensify-protects-your-information/ to https://help.expensify.com/

Because when we open the https://community.expensify.com we got redirected to https://help.expensify.com/
So we need to update the link from https://community.expensify.com to https://help.expensify.com/

What changes do you think we should make in order to solve the problem?

We need to ask Expensify internal team for the right article inside the https://help.expensify.com

And update the below code:

App/src/pages/ReimbursementAccount/BankAccountStep.tsx

Lines 168 to 172 in d5cfecf

	onPress={() => Link.openExternalLink('https://community.expensify.com/discussion/5677/deep-dive-how-expensify-protects-your-information/')}
	style={[styles.flexRow, styles.alignItemsCenter]}
	accessibilityLabel={translate('bankAccount.yourDataIsSecure')}
	>
	<TextLink href="https://community.expensify.com/discussion/5677/deep-dive-how-expensify-protects-your-information/">

What alternative solutions did you explore? (Optional)

[fedirjh]

@adelekennedy, it seems that the URL is outdated and needs to be updated. Can you confirm if this is the correct link?

• https://help.expensify.com/articles/new-expensify/settings/Encryption-and-Data-Security

[fedirjh]

@ijmalik proposal looks good to me. We just need to confirm the correct link #48031 (comment)

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[NJ-2020]

@fedirjh Ijmalik updated the alternative solution very similar to my solution, can you please look at the timestamps
where he updated the alternative solution very similar to my solution after my proposal has been sent

Before he updated the proposal, here's his original alternative solution:

If the issue cannot be resolved on the target domain, consider providing an alternative link for users to access the content.

[fedirjh]

@NJ-2020 I have already checked the timestamps, and the alternative solution looked correct to me as it's a straightforward fix.

[NJ-2020]

@fedirjh But as you can see the alternative solution it's almost exact same, the only difference he provide the link:
https://help.expensify.com/articles/new-expensify/settings/Encryption-and-Data-Security

[fedirjh]

@NJ-2020 Following The contributing guidelines :

Note: Before submitting a proposal on an issue, be sure to read any other existing proposals. ALL NEW PROPOSALS MUST BE DIFFERENT FROM EXISTING PROPOSALS. The difference should be important, meaningful or considerable.

I didn’t really notice any considerable difference between the two solutions. The solution is simple: we just need to update the link.

[NJ-2020]

@fedirjh Yes I've read, but he didn't mention about that earlier

[fedirjh]

Hmmm, he mentioned in his initial proposal that we can use an alternative link. Then he provided the link for us. In any case, @blimpich will make the final decision.

[NJ-2020]

Ok, Thanks

[trjExpensify]

@adelekennedy the community site is being/has been deprecated. For the OP and the expected results, we should include and update in the triage the correct link we expect it to have been replaced by. If you're unsure what that replacement link is, #expensifyhelp would be a good place to ask. 👍

[blimpich]

@adelekennedy do you know if this would be the correct link to replace this with? https://help.expensify.com/articles/new-expensify/settings/Encryption-and-Data-Security

[melvin-bot]

📣 @ijmalik You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[blimpich]

I agree with @fedirjh. Lets go with @ijmalik's proposal 🙂

[melvin-bot]

@ijmalik, @blimpich, @fedirjh, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[blimpich]

@ijmalik are you able to raise a PR soon?

[ijmalik]

< @ijmalik are you able to raise a PR soon?
Yes, I’ll have the PR ready by the end of today.

[ijmalik]

📣 @ijmalik You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

Hi @blimpich ,

I have applied for the Upwork job, but it seems my status hasn’t been updated here yet. Please let me know if any further action is required from my side.

[blimpich]

I don't think you need to do anything else. @adelekennedy are you able to double check that @ijmalik has done all the steps they need to do in order to get paid via Upwork? I believe they have.

[adelekennedy]

sorry! This totally slipped off my radar - I've hired you in Upwork @ijmalik

[blimpich]

This was also deployed to production, so @adelekennedy we should be ready to pay out I believe.

[blimpich]

I'm sorry about this @ijmalik, it looks like some of our automations failed so the payment process for this didn't work as smoothly as it should've. We will make sure to pay you and the C+ who reviewed your work.

[adelekennedy]

Payouts due:

• Contributor: $50 @ijmalik (Upwork) offer pending, once you accept I will pay you out!
• Contributor+: $50 @fedirjh (NewDot)

Upwork job is here.

[ijmalik]

@adelekennedy @blimpich

Thank you very much for the update. I completely understand, and there's no issue with the delay. I appreciate your efforts in resolving this.