[hold for payment 2024-09-26] [$250] iOS - Expense - App crash when clicking on the link settings/workspaces/:policyID/accounting/quic

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.24-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #47696
Email or phone of affected tester (no customers): applausetester+23084alsn@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to www.staging.chat.expensify.com
2. Workspace is connected to QBO
3. Go settings/workspaces/:policyID/accounting/quickbooks-online/export/out-of-pocket-expense/account-select

Expected Result:

Verify list empty content is shown if no account is connected

Actual Result:

App crash when clicking on the link: settings/workspaces/:policyID/accounting/quickbooks-online/export/out-of-pocket-expense/account-select

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2308_1.txt

View all open jobs on GitHub

Bug6580681_1724443956062.7de1c__1_.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0102861cb1eeae8b58
• Upwork Job ID: 1828133199515812262
• Last Price Increase: 2024-08-26
• Automatic offers:
• dukenv0307 | Contributor | 103743156

Issue Owner

Current Issue Owner: @brunovjk

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[github-actions]

user Your proposal will be dismissed because you did not follow the proposal template.

[Nodebrute]

@IuliiaHerets Could you please re-add the labels? no one is assigned here

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - App crash when clicking on the link

What is the root cause of that problem?

This error is not related to the QuickBooks integration. The crash is occurring due to an existing iOS bug where setIsInputInitialized(true) is being called in a loop, resulting in the 'Maximum update depth exceeded' error.

App/src/hooks/useAutoFocusInput.ts

Line 57 in f5e6354

setIsInputInitialized(true);

The issue is caused by an infinite loop triggered by`setIsInputInitialized(true)

What changes do you think we should make in order to solve the problem?

To address the issue of redundant state updates and potential infinite loops in the useAutoFocusInput hook,
here we should early return if inputRef.current is already set (i.e., the TextInput reference has already been assigned). We can do something like this.

if (inputRef.current) {
    return;
}

We can remove this as it's not working as expected

What alternative solutions did you explore? (Optional)

We can also keep the current logic

    if (inputRef.current || isInputInitialized) {
        return;
    }

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crash when clicking on the link: settings/workspaces/:policyID/accounting/quickbooks-online/export/out-of-pocket-expense/account-select

What is the root cause of that problem?

• In this bug, we try to access to the policy which does not exist, so the policy data will be undefined.

• In withPolicy function, we pass policy prop as undefined in this case.

• So in PolicyAccountingPage, if we try to access props.policy.id, app will be crashed, such as:
  

  App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

  Line 51 in 42bed64

  const [connectionSyncProgress] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CONNECTION_SYNC_PROGRESS}${policy.id}`);

What changes do you think we should make in order to solve the problem?

• In here:
  

  App/src/pages/workspace/withPolicy.tsx

  Line 86 in 42bed64

  {...props}

  
  should set fallback value {} for the policy:

                {...props}
                policy={props.policy ?? {}}

• Optional:

1. Update

   App/src/pages/workspace/withPolicy.tsx

   Line 79 in 42bed64

   if (policyID.length > 0) {

        if (policyID.length > 0 && props.policy) {

What alternative solutions did you explore? (Optional)

• Also, we can set the fallback value {} in:
  

  App/src/pages/workspace/withPolicyConnections.tsx

  Line 29 in 42bed64

  function WithPolicyConnections(props: TProps) {

[daledah]

Proposal updated

[melvin-bot]

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0102861cb1eeae8b58

[melvin-bot]

This issue has not been updated in over 15 days. @deetergp, @youssef-lr, @dukenv0307, @daledah eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[deetergp]

I think the automation broke on this one. The PR has been reviewed, merged, and is currently out on production.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[joekaufmanexpensify]

Yep, this is due for payment now.

[joekaufmanexpensify]

Payment due here:

• $250 to @daledah for PR via Upwork.
• $250 to @dukenv0307 for C+ via Upwork

[joekaufmanexpensify]

@daledah offer for $250 sent!

[dukenv0307]

@joekaufmanexpensify No it's not related to #47696. The QA just saw this bug when they executed the PR

In withPolicy function, we pass policy prop as undefined in this case.

This problem even happened before #47696

[dukenv0307]

@Krishna2323 @yuwenmemon Do you agree with that ^?

[joekaufmanexpensify]

Got it, sounds good. TY for confirming!

[joekaufmanexpensify]

I updated the payment summary to reflect that you're due payment too.

[joekaufmanexpensify]

All set to issue payment!

[joekaufmanexpensify]

@daledah $250 sent and contract ended!

[joekaufmanexpensify]

@dukenv0307 $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set, TY everyone!