Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new chat with another user who is not yet on NewDot shows wrong time #4771

Closed
parasharrajat opened this issue Aug 20, 2021 · 18 comments
Assignees
Labels

Comments

@parasharrajat
Copy link
Member

parasharrajat commented Aug 20, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


I used one of the new emails that are not yet on NewDot. And time was shown as PDT which is wrong.

Action Performed:

  1. Open NewDot.
  2. Use one of the emails that have not been on NewDot.
  3. Check the time information before the composer.

Expected Result:

We should not show anytime if we don't know the correct time.

Actual Result:

This is misleading as it shows wrong information.

Workaround:

None.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: Latest
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
WhatsApp Image 2021-08-21 at 3 47 09 AM

Expensify/Expensify Issue URL:

View all open jobs on GitHub

@parasharrajat parasharrajat added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Aug 20, 2021
@MelvinBot
Copy link

Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Aug 20, 2021
@parasharrajat parasharrajat changed the title Creating a new chat with another user who is not yet on NewDot shows timezone in PDT Creating a new chat with another user who is not yet on NewDot shows wrong time Aug 20, 2021
@laurenreidexpensify laurenreidexpensify removed their assignment Aug 21, 2021
@laurenreidexpensify laurenreidexpensify added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Aug 21, 2021
@MelvinBot
Copy link

Triggered auto assignment to @MitchExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Aug 21, 2021
@laurenreidexpensify
Copy link
Contributor

OOO

@MitchExpensify
Copy link
Contributor

I am unable to reproduce this. I don't see any times showing when starting a conversation with accounts that have yet to sign up to Expensify:

image

@parasharrajat
Copy link
Member Author

May be try an email.

@MitchExpensify
Copy link
Contributor

I was also unable to reproduce using email

@MelvinBot MelvinBot removed the Overdue label Aug 26, 2021
@parasharrajat
Copy link
Member Author

Ok. let's keep this open. I will retest and let you know.

@MelvinBot
Copy link

@MitchExpensify Eep! 4 days overdue now. Issues have feelings too...

@MitchExpensify
Copy link
Contributor

Have you been able to replicate this @parasharrajat ?

@MelvinBot MelvinBot removed the Overdue label Sep 1, 2021
@parasharrajat
Copy link
Member Author

I will retest this and let you know. Meanwhile, I think the best is to demote it to weekly.

@MitchExpensify MitchExpensify added Weekly KSv2 and removed Daily KSv2 labels Sep 2, 2021
@MitchExpensify
Copy link
Contributor

I'll give this another week before closing if we don't replicate

@MelvinBot MelvinBot removed the Overdue label Sep 14, 2021
@parasharrajat
Copy link
Member Author

Thanks, I will spare time for this.

@parasharrajat
Copy link
Member Author

@MitchExpensify Steps:

  1. Open App on Web.
  2. Click the new chat from Green :plus button. Enter an email id that does not exist in Expensify yet. For example, it could be any email xxx@mailinator.com.
  3. Timezone is shown in PDT timezone which is incorrect. I tried a personal Gmail account as well and the time was shown in PDT. it gives me the wrong impression. So it's better if we don't show the time for that user.

@MitchExpensify
Copy link
Contributor

Not overdue, on hold

@MitchExpensify
Copy link
Contributor

On hold

@MitchExpensify
Copy link
Contributor

On hold

@MitchExpensify
Copy link
Contributor

On hold

@MitchExpensify
Copy link
Contributor

Taking off hold and was unable to reproduce using these steps. Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants