[HOLD for payment 2024-10-14] Invoicing payments frontend clean-up

[rezkiy37]

Part of the Invoicing payments project

Main issue: https://github.com/Expensify/Expensify/issues/382977
Project: https://github.com/orgs/Expensify/projects/114/views/3

Feature Description

The clean-up issue for the workspace invoicing flow. We need to complete all TODOs and uncomment temporary disabled lines.

Manual Test Steps

Automated Tests

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MonilBhavsar]

@rezkiy37 assigning you to this issue

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[melvin-bot]

@kevinksullivan, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rezkiy37]

This issue is on hold until the backend is ready.

[melvin-bot]

@kevinksullivan, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@kevinksullivan, @rezkiy37 Eep! 4 days overdue now. Issues have feelings too...

[rezkiy37]

Not overdue. #47302 (comment)

[melvin-bot]

@kevinksullivan, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kevinksullivan]

I don't think I need to be on this since there's no contributor payouts necessary. Lmk if I am misunderstanding @rezkiy37

[rezkiy37]

Yes, you are right, @kevinksullivan 🙂

[melvin-bot]

@rezkiy37 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[rezkiy37]

#47302 (comment)

[melvin-bot]

@rezkiy37 Huh... This is 4 days overdue. Who can take care of this?

[rezkiy37]

#47302 (comment)

[melvin-bot]

@rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[VickyStash]

Still waiting for API fixes.
Added a fix for the failure data issue to the Draft PR as well.

[VickyStash]

The PR has been opened for the review.

Note: I'm going to be OOO next week (Sept 16-20) 🌴

[melvin-bot]

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rezkiy37]

I will work on this issue this week 🙂

[rezkiy37]

Hello!
I am OOO from 19.09 - 23.09. I will continue to work on this one when I am back.

[rezkiy37]

I've prepared a draft PR (#49782), however, we need to finish with this issue (#45181) to open and merge the PR.

[rezkiy37]

I am preparing the PR (#49782) for opening.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Uncomment invoicing feature lines #49782

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@madmax330] The PR that introduced the bug has been identified. Link to the PR:
• [@madmax330] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@madmax330] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rezkiy37] Determine if we should create a regression test for this bug.
• [@rezkiy37] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rezkiy37]

[@rezkiy37] Determine if we should create a regression test for this bug.

No, it was not a bug.