[HOLD for payment 2024-09-12] [$250] Workspace - Workspace profile page becomes grayed out when go offline #47260

lanitochka17 · 2024-08-12T19:56:59Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a919@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Login with gmail account
Create workspace
Go offline
Go to workspace profile page

Expected Result:

Workspace profile page should not be grayed out since the workspace was created in online mode

Actual Result:

Workspace profile page becomes grayed out when user goes offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6570133_1723480443136.Recording__3695.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0182138e49511ea4ac
Upwork Job ID: 1823362392640621309
Last Price Increase: 2024-08-27
Automatic offers:

shubham1206agra | Reviewer | 103705107
Krishna2323 | Contributor | 103705109

Issue Owner

Current Issue Owner: @shubham1206agra

melvin-bot · 2024-08-12T19:57:13Z

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 · 2024-08-12T19:57:40Z

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 · 2024-08-12T19:58:10Z

We think that this bug might be related to #vip-vsb

Krishna2323 · 2024-08-12T20:04:14Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Workspace profile page becomes grayed out when go offline

What is the root cause of that problem?

Pending fields are not cleared in success data.

App/src/libs/actions/Policy/Policy.ts

Lines 1596 to 1602 in 5d57ae8

    
           pendingFields: { 
        
               autoReporting: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               approvalMode: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               reimbursementChoice: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
           },

App/src/libs/actions/Policy/Policy.ts

Lines 1673 to 1677 in 5d57ae8

    
           pendingFields: { 
        
               autoReporting: null, 
        
               approvalMode: null, 
        
               reimbursementChoice: null, 
        
           },

What changes do you think we should make in order to solve the problem?

Clear pending fields in success data for generalSettings & description also.

What alternative solutions did you explore? (Optional)

Nodebrute · 2024-08-12T20:34:27Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace profile page becomes grayed out when go offline

What is the root cause of that problem?

We add these pendingFields in optimistic data

App/src/libs/actions/Policy/Policy.ts

Lines 1600 to 1601 in 659011e

    
           generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
           description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,

But we do not remove them in Success data

App/src/libs/actions/Policy/Policy.ts

Lines 1600 to 1601 in 659011e

    
           generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
           description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,

What changes do you think we should make in order to solve the problem?

Actually, there's no need to include these lines because we're not waiting for a backend response for them. The backend response here doesn’t return a description or general settings, so we can safely remove these two lines.

App/src/libs/actions/Policy/Policy.ts

Lines 1600 to 1601 in 659011e

    
           generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
           description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,

What alternative solutions did you explore? (Optional)

melvin-bot · 2024-08-13T14:14:08Z

Job added to Upwork: https://www.upwork.com/jobs/~0182138e49511ea4ac

melvin-bot · 2024-08-13T14:14:12Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

dominictb · 2024-08-14T09:51:49Z

Edited by proposal-police: This proposal was edited at 2024-08-14 11:16:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace profile page becomes grayed out when user goes offline

What is the root cause of that problem?

In this PR, we plan to just add generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION, but description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, is also added.

And these pendingFields are not cleared in successData and failureData:

App/src/libs/actions/Policy/Policy.ts

Lines 1673 to 1677 in 5d57ae8

    
           pendingFields: { 
        
               autoReporting: null, 
        
               approvalMode: null, 
        
               reimbursementChoice: null, 
        
           },

leads to the bug.

What changes do you think we should make in order to solve the problem?

We can add:

                    generalSettings: null,
                    description: null,

in:

App/src/libs/actions/Policy/Policy.ts

Line 2254 in 5d57ae8

pendingFields: {

and

        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
            value: {
                pendingAction: null,
                pendingFields: {
                    autoReporting: null,
                    approvalMode: null,
                    reimbursementChoice: null,
                    generalSettings: null,
                    description: null,
                },
            },
        },

in:

App/src/libs/actions/Policy/Policy.ts

Line 2321 in 5d57ae8

const failureData: OnyxUpdate[] = [

After this PR, we will use separately pending field outputCurrency and address instead of using generalSettings. So we need to add these pending to:

App/src/libs/actions/Policy/Policy.ts

Line 1596 in 5d57ae8

pendingFields: {

address: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD

and then also clear these in successData and failureData.

What alternative solutions did you explore? (Optional)

We can remove all the pendingFields:

App/src/libs/actions/Policy/Policy.ts

Lines 1596 to 1602 in 5d57ae8

    
           pendingFields: { 
        
               autoReporting: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               approvalMode: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               reimbursementChoice: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
           },

then update:

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 199 in 5d57ae8

                            <OfflineWithFeedback pendingAction={policy?.pendingFields?.generalSettings ?? policy?.pendingAction}>

Similar logic should applied to:

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 214 in 5d57ae8

pendingAction={policy?.pendingFields?.description}

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 232 in 5d57ae8

pendingAction={policy?.pendingFields?.generalSettings}

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 252 in 5d57ae8

dominictb · 2024-08-14T11:16:38Z

Proposal updated

Krishna2323 · 2024-08-14T11:26:17Z

@shubham1206agra, just to note, the changes in this PR should be handled there only, or we can hold off until that PR is merged. It has nothing to do with this issue. The general solution will be the same, to add missing pending fields. The pending fields were intentionally added in this PR, so I think we shouldn't remove them.

melvin-bot · 2024-08-16T18:22:12Z

@puneetlath, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot · 2024-08-20T16:00:05Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot · 2024-08-20T18:18:03Z

@puneetlath, @shubham1206agra 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

puneetlath · 2024-08-21T19:44:37Z

@shubham1206agra thoughts on the proposals?

melvin-bot · 2024-08-22T18:10:25Z

@puneetlath, @shubham1206agra Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

shubham1206agra · 2024-08-23T02:31:15Z

@Krishna2323's proposal looks good.

🎀👀🎀 C+ reviewed

melvin-bot · 2024-08-23T02:31:26Z

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

dominictb · 2024-08-23T02:40:36Z

@shubham1206agra Can you check my proposal? It will work in the latest code changes in main branch.

shubham1206agra · 2024-08-23T02:43:30Z

I think @Krishna2323 proposal and #47260 (comment) is fine with me.

dominictb · 2024-08-23T02:45:23Z

With the changes in the selected proposal, the policy name is not grey out when creating policy in offline. Because now, we use policy?.pendingFields?.name as the pending action for the policy name:

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 199 in 844c6bf

dominictb · 2024-08-23T02:52:53Z

Btw, as mentioned in @Krishna2323 's comment:

The general solution will be the same, to add missing pending fields

So I think he can handle the details when creating PR. So that solution looks good.

melvin-bot · 2024-08-26T17:59:49Z

@puneetlath @shubham1206agra this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot · 2024-08-26T18:20:31Z

@puneetlath, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

shubham1206agra · 2024-08-27T05:41:41Z

Waiting on assignment from @puneetlath

melvin-bot · 2024-08-27T13:09:17Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Nodebrute · 2024-08-27T13:59:37Z

@shubham1206agra just a quick update: we no longer use generalsettings. The only thing left in the pending fields is description. I've mentioned in my proposal that we should remove it.

App/src/libs/actions/Policy/Policy.ts

Line 1632 in 9ddca5c

description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,

In the backend response, we don’t check for description. According to the Offline_UX, we’re using the Optimistic Without Feedback Pattern, which means we shouldn’t change the UI in offline mode since we're not waiting for server confirmation.

cc:@puneetlath

shubham1206agra · 2024-08-27T14:28:10Z

@Nodebrute Thank you for the input. But your reasoning is wrong. We are using pattern B here. We should keep the description greyed out while creating the workspace. So, we will proceed with @Krishna2323's proposal as usual. And I will ask the deploy blocker to be marked as closed.

Nodebrute · 2024-08-27T14:30:03Z

@shubham1206agra Thanks for clearing that up 🙂

shubham1206agra · 2024-08-27T15:13:03Z

@puneetlath I think you wrote in the wrong issue

melvin-bot · 2024-08-27T16:00:15Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot · 2024-08-27T16:38:29Z

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-08-27T16:38:34Z

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

shubham1206agra · 2024-09-07T15:50:42Z

@trjExpensify Can you add label for payment on 12th September?

trjExpensify · 2024-09-10T00:07:41Z

@puneetlath has actioned on that, I've added the Awaiting payment label as well now.

puneetlath · 2024-09-13T02:35:10Z

I've paid @Krishna2323.

@shubham1206agra can you please complete the checklist?

shubham1206agra · 2024-09-13T03:00:06Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: fix profile page not greyed out #46130
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/46130/files#r1758104072
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required
[@shubham1206agra] Determine if we should create a regression test for this bug. No
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

puneetlath · 2024-09-13T03:37:07Z

Ok great. All paid. Thanks everyone!

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 12, 2024

melvin-bot bot assigned puneetlath Aug 12, 2024

puneetlath added the External Added to denote the issue can be worked on by a contributor label Aug 13, 2024

melvin-bot bot changed the title ~~Workspace - Workspace profile page becomes grayed out when go offline~~ [$250] Workspace - Workspace profile page becomes grayed out when go offline Aug 13, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 13, 2024

melvin-bot bot assigned shubham1206agra Aug 13, 2024

melvin-bot bot added the Overdue label Aug 16, 2024

melvin-bot bot removed the Overdue label Aug 23, 2024

melvin-bot bot added the Overdue label Aug 26, 2024

melvin-bot bot removed the Overdue label Aug 27, 2024

shubham1206agra mentioned this issue Aug 27, 2024

Workspace-Description in workspace greyout in offline without making any changes #48076

Closed

6 tasks

puneetlath assigned Krishna2323 Aug 27, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 27, 2024

Krishna2323 mentioned this issue Aug 27, 2024

fix: Workspace - Workspace profile page becomes grayed out when go offline. #48131

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 27, 2024

puneetlath changed the title ~~[$250] Workspace - Workspace profile page becomes grayed out when go offline~~ [HOLD for payment 2024-09-12] [$250] Workspace - Workspace profile page becomes grayed out when go offline Sep 9, 2024

trjExpensify added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Sep 10, 2024

shubham1206agra mentioned this issue Sep 13, 2024

fix profile page not greyed out #46130

Merged

50 tasks

puneetlath closed this as completed Sep 13, 2024

[HOLD for payment 2024-09-12] [$250] Workspace - Workspace profile page becomes grayed out when go offline #47260

[HOLD for payment 2024-09-12] [$250] Workspace - Workspace profile page becomes grayed out when go offline #47260

Comments

lanitochka17 commented Aug 12, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Aug 12, 2024

lanitochka17 commented Aug 12, 2024

lanitochka17 commented Aug 12, 2024

Krishna2323 commented Aug 12, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Nodebrute commented Aug 12, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Aug 13, 2024

melvin-bot bot commented Aug 13, 2024

dominictb commented Aug 14, 2024 • edited by github-actions bot Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dominictb commented Aug 14, 2024

Proposal updated

Krishna2323 commented Aug 14, 2024

melvin-bot bot commented Aug 16, 2024

melvin-bot bot commented Aug 20, 2024

melvin-bot bot commented Aug 20, 2024

puneetlath commented Aug 21, 2024

melvin-bot bot commented Aug 22, 2024

shubham1206agra commented Aug 23, 2024

melvin-bot bot commented Aug 23, 2024

dominictb commented Aug 23, 2024

shubham1206agra commented Aug 23, 2024

dominictb commented Aug 23, 2024

dominictb commented Aug 23, 2024

melvin-bot bot commented Aug 26, 2024

melvin-bot bot commented Aug 26, 2024

shubham1206agra commented Aug 27, 2024

melvin-bot bot commented Aug 27, 2024

Nodebrute commented Aug 27, 2024 • edited Loading

shubham1206agra commented Aug 27, 2024

Nodebrute commented Aug 27, 2024

shubham1206agra commented Aug 27, 2024

melvin-bot bot commented Aug 27, 2024

melvin-bot bot commented Aug 27, 2024

melvin-bot bot commented Aug 27, 2024

shubham1206agra commented Sep 7, 2024

trjExpensify commented Sep 10, 2024

puneetlath commented Sep 13, 2024

shubham1206agra commented Sep 13, 2024

puneetlath commented Sep 13, 2024

lanitochka17 commented Aug 12, 2024 •

edited by melvin-bot bot

Loading

dominictb commented Aug 14, 2024 •

edited by github-actions bot

Loading

Nodebrute commented Aug 27, 2024 •

edited

Loading