[$250] Workspace - New workspace is not updated on secondary device workspace lists

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.17-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a866@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Login same user on two different devices

1. On secondary device create new workspace
2. On main device (android/app) verify that workspace rooms appear on LHN
3. On main device go to FAB> Workspace

Expected Result:

Workspace created by secondary device should be added to workspace list on main device

Actual Result:

Workspace created by secondary device does not update to workspace list on main device

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6564316_1723029843550.Recording__3662.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ba4bb9fd56f1e410
• Upwork Job ID: 1821618854120104260
• Last Price Increase: 2024-08-15

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ba4bb9fd56f1e410

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

@hoangzinh, @isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hoangzinh]

Not overdue. Waiting on proposals

[hoangzinh]

Same as above

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[tsa321]

I think this is a backend issue:

The pushJSON policy data doesn't contain policy.role data, which makes this check to fail:"

App/src/libs/PolicyUtils.ts

Lines 169 to 176 in 75f1729

	function shouldShowPolicy(policy: OnyxEntry<Policy>, isOffline: boolean): boolean {
	return (
	!!policy &&
	(policy?.type !== CONST.POLICY.TYPE.PERSONAL || !!policy?.isJoinRequestPending) &&
	(isOffline || policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || Object.keys(policy.errors ?? {}).length > 0) &&
	!!policy?.role
	);
	}

[hoangzinh]

Yep, It might be a BE issue. Fyi: the condition above ^ is added from this issue #44811 based on @cristipaval's here #44811 (comment)

@isabelastisser can you add "internal" label for this issue?

[melvin-bot]

@hoangzinh @isabelastisser this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[hoangzinh]

Not overdue, waiting for an internal engineer pick this issue

[melvin-bot]

@hoangzinh, @isabelastisser Eep! 4 days overdue now. Issues have feelings too...

[isabelastisser]

Still waiting for engineering assignment.

[hoangzinh]

Not overdue

[trjExpensify]

Based on this comment, @cristipaval @madmax330 looks like it's related to changes made in #vip-billpay with the introduction of invoice rooms. Are you still around Cristi for this quick fix?

@isabelastisser for anything going into #wave-collect as a Hot pick can you put it that column so it's easier for me to find -- or tag me or something. Thanks!

[cristipaval]

Backend PR up for review

[hoangzinh]

Not overdue. BE PR is ready.

[trjExpensify]

Assigning @cristipaval as he's put up a PR for this.

[trjExpensify]

Once this is deployed, it can be retested @isabelastisser! https://github.com/Expensify/Web-Expensify/pull/43326

[isabelastisser]

Thanks, Tom!

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[trjExpensify]

Deployed to prod 5 days ago, we're fixed here.