[$250] Android - scan - In mweb, in "your split amount" place (0) is displayed but in Android it is not

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.16
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4801165
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch Android app and mweb
2. Create a scanned split expense with 4 participants with amount 0.08
3. Open the report and note preview

Expected Result:

In mweb and Android, the behaviour of displaying split amount must be consistent

Actual Result:

In mweb, in "your split amount" place zero (0) is displayed but in Android it is not shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6559577_1722542646012.Screenrecorder-2024-08-02-01-24-51-312_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010e8f218196384ca1
• Upwork Job ID: 1820842286524273233
• Last Price Increase: 2024-08-06
• Automatic offers:
• rojiphil | Reviewer | 103496878

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-split

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In split money request preview, 0 is shown.

What is the root cause of that problem?

The "your split amount" shows the split amount for each participant. If the current user split share is 0, then 0 is shown because 0 && </> will render 0 because 0 is falsey.

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Lines 393 to 397 in 49435db

	{splitShare && (
	<Text style={[styles.textLabel, styles.colorMuted, styles.ml1, styles.amountSplitPadding]}>
	{translate('iou.yourSplit', {amount: CurrencyUtils.convertToDisplayString(splitShare ?? 0, requestCurrency)})}
	</Text>
	)}

What changes do you think we should make in order to solve the problem?

We should cast it to a boolean using !!.

{!!splitShares && </>}

Also, the splitShares type is currently a number or boolean,

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Lines 272 to 278 in 49435db

	const splitShare = useMemo(
	() =>
	shouldShowSplitShare &&
	(transaction?.comment?.splits?.find((split) => split.accountID === sessionAccountID)?.amount ??
	IOUUtils.calculateAmount(isPolicyExpenseChat ? 1 : participantAccountIDs.length - 1, requestAmount, requestCurrency ?? '', action.actorAccountID === sessionAccountID)),
	[shouldShowSplitShare, isPolicyExpenseChat, action.actorAccountID, participantAccountIDs.length, transaction?.comment?.splits, requestAmount, requestCurrency, sessionAccountID],
	);

we can fix this too by returning 0 if shouldShowSplitShare is false.

shouldShowSplitShare ? ... : 0

[github-actions]

true

[melvin-bot]

@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010e8f218196384ca1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[melvin-bot]

@rojiphil, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[rojiphil]

Since a split value of 0 is a possible value for a participant, not showing anything makes sense. And displaying 0 does not make sense at all.
Casting splitShare to boolean makes sense to solve this issue.
@bernhardoj proposal LGTM.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[marcochavezf]

Sounds good @rojiphil, assigning @bernhardoj 🚀

[melvin-bot]

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @rojiphil

[bernhardoj]

The PR was deployed 2 weeks ago, so this should be ready for payment.

Requested in ND.

[JmillsExpensify]

Waiting on the payment summary

[melvin-bot]

This issue has not been updated in over 15 days. @rojiphil, @marcochavezf, @muttmuure, @bernhardoj eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[rojiphil]

Oh! The automation failed here.
@muttmuure Can you please help with payment here as this has been in production since the last 3 weeks?

[muttmuure]

$250 - @rojiphil
$250 - @bernhardoj

[bernhardoj]

Requested in ND.

[rojiphil]

@muttmuure Accepted offer on Upwork. Awaiting payment. Thanks.

[muttmuure]

Paid

[JmillsExpensify]

$250 approved for @bernhardoj