-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for Payment 2024-08-22][$250] Search - Expense RHP closes after clicking on the From subtitle link #46518
Comments
Triggered auto assignment to @jliexpensify ( |
@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.The expense RHP closes after clicking on the From subtitle link What is the root cause of that problem?When we open the report detail page from RHP Report Screen and click on the parent subtitle, we use App/src/components/ParentNavigationSubtitle.tsx Lines 44 to 47 in 8e79c59
We only navigate back to the App/src/libs/Navigation/Navigation.ts Line 211 in 8e79c59
What changes do you think we should make in order to solve the problem?We should pass
What alternative solutions did you explore? (Optional)We can use
App/src/components/ParentNavigationSubtitle.tsx Lines 44 to 47 in 8e79c59
|
Job added to Upwork: https://www.upwork.com/jobs/~01d7addf8985df968d |
I'm able to repro this |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
I am unable to replicate in the latest CleanShot.2024-08-01.at.12.08.30.mp4 |
@fedirjh I'm still able to reproduce this on the latest main bug by disabling the strict mode. Correct me if I missed something. Screen.Recording.2024-08-01.at.20.24.02.mov |
@jliexpensify, @fedirjh Huh... This is 4 days overdue. Who can take care of this? |
Thank you, @nkdengineer, for the suggestion. I managed to reproduce the issue on the dev by disabling strict mode. The proposed solution also seems satisfactory to me, so let's move forward with implementing the main solution. Let's proceed with @nkdengineer's proposal; 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@NikkiWines Please help to take a look when you have a chance, thanks. |
Sorry for the delay, agreed that @nkdengineer's proposal looks good 👍 |
📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
BugZero Checklist:
Regression Test Proposal
|
Paying now, apologies for the delay!
|
Paid and job remvoed |
$250 approved for @fedirjh |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.14-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
App will open the report from the subtitle link
Actual Result:
The expense RHP closes after clicking on the From subtitle link
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6557025_1722319302164.20240730_135933.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @fedirjhThe text was updated successfully, but these errors were encountered: