[HOLD for payment 2024-08-29] [$250] Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense #46373

lanitochka17 · 2024-07-27T23:17:54Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.13-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace chat
Submit two expenses with same amount and merchant, but one with receipt and one without receipt
Click on the transaction thread of the expense with receipt
Click Review duplicates
Click Keep this one on the expense with receipt
Proceed to confirmation page
Click on the receipt on the confirmation page
Remove the receipt

Expected Result:

Since user is removing the receipt from the confirmation page, the receipt on the actual expense will not be removed, as the changes have not been "confirmed" yet

Actual Result:

When user removes the receipt from the confirmation page, the receipt on the actual expense is also removed, even when the Confirm button is not clicked

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6554746_1722091745819.bandicam_2024-07-27_22-40-17-853.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e50d0c63fac1b4f3
Upwork Job ID: 1818139062818817325
Last Price Increase: 2024-07-30
Automatic offers:

gijoe0295 | Contributor | 103539656

Issue Owner

Current Issue Owner: @anmurali

melvin-bot · 2024-07-27T23:18:05Z

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 · 2024-07-27T23:18:28Z

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 · 2024-07-27T23:18:45Z

We think that this bug might be related to #wave-collect - Release 2

gijoe0295 · 2024-07-28T07:53:20Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

When user removes the receipt from the confirmation page, the receipt on the actual expense is also removed, even when the Confirm button is not clicked

What is the root cause of that problem?

We should not allow edit/delete the receipt when in duplicate confirmation page, just like other fields are not editable.

App/src/pages/TransactionDuplicate/Confirmation.tsx

Lines 79 to 82 in 86b923d

    
           <MoneyRequestView 
        
               report={report} 
        
               shouldShowAnimatedBackground={false} 
        
               readonly

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 499 in 9f650ba

interactive={canEditAmount && !readonly}

What changes do you think we should make in order to solve the problem?

To do that, we need to implement a mechanism to pass readonly from MoneyRequestView to TransactionReceipt page. Since they are not within a component tree, we can leverage the route params.

Introduce a new prop readonly to ReportActionItemImage and pass it from MoneyRequestView here
Introduce a new param readonly to TransactionReceipt screen here and its route here
When we navigate to TransactionReceipt screen from ReportActionItemImage here, remember to pass readonly to getRoute
In TransactionReceipt, retrieve the readonly param from route and append to the canEditReceipt condition here to canEditReceipt={canEditReceipt && !readonly}

gijoe0295 · 2024-07-28T07:59:53Z

Proposal Update

Update code permalink
Add detailed explanation to solution and RCA (no changes in general idea)

Krishna2323 · 2024-07-28T10:20:04Z

Edited by proposal-police: This proposal was edited at 2023-10-10T12:34:56Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense

What is the root cause of that problem?

On dupe confirmation page we disable all the field except receipt ReportActionItemImage. We should not allow user to open receipt on confirmation page, this is also the behaviour on submit request confirmation page.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 459 to 468 in 08bb00b

    
           <ReportActionItemImage 
        
               thumbnail={receiptURIs?.thumbnail} 
        
               fileExtension={receiptURIs?.fileExtension} 
        
               isThumbnail={receiptURIs?.isThumbnail} 
        
               image={receiptURIs?.image} 
        
               isLocalFile={receiptURIs?.isLocalFile} 
        
               filename={receiptURIs?.filename} 
        
               transaction={transaction} 
        
               enablePreviewModal 
        
           />

money_request_confrimation.mp4

What changes do you think we should make in order to solve the problem?

We already have enablePreviewModal prop in ReportActionItemImage.tsx which will prevent the app to open modal when enablePreviewModal is false because it renders only ReceiptImage without PressableWithoutFocus.

App/src/components/ReportActionItem/ReportActionItemImage.tsx

Lines 124 to 143 in 08bb00b

    
           if (enablePreviewModal) { 
        
               return ( 
        
                   <ShowContextMenuContext.Consumer> 
        
                       {({report, transactionThreadReport}) => ( 
        
                           <PressableWithoutFocus 
        
                               style={[styles.w100, styles.h100, styles.noOutline as ViewStyle]} 
        
                               onPress={() => 
        
                                   Navigation.navigate(ROUTES.TRANSACTION_RECEIPT.getRoute(transactionThreadReport?.reportID ?? report?.reportID ?? '-1', transaction?.transactionID ?? '-1')) 
        
                               } 
        
                               accessibilityLabel={translate('accessibilityHints.viewAttachment')} 
        
                               accessibilityRole={CONST.ROLE.BUTTON} 
        
                           > 
        
                               <ReceiptImage {...propsObj} /> 
        
                           </PressableWithoutFocus> 
        
                       )} 
        
                   </ShowContextMenuContext.Consumer> 
        
               ); 
        
           } 
        
           return <ReceiptImage {...propsObj} />;

We need to update the enablePreviewModal prop to enablePreviewModal={!readonly}.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 467 in 08bb00b

enablePreviewModal

What alternative solutions did you explore? (Optional)

We can introduce a new prop interactive in ReportActionItemImage and pass it to PressableWithoutFocus interactive prop. The default value will be true
From MoneyRequestView we can pass !readonly to interactive prop of ReportActionItemImage.

Result

receipt_image_interactive_dupe_detection.mp4

Alternative

We can check the last route and if it is SCREENS.TRANSACTION_DUPLICATE.REVIEW, we will set the canEditReceipt to false. Similar approach is used here to do tasks according to the previous route. I still prefer the main solution since all other fields are also disabled and receipt should also behave the same way.

    const isLastRouteDuplicateReview = (navigationRef.getRootState()?.routes?.at(-2)?.params?.params?.screen ?? '') === SCREENS.TRANSACTION_DUPLICATE.REVIEW;
    const canEditReceipt = ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.RECEIPT) && !isLastRouteDuplicateReview;
    
    // If we want to hide the three dot icon, we can modify `allowDownload` prop.
    allowDownload={!isEReceipt && !isLastRouteDuplicateReview}

App/src/pages/TransactionReceiptPage.tsx

Line 36 in f7e265a

    
           const canEditReceipt = ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.RECEIPT);

App/src/pages/TransactionReceiptPage.tsx

Line 62 in f7e265a

allowDownload={!isEReceipt}

Result Alternative

Monosnap.screencast.2024-07-31.18-11-07.mp4

melvin-bot · 2024-07-30T04:18:29Z

Job added to Upwork: https://www.upwork.com/jobs/~01e50d0c63fac1b4f3

melvin-bot · 2024-07-30T04:18:34Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

Krishna2323 · 2024-07-31T12:43:36Z

Proposal Updated

Added alternative solution and result video for that

JmillsExpensify · 2024-08-01T23:47:33Z

@sobitneupane mind reviewing the proposals so far?

sobitneupane · 2024-08-02T11:30:49Z

Thanks for the proposal everyone.

Proposal from @Krishna2323 looks good to me.

🎀 👀 🎀 C+ reviewed

melvin-bot · 2024-08-02T11:31:01Z

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

github-actions · 2024-08-02T11:31:05Z

true

gijoe0295 · 2024-08-02T11:53:16Z

@sobitneupane That means they cannot even preview the receipt. I think we only need to block deleting. @JmillsExpensify can you confirm the expected behavior here?

trjExpensify · 2024-08-05T18:08:49Z

I agree, they should be able to open the receipt in the full screen mode, but it's read-only, like the other fields on the expense in this dupe confirmation screen - so we should remove the three dot overflow menu in this case:

CC: @pecanoro for vis as well :)

melvin-bot · 2024-08-05T18:45:48Z

@anmurali, @sobitneupane, @stitesExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

stitesExpensify · 2024-08-15T15:09:54Z

Thank you both for taking a second look! Moving forward with @gijoe0295

melvin-bot · 2024-08-15T15:10:08Z

📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

dylanexpensify · 2024-08-15T20:21:03Z

@gijoe0295 mind giving us a rough idea of when you'll have the PR raised for review?

melvin-bot · 2024-08-22T16:51:19Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-08-22T16:51:23Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: receipt in dupe detect is removable #47536

If no regressions arise, payment will be issued on 2024-08-29. 🎊

For reference, here are some details about the assignees on this issue:

@sobitneupane requires payment through NewDot Manual Requests
@gijoe0295 requires payment automatic offer (Contributor)

melvin-bot · 2024-08-22T16:51:24Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane] Determine if we should create a regression test for this bug.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

gijoe0295 · 2024-08-29T21:39:46Z

@anmurali This is ready for payment.

sobitneupane · 2024-09-02T08:24:16Z

Regression Test Proposal:

Submit 2 duplicated expenses with receipts
Go to the thread transaction report
Press Review duplicates
Proceed to confirmation page
Press receipt preview
Press 3-dot menu
Verify "Replace" and "Delete receipt" options are not shown

Do we agree 👍 or 👎

sobitneupane · 2024-09-02T08:31:09Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#40153

[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

I don't think we can blame the PR for creating this issue as it is more of a feature-request than a bug.

[@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#46373 (comment)

melvin-bot · 2024-09-02T18:10:25Z

@anmurali, @sobitneupane, @stitesExpensify, @gijoe0295 Huh... This is 4 days overdue. Who can take care of this?

stitesExpensify · 2024-09-03T18:45:34Z

@anmurali all you on this one!

melvin-bot · 2024-09-04T18:03:37Z

@anmurali, @sobitneupane, @stitesExpensify, @gijoe0295 Still overdue 6 days?! Let's take care of this!

melvin-bot · 2024-09-06T18:07:51Z

@anmurali, @sobitneupane, @stitesExpensify, @gijoe0295 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

anmurali · 2024-09-09T23:38:36Z

Payment Summary

@sobitneupane $250 approved, request via New Dot
@gijoe0295 $250 approved, paid via Upwork

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 27, 2024

melvin-bot bot assigned anmurali Jul 27, 2024

gijoe0295 mentioned this issue Jul 29, 2024

[$250] Expense - Shouldn't show "delete receipt" option for eReceipts #46289

Closed

6 tasks

JmillsExpensify added the External Added to denote the issue can be worked on by a contributor label Jul 30, 2024

melvin-bot bot changed the title ~~Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense~~ [$250] Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense Jul 30, 2024

melvin-bot bot added Overdue Help Wanted Apply this label when an issue is open to proposals by contributors labels Jul 30, 2024

melvin-bot bot assigned sobitneupane Jul 30, 2024

melvin-bot bot removed the Overdue label Jul 30, 2024

melvin-bot bot added the Overdue label Aug 1, 2024

melvin-bot bot removed the Overdue label Aug 2, 2024

melvin-bot bot assigned stitesExpensify Aug 2, 2024

melvin-bot bot added the Overdue label Aug 5, 2024

stitesExpensify assigned gijoe0295 Aug 15, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 15, 2024

gijoe0295 mentioned this issue Aug 16, 2024

fix: receipt in dupe detect is removable #47536

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Aug 16, 2024

melvin-bot bot changed the title ~~[$250] Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense~~ [HOLD for payment 2024-08-29] [$250] Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense Aug 22, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Aug 22, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 28, 2024

melvin-bot bot added the Overdue label Aug 30, 2024

anmurali closed this as completed Sep 9, 2024

melvin-bot bot removed the Overdue label Sep 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-08-29] [$250] Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense #46373

[HOLD for payment 2024-08-29] [$250] Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense #46373

lanitochka17 commented Jul 27, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 27, 2024

lanitochka17 commented Jul 27, 2024

lanitochka17 commented Jul 27, 2024

gijoe0295 commented Jul 28, 2024 •

edited

Loading

gijoe0295 commented Jul 28, 2024

Krishna2323 commented Jul 28, 2024 •

edited by github-actions bot

Loading

melvin-bot bot commented Jul 30, 2024

melvin-bot bot commented Jul 30, 2024

Krishna2323 commented Jul 31, 2024

JmillsExpensify commented Aug 1, 2024

sobitneupane commented Aug 2, 2024

melvin-bot bot commented Aug 2, 2024

github-actions bot commented Aug 2, 2024

gijoe0295 commented Aug 2, 2024

trjExpensify commented Aug 5, 2024

melvin-bot bot commented Aug 5, 2024

stitesExpensify commented Aug 15, 2024

melvin-bot bot commented Aug 15, 2024

dylanexpensify commented Aug 15, 2024

melvin-bot bot commented Aug 22, 2024

melvin-bot bot commented Aug 22, 2024

melvin-bot bot commented Aug 22, 2024

gijoe0295 commented Aug 29, 2024

sobitneupane commented Sep 2, 2024 •

edited

Loading

sobitneupane commented Sep 2, 2024

melvin-bot bot commented Sep 2, 2024

stitesExpensify commented Sep 3, 2024

melvin-bot bot commented Sep 4, 2024

melvin-bot bot commented Sep 6, 2024

anmurali commented Sep 9, 2024

[HOLD for payment 2024-08-29] [$250] Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense #46373

[HOLD for payment 2024-08-29] [$250] Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense #46373

Comments

lanitochka17 commented Jul 27, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Jul 27, 2024

lanitochka17 commented Jul 27, 2024

lanitochka17 commented Jul 27, 2024

gijoe0295 commented Jul 28, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

gijoe0295 commented Jul 28, 2024

Proposal Update

Krishna2323 commented Jul 28, 2024 • edited by github-actions bot Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

Alternative

Result Alternative

melvin-bot bot commented Jul 30, 2024

melvin-bot bot commented Jul 30, 2024

Krishna2323 commented Jul 31, 2024

Proposal Updated

JmillsExpensify commented Aug 1, 2024

sobitneupane commented Aug 2, 2024

melvin-bot bot commented Aug 2, 2024

github-actions bot commented Aug 2, 2024

gijoe0295 commented Aug 2, 2024

trjExpensify commented Aug 5, 2024

melvin-bot bot commented Aug 5, 2024

stitesExpensify commented Aug 15, 2024

melvin-bot bot commented Aug 15, 2024

dylanexpensify commented Aug 15, 2024

melvin-bot bot commented Aug 22, 2024

melvin-bot bot commented Aug 22, 2024

melvin-bot bot commented Aug 22, 2024

gijoe0295 commented Aug 29, 2024

sobitneupane commented Sep 2, 2024 • edited Loading

sobitneupane commented Sep 2, 2024

melvin-bot bot commented Sep 2, 2024

stitesExpensify commented Sep 3, 2024

melvin-bot bot commented Sep 4, 2024

melvin-bot bot commented Sep 6, 2024

anmurali commented Sep 9, 2024

Payment Summary

lanitochka17 commented Jul 27, 2024 •

edited by melvin-bot bot

Loading

gijoe0295 commented Jul 28, 2024 •

edited

Loading

Krishna2323 commented Jul 28, 2024 •

edited by github-actions bot

Loading

sobitneupane commented Sep 2, 2024 •

edited

Loading