-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hold for payment: 2024-09-20] [$250] Track expense - Clicking back navigates user back to the share with my accountant flow #45774
Comments
Triggered auto assignment to @dylanexpensify ( |
We think that this bug might be related to #vip-vsp |
@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
This comment was marked as outdated.
This comment was marked as outdated.
@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Job added to Upwork: https://www.upwork.com/jobs/~01b38481aa14324c79 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 ( |
reviewed |
ProposalPlease re-state the problem that we are trying to solve in this issue.When using the browser's back button to navigate after sharing an expense there share modal needs to be closed. What is the root cause of that problem?There is no action being made to close the modal after sharing the expense and navigating to the next page. What changes do you think we should make in order to solve the problem? We can dismiss the modal, then we need to wait for it to be removed from our navigation state before we move forward. switch (action) {
case CONST.IOU.ACTION.SHARE: {
Navigation.dismissModal(linkedTrackedExpenseReportID)
Navigation.isNavigationReady().then(() => {
Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(activeReportID ?? "-1"))
Navigation.isNavigationReady().then(() => {
Navigation.navigate(ROUTES.ROOM_INVITE.getRoute(activeReportID ?? '-1', CONST.IOU.SHARE.ROLE.ACCOUNTANT));
})
})
break
}
default: {
Navigation.dismissModal(activeReportID);
}
} Additionally I noticed the same issue with the "Invite to workspace" modal. It will cause the same problem so we should dismiss that as well. Navigation.dismissModal(reportID ?? "-1")
Navigation.navigate(backRoute); Here is a test branch with my changes What alternative solutions did you explore? (Optional)N/A |
Thanks for your proposal @Zakpak0 . When the right hand panel opens with the Invite Page, the Centre Pane should show the workspace chat. I tested your branch. It shows the selfDM chat in the Center Pane when the Invite Page appears in the Could you fix that? |
Browser back button on Invite Page in Right Hand Panel (RHP) takes the user to Share RHP with the latest branch. This should not happen. backShare.mp4 |
ProposalUpdated issue-45774.mp4 |
@dylanexpensify, @c3024 Huh... This is 4 days overdue. Who can take care of this? |
@Zakpak0 That branch works, but it seems more like a workaround to delay navigation to the room invite page. Navigation is ready all the time in this case. I think the current bug is due to navigating to the room invite page before |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@c3024 thanks, this makes a lot of sense. I'm going to check this out right now! |
@dylanexpensify @c3024 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@dylanexpensify, @c3024 10 days overdue. Is anyone even seeing these? Hello? |
I'll update. |
I am not sure if the task queued in the microtask queue always gets executed after the dismiss modal action is complete. The dismiss modal action might take a bit longer, and since the navigate action is in a different promise chain, it might get executed earlier. Ideally, we should chain the navigate action to a dismiss modal action function returning a promise, like this. However, in practice, the delay caused by adding the @WojtekBoman and @shubham1206agra's proposals here and here LGTM! 🎀 👀 🎀 C+ Reviewed |
Triggered auto assignment to @cead22, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@c3024 sorry, can you clarify which one you selected? |
Both proposals are the same. @WojtekBoman is an expert agency member. I think @shubham1206agra asked him for the fix for this on Slack here and he posted a proposal in the standard format with the same solution. So, I guess Shubham will work on it if he is assigned. |
📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@cead22, @shubham1206agra, @dylanexpensify, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I will raise the PR toady. |
Automation failed here. Deployed to production on 13-Sep. I think this should be on cc: @dylanexpensify |
Payment summary: Contributor: @shubham1206agra $250 Please apply/request! |
@dylanexpensify I accepted the offer |
Gentle bump for payment @dylanexpensify |
done! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
App should navigate user back to the previously opened chat report
Actual Result:
App navigates user back to the "Share with my accountant" flow and user can go through the previously done flow again
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6546965_1721374708001.bandicam_2024-07-19_10-33-52-805.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @c3024The text was updated successfully, but these errors were encountered: