Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-05] Payment issue for E/App PR#41962 #44874

Closed
melvin-bot bot opened this issue Jul 4, 2024 · 24 comments
Closed

[HOLD for payment 2024-08-05] Payment issue for E/App PR#41962 #44874

melvin-bot bot opened this issue Jul 4, 2024 · 24 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Jul 4, 2024

Issue created to compensate the Contributor+ member for their work on #41962
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @ishpaul777.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Jul 4, 2024
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Jul 4, 2024
Copy link
Author

melvin-bot bot commented Jul 4, 2024

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 4, 2024
Copy link
Author

melvin-bot bot commented Jul 8, 2024

@puneetlath, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@puneetlath
Copy link
Contributor

Hasn't been deployed to prod yet.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Overdue Daily KSv2 labels Jul 8, 2024
@puneetlath puneetlath changed the title Payment issue for E/App PR#41962 [HOLD for payment 2024-07-17] Payment issue for E/App PR#41962 Jul 12, 2024
@ishpaul777
Copy link
Contributor

Can we please bump the price up here? The PR was a large enough and required extensive testing. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jul 15, 2024
Copy link
Author

melvin-bot bot commented Jul 15, 2024

@puneetlath, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@puneetlath
Copy link
Contributor

Discussed on Slack. $1k is fair here given the scope/scale of the PR.

@melvin-bot melvin-bot bot removed the Overdue label Jul 16, 2024
@puneetlath
Copy link
Contributor

@ishpaul777 do we need new regression tests here?

@ishpaul777
Copy link
Contributor

ishpaul777 commented Jul 16, 2024

I dont think we need new test cases, there was no change in functionality for user but major changes on how we handle comment linking code wise.

@ishpaul777
Copy link
Contributor

ishpaul777 commented Jul 16, 2024

@puneetlath Please hold my payment until 7/22 i'll bump once i am ready to accept payment, we can move this to weekly for now

@puneetlath puneetlath changed the title [HOLD for payment 2024-07-17] Payment issue for E/App PR#41962 [HOLD for payment 2024-07-22] Payment issue for E/App PR#41962 Jul 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 18, 2024
@ishpaul777
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2024
@puneetlath puneetlath added Weekly KSv2 and removed Daily KSv2 labels Jul 18, 2024
Copy link
Author

melvin-bot bot commented Jul 22, 2024

Payment Summary

Upwork Job

BugZero Checklist (@puneetlath)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@ishpaul777
Copy link
Contributor

Sadly i'd still have to keep my payment on hold (Expected End of this month) i'll ping once i am ready to accept. Thanks for you patience.

@puneetlath puneetlath changed the title [HOLD for payment 2024-07-22] Payment issue for E/App PR#41962 [HOLD for payment 2024-07-31] Payment issue for E/App PR#41962 Jul 24, 2024
Copy link
Author

melvin-bot bot commented Jul 31, 2024

Payment Summary

Upwork Job

BugZero Checklist (@puneetlath)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Aug 1, 2024
@ishpaul777
Copy link
Contributor

not overdue i haven't heard back from the concerning GST authority till now, will only wait till Monday then collect the payments.

Screenshot 2024-08-02 at 2 19 32 PM

@melvin-bot melvin-bot bot removed the Overdue label Aug 2, 2024
@puneetlath puneetlath changed the title [HOLD for payment 2024-07-31] Payment issue for E/App PR#41962 [HOLD for payment 2024-08-05] Payment issue for E/App PR#41962 Aug 2, 2024
Copy link
Author

melvin-bot bot commented Aug 5, 2024

Payment Summary

Upwork Job

BugZero Checklist (@puneetlath)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@puneetlath
Copy link
Contributor

@ishpaul777 can I go ahead and pay this?

@melvin-bot melvin-bot bot added the Overdue label Aug 13, 2024
@ishpaul777
Copy link
Contributor

yes we can go ahead with payment now Thanks for holding payment 🙇

@melvin-bot melvin-bot bot removed the Overdue label Aug 14, 2024
@puneetlath
Copy link
Contributor

@ishpaul777 is this contract the one for this issue? If so, it looks like it was already paid: https://www.upwork.com/nx/wm/workroom/38010569/overview

@ishpaul777
Copy link
Contributor

It was for a different PR #45313 (comment)

@ishpaul777
Copy link
Contributor

issue- #45553

@puneetlath
Copy link
Contributor

Ok got it. Send you an offer: https://www.upwork.com/nx/wm/offer/103524448.

Ping me here once you've accepted.

@ishpaul777
Copy link
Contributor

ishpaul777 commented Aug 14, 2024

We agreed this for $1k #44874 (comment) :)

@puneetlath
Copy link
Contributor

Thanks for reminding me. Paid out $1k.

@ishpaul777
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants