Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD 2024-09-25] [$125] Report fields - Not here page appears briefly after deleting the list value #44815

Closed
2 of 6 tasks
izarutskaya opened this issue Jul 4, 2024 · 67 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@izarutskaya
Copy link

izarutskaya commented Jul 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.4-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Found when validating PR : #44275
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Report fields.
  3. Tap Add field.
  4. Tap Type > Select List.
  5. Tap List values.
  6. Tap Add value.
  7. Add a value and save it.
  8. Tap on the added value.
  9. Delete it.

Expected Result:

Not here page will not appear after deleting the list value.

Actual Result:

Not here page appears (it slides away quickly) after deleting the list value.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6532660_1720061216657.RPReplay_Final1720060958.mp4

Bug6532660_1720061216644!IMG_C83C24EE03F1-1

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @shubham1206agra
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010d8fadf7c03f3196
  • Upwork Job ID: 1814752832262695876
  • Last Price Increase: 2024-08-24
  • Automatic offers:
    • shubham1206agra | Reviewer | 103199939
    • nkdengineer | Contributor | 103694254
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 4, 2024
Copy link

melvin-bot bot commented Jul 4, 2024

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jul 4, 2024

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

github-actions bot commented Jul 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@danieldoglas danieldoglas added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Jul 4, 2024
@danieldoglas
Copy link
Contributor

This is not a deploy blocker because the feature is under beta. @mountiny do you wanna assign this one for yourself?

@mountiny mountiny assigned mountiny and unassigned danieldoglas Jul 4, 2024
@mountiny
Copy link
Contributor

mountiny commented Jul 4, 2024

I am managing this project so going to take over this issue to make sure it gets fixed. Thanks for helping!

@melvin-bot melvin-bot bot added the Overdue label Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

@puneetlath, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mountiny
Copy link
Contributor

mountiny commented Jul 8, 2024

@rezkiy37 @waterim who can take this one on?

@melvin-bot melvin-bot bot removed the Overdue label Jul 8, 2024
@waterim
Copy link
Contributor

waterim commented Jul 8, 2024

This one was fixed in delete as I remeber, will test tomorrow

@mountiny mountiny added the Reviewing Has a PR in review label Jul 8, 2024
@mountiny
Copy link
Contributor

mountiny commented Jul 8, 2024

Nice, added reviewing label but can you also please test and link the pr to this issue and add the test steps there? Thanks!

@mountiny
Copy link
Contributor

@shubham1206agra Do you agree with the proposal from @nkdengineer ?

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2024
Copy link

melvin-bot bot commented Aug 24, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Aug 24, 2024
@rezkiy37
Copy link
Contributor

@shubham1206agra bump.

@shubham1206agra
Copy link
Contributor

Lets go with @nkdengineer's proposal

🎀👀🎀 C+ reviewed

@melvin-bot melvin-bot bot removed the Overdue label Aug 26, 2024
Copy link

melvin-bot bot commented Aug 26, 2024

Current assignees @puneetlath and @mountiny are eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 26, 2024
@mountiny
Copy link
Contributor

Thanks for confirming

Copy link

melvin-bot bot commented Aug 27, 2024

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 27, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 19, 2024
Copy link

melvin-bot bot commented Sep 19, 2024

This issue has not been updated in over 15 days. @puneetlath, @rushatgabhane, @mountiny, @shubham1206agra, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@puneetlath
Copy link
Contributor

What's the status of this?

@mountiny mountiny added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review Monthly KSv2 labels Sep 21, 2024
@mountiny mountiny changed the title [$125] Report fields - Not here page appears briefly after deleting the list value [HOLD 2024-09-25] [$125] Report fields - Not here page appears briefly after deleting the list value Sep 21, 2024
@mountiny
Copy link
Contributor

@puneetlath the automstion failed, tjis is ready for payment, updated the issue

$125 to both @nkdengineer and @shubham1206agra

@puneetlath
Copy link
Contributor

@nkdengineer has been paid.

@shubham1206agra offer here: https://www.upwork.com/nx/wm/offer/104071274. Please ping me when you've accepted.

@shubham1206agra
Copy link
Contributor

@puneetlath Accepted offer

@puneetlath
Copy link
Contributor

All paid. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Development

No branches or pull requests