[HOLD for payment 2024-07-25] [$250] Pay someone - Paid system message is not highlighted when clicking on the message link #44588

lanitochka17 · 2024-06-28T01:13:14Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0-3.1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #43742

Action Performed:

Go to staging.new.expensify.com/
Go to FAB > Pay someone
Enter amount, select a user and pay them
Go to transaction thrad
Right click on the paid system message > Copy link
Paste the link in the transaction thread
Tap on the link

Expected Result:

The paid system message will be highlighted

Actual Result:

The paid system message is highlighted only briefly. The report loads briefly with skeleton and the message is no longer highlighted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6526869_1719532851665.20240628_075834.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0166f7822923f5e0f7
Upwork Job ID: 1806505240961845071
Last Price Increase: 2024-06-28
Automatic offers:

hungvu193 | Reviewer | 102950113
bernhardoj | Contributor | 102950114

Issue Owner

Current Issue Owner: @twisterdotcom

melvin-bot · 2024-06-28T01:13:23Z

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot · 2024-06-28T01:14:29Z

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions · 2024-06-28T01:14:34Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

lanitochka17 · 2024-06-28T01:14:44Z

@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

melvin-bot · 2024-06-28T01:49:46Z

Current assignee @twisterdotcom is eligible for the Bug assigner, not assigning anyone new.

melvin-bot · 2024-06-28T01:49:48Z

Job added to Upwork: https://www.upwork.com/jobs/~0166f7822923f5e0f7

melvin-bot · 2024-06-28T01:49:53Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

nkdengineer · 2024-06-28T05:14:17Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The paid system message is highlighted only briefly. The report loads briefly with skeleton and the message is no longer highlighted

What is the root cause of that problem?

When the iou report is the combine report, we always remove the reportActionID param here.

App/src/pages/home/ReportScreen.tsx

Lines 374 to 379 in 1d607ac

    
           useEffect(() => { 
        
               if (!transactionThreadReportID || !route?.params?.reportActionID) { 
        
                   return; 
        
               } 
        
               Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(route?.params?.reportID)); 
        
           }, [transactionThreadReportID, route?.params?.reportActionID, route?.params?.reportID]);

What changes do you think we should make in order to solve the problem?

We shouldn't remove the reportActionID in the URL if the linked reportActionID is the current action of iou report. We can use linkedAction to check this

useEffect(() => {
    if (!transactionThreadReportID || !route?.params?.reportActionID || (linkedAction?.reportActionID && !ReportActionsUtils.isMoneyRequestAction(linkedAction)) || ReportActionsUtils.isSentMoneyReportAction(linkedAction)) {
            return;
        }
        return;
    }
    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(route?.params?.reportID));
}, [transactionThreadReportID, route?.params?.reportActionID, route?.params?.reportID, linkedAction?.reportActionID]);

App/src/pages/home/ReportScreen.tsx

Lines 374 to 379 in 1d607ac

    
           useEffect(() => { 
        
               if (!transactionThreadReportID || !route?.params?.reportActionID) { 
        
                   return; 
        
               } 
        
               Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(route?.params?.reportID)); 
        
           }, [transactionThreadReportID, route?.params?.reportActionID, route?.params?.reportID]);

What alternative solutions did you explore? (Optional)

bernhardoj · 2024-06-28T05:39:47Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Paid system message is highlighted and immediately not highlighted when linking to the action.

What is the root cause of that problem?

We have an effect that will clear the report action ID from the params if the report is a one-transaction report.

App/src/pages/home/ReportScreen.tsx

Lines 374 to 379 in 1d607ac

    
           useEffect(() => { 
        
               if (!transactionThreadReportID || !route?.params?.reportActionID) { 
        
                   return; 
        
               } 
        
               Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(route?.params?.reportID)); 
        
           }, [transactionThreadReportID, route?.params?.reportActionID, route?.params?.reportID]);

This is to fix #40157. Basically, we don't allow users to link to the one-transaction report money request action, including the paid money action. But the paid money action is recently updated to always be shown in this PR, however, this issue isn't limited to paid money action, but to all actions in the report.

What changes do you think we should make in order to solve the problem?

We need to update the effect logic to be stricter, so it only applies to money request action (except paid/sent) in a one-transaction report.

App/src/pages/home/ReportScreen.tsx

Lines 374 to 379 in 1d607ac

    
           useEffect(() => { 
        
               if (!transactionThreadReportID || !route?.params?.reportActionID) { 
        
                   return; 
        
               } 
        
               Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(route?.params?.reportID)); 
        
           }, [transactionThreadReportID, route?.params?.reportActionID, route?.params?.reportID]);

useEffect(() => {
    if (!transactionThreadReportID || !route?.params?.reportActionID || ReportActionsUtils.isSentMoneyReportAction(linkedAction) || !ReportActionsUtils.isMoneyRequestAction(linkedAction)) {
        return;
    }
    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(route?.params?.reportID));
}, [transactionThreadReportID, route?.params?.reportActionID, route?.params?.reportID]);

If the linked action is sent money action or if the linked action is not a money request action, we do nothing.

hungvu193 · 2024-06-28T09:28:27Z

Reviewing shortly

nkdengineer · 2024-07-02T07:50:21Z

@hungvu193 After the update here #44588 (comment), my proposal will not cause this bug again.

bernhardoj · 2024-07-02T08:29:33Z

Open the PR but still in draft. Left a comment in the PR.

cc: @hungvu193

hungvu193 · 2024-07-03T08:25:30Z

@hungvu193 After the update here #44588 (comment), my proposal will not cause this bug again.

@nkdengineer I'm not saying your updated proposal doesn't work, I don't think we need to accept comment linking for all actions of the IOU report as it's more of feature request.

====================================

Open the PR but still in draft. Left a comment in the PR.

cc: @hungvu193

@bernhardoj I replied in the PR.

melvin-bot · 2024-07-08T18:28:02Z

@twisterdotcom, @hungvu193, @marcaaron, @bernhardoj Huh... This is 4 days overdue. Who can take care of this?

hungvu193 · 2024-07-09T00:09:08Z

PR is under review

hungvu193 · 2024-07-10T16:29:19Z

Same

melvin-bot · 2024-07-18T13:35:50Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-07-18T13:35:55Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.8-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix paid system message is not highlighted when clicking on the message link #44719

If no regressions arise, payment will be issued on 2024-07-25. 🎊

For reference, here are some details about the assignees on this issue:

@hungvu193 requires payment automatic offer (Reviewer)
@bernhardoj requires payment through NewDot Manual Requests (Contributor)

melvin-bot · 2024-07-18T13:35:56Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
[@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hungvu193] Determine if we should create a regression test for this bug.
[@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

bernhardoj · 2024-07-18T13:55:02Z

I'll request in ND once payment is due.

hungvu193 · 2024-07-24T15:40:52Z

The PR that introduced the bug has been identified. Link to the PR: [CP Staging] fix: Blank page after returning to IOU report from thread and deleting the other request #40157
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40157/files#r1690036809
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: Yes

Regression Test:

Go to any report and submit an expense.
Enter amount, select a user and pay them.
Click on that expense to open the thread.
Right click on the paid system message > Copy link.
Paste the link in the transaction thread.
Click on that link.
Verify that the paid system message is highlighted.

Do we 👍 or 👎 ?

marcaaron · 2024-07-24T19:25:56Z

LGTM

twisterdotcom · 2024-07-24T23:40:25Z

Payment Summary:

@hungvu193 paid $250 here (Reviewer)
@bernhardoj paid $250 via NewDot Manual Request (Contributor)

bernhardoj · 2024-07-25T03:05:25Z

Requested in ND.

JmillsExpensify · 2024-07-26T00:43:07Z

$250 approved for @bernhardoj

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 28, 2024

melvin-bot bot assigned twisterdotcom Jun 28, 2024

lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API and removed Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 28, 2024

melvin-bot bot assigned marcaaron Jun 28, 2024

github-actions bot added Engineering Hourly KSv2 labels Jun 28, 2024

github-actions bot mentioned this issue Jun 28, 2024

Deploy Checklist: New Expensify 2024-06-27 #44575

Closed

85 tasks

melvin-bot bot changed the title ~~Pay someone - Paid system message is not highlighted when clicking on the message link~~ [$250] Pay someone - Paid system message is not highlighted when clicking on the message link Jun 28, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 28, 2024

melvin-bot bot assigned hungvu193 Jun 28, 2024

bernhardoj mentioned this issue Jul 2, 2024

Fix paid system message is not highlighted when clicking on the message link #44719

Merged

50 tasks

melvin-bot bot added the Overdue label Jul 8, 2024

melvin-bot bot removed the Overdue label Jul 9, 2024

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 11, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 18, 2024

melvin-bot bot changed the title ~~[$250] Pay someone - Paid system message is not highlighted when clicking on the message link~~ [HOLD for payment 2024-07-25] [$250] Pay someone - Paid system message is not highlighted when clicking on the message link Jul 18, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Jul 18, 2024

hungvu193 mentioned this issue Jul 24, 2024

[CP Staging] fix: Blank page after returning to IOU report from thread and deleting the other request #40157

Merged

50 tasks

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 24, 2024

twisterdotcom closed this as completed Jul 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-07-25] [$250] Pay someone - Paid system message is not highlighted when clicking on the message link #44588

[HOLD for payment 2024-07-25] [$250] Pay someone - Paid system message is not highlighted when clicking on the message link #44588

lanitochka17 commented Jun 28, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 28, 2024

melvin-bot bot commented Jun 28, 2024

github-actions bot commented Jun 28, 2024

lanitochka17 commented Jun 28, 2024

melvin-bot bot commented Jun 28, 2024

melvin-bot bot commented Jun 28, 2024

melvin-bot bot commented Jun 28, 2024

nkdengineer commented Jun 28, 2024 •

edited

Loading

bernhardoj commented Jun 28, 2024

hungvu193 commented Jun 28, 2024

nkdengineer commented Jul 2, 2024

bernhardoj commented Jul 2, 2024

hungvu193 commented Jul 3, 2024

melvin-bot bot commented Jul 8, 2024

hungvu193 commented Jul 9, 2024

hungvu193 commented Jul 10, 2024

melvin-bot bot commented Jul 18, 2024

melvin-bot bot commented Jul 18, 2024 •

edited by twisterdotcom

Loading

melvin-bot bot commented Jul 18, 2024

bernhardoj commented Jul 18, 2024

hungvu193 commented Jul 24, 2024

marcaaron commented Jul 24, 2024

twisterdotcom commented Jul 24, 2024

bernhardoj commented Jul 25, 2024

JmillsExpensify commented Jul 26, 2024

[HOLD for payment 2024-07-25] [$250] Pay someone - Paid system message is not highlighted when clicking on the message link #44588

[HOLD for payment 2024-07-25] [$250] Pay someone - Paid system message is not highlighted when clicking on the message link #44588

Comments

lanitochka17 commented Jun 28, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Jun 28, 2024

melvin-bot bot commented Jun 28, 2024

github-actions bot commented Jun 28, 2024

lanitochka17 commented Jun 28, 2024

melvin-bot bot commented Jun 28, 2024

melvin-bot bot commented Jun 28, 2024

melvin-bot bot commented Jun 28, 2024

nkdengineer commented Jun 28, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

bernhardoj commented Jun 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

hungvu193 commented Jun 28, 2024

nkdengineer commented Jul 2, 2024

bernhardoj commented Jul 2, 2024

hungvu193 commented Jul 3, 2024

melvin-bot bot commented Jul 8, 2024

hungvu193 commented Jul 9, 2024

hungvu193 commented Jul 10, 2024

melvin-bot bot commented Jul 18, 2024

melvin-bot bot commented Jul 18, 2024 • edited by twisterdotcom Loading

melvin-bot bot commented Jul 18, 2024

bernhardoj commented Jul 18, 2024

hungvu193 commented Jul 24, 2024

marcaaron commented Jul 24, 2024

twisterdotcom commented Jul 24, 2024

bernhardoj commented Jul 25, 2024

JmillsExpensify commented Jul 26, 2024

lanitochka17 commented Jun 28, 2024 •

edited by melvin-bot bot

Loading

nkdengineer commented Jun 28, 2024 •

edited

Loading

melvin-bot bot commented Jul 18, 2024 •

edited by twisterdotcom

Loading