[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$125] The emoji icons on reactions are not vertically centered

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.2-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719478843564839

Action Performed:

1. Launch the app
2. Open a report with message
3. Long press on the message for context menu or tap on the react emoji

Expected Result:

The reaction emoji are vertically aligned

Actual Result:

Reaction emoji not vertically aligned

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0141d298ca9ea75ee9
• Upwork Job ID: 1806441888985459900
• Last Price Increase: 2024-06-27
• Automatic offers:
• hoangzinh | Reviewer | 102916247
• neonbhai | Contributor | 102916249

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0141d298ca9ea75ee9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

Upwork job price has been updated to $125

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The emoji icons on reactions are not vertically centered

What is the root cause of that problem?

We intentionally offset the emoji's in EmojiReactionBubble for ios to fix #36739.

App/src/components/Reactions/getEmojiReactionBubbleTextOffsetStyle/index.ios.ts

Line 3 in 27a8d0a

return {transform: [{translateY: 2}]};

This change worked as a hack and is not needed anymore. We can remove it.

What changes do you think we should make in order to solve the problem?

We should remove getEmojiReactionBubbleTextOffsetStyle from EmojiReactionBubble styles here:

App/src/components/Reactions/EmojiReactionBubble.tsx

Line 86 in 27a8d0a

<Text style={[styles.emojiReactionBubbleText, StyleUtils.getEmojiReactionBubbleTextStyle(isContextMenu), getEmojiReactionBubbleTextOffsetStyle()]}>{emojiCodes.join('')}</Text>

​

Since we are not using getEmojiReactionBubbleTextOffsetStyle anywhere else we can remove it from the app.

Result

Screen.Recording.2024-06-28.at.5.16.37.AM.mov

[hoangzinh]

@neonbhai's proposal #44571 (comment) looks good to me

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[abzokhattab]

Just curious, do you know why we added the iOS offset in the first place, and why it is not working now?

[neonbhai]

We added the offset to fix #36739 which may have occurred as we changed the default line height for the app. It's not working now since we fixed the line height in #43902

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[abzokhattab]

Thank you! @neonbhai

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: The emoji icons on reactions are not vertically centered #44675

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment automatic offer (Reviewer)
• @neonbhai requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: The emoji icons on reactions are not vertically centered #44675

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment automatic offer (Reviewer)
• @neonbhai requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@hoangzinh, @anmurali, @blimpich, @neonbhai Whoops! This issue is 2 days overdue. Let's get this updated quick!

[anmurali]

@hoangzinh - can you complete the BZ checklist and then I can get y'all paid.

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: Restore default line height to 20 #43902
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/43902/files#r1689610771
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: ⛔ it's a small UI issue

[melvin-bot]

@hoangzinh, @anmurali, @blimpich, @neonbhai Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hoangzinh]

Awaiting on payment

[melvin-bot]

@hoangzinh, @anmurali, @blimpich, @neonbhai Still overdue 6 days?! Let's take care of this!

[muttmuure]

Paid