[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Chat - "as copilot for" is displayed in avatar tooltip

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.8-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat.
3. Send a message.
4. Hover over self avatar.

Expected Result:

The tooltip for self avatar will just display the user name.

Actual Result:

The tooltip for self avatar displays "as copilot for x".

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

20240615_222334.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"as copilot for" is displayed in avatar tooltip

What is the root cause of that problem?

Since now the default value for Onyx is '-1' this statement evaluates to true when delegate is not present.

App/src/components/UserDetailsTooltip/BaseUserDetailsTooltip/index.tsx

Line 34 in 75c104b

if (delegateAccountID) {

What changes do you think we should make in order to solve the problem?

We will add a check for -1 here:

App/src/components/UserDetailsTooltip/BaseUserDetailsTooltip/index.tsx

Line 34 in 75c104b

if (delegateAccountID) {

if (delegateAccountID !== -1) {
    ...
}

[mountiny]

Gonna take over

[mountiny]

Thank you @neonbhai for urgency I raised the pr myself but you would get partial reward for identifying the fix

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Check for -1 default value for delegateAccountID #43817

If no regressions arise, payment will be issued on 2024-06-24. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mountiny] Determine if we should create a regression test for this bug.
• [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

No payment needed here, closing

[neonbhai]

@MitchExpensify hi, I'm eligible for compensation here as noted in #43800 (comment)

[mountiny]

Yeah let's do partial payment of $50 for identifying the fix

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Check for -1 default value for delegateAccountID #43817

If no regressions arise, payment will be issued on 2024-06-28. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mountiny] Determine if we should create a regression test for this bug.
• [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Ah yes, offer sent here: https://www.upwork.com/nx/wm/offer/102848809

[mountiny]

@neonbhai have you confirmed?

I dont think we need a regression test for this

[neonbhai]

Thank you, accepted the offer!

cc: @MitchExpensify @mountiny

[melvin-bot]

@mountiny, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@mountiny, @MitchExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[MitchExpensify]

Paid and contract ended!