-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-07-24] [$250] Track distance - Incorrect distance is displayed on confirmation page when submitting to WS #42959
Comments
Triggered auto assignment to @lschurr ( |
@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
We think this bug might be related to #vip-vsb |
Same here. Unable to reproduce in main. |
Going to close since we are unable to reproduce. |
Issue is still reproducible bandicam.2024-06-05.12-18-25-884.mp4 |
@Tony-MK @kpadmanabhan - Can you try again? |
Job added to Upwork: https://www.upwork.com/jobs/~01cae0e715bb61699d |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan ( |
Would you mind testing and confirming this bug is still happening @situchan? A few others weren't able to reproduce. |
testing... |
ProposalPlease re-state the problem that we are trying to solve in this issue.The distance in the confirmation page is different. It shows a very short distance (0.01 km in my case). What is the root cause of that problem?The But after we create the track distance, back-end returns What changes do you think we should make in order to solve the problem?We should convert the distance to meter value here if we're moving the transaction from track expense by the same as we do here
What alternative solutions did you explore? (Optional) |
To reproduce this bug, we should enable P2P distance beta. |
reviewing proposal |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@dominictb's proposal looks good to me. |
Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@thienlnam @lschurr @situchan @dominictb this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
PR will be ready by a day or two. |
This issue has not been updated in over 15 days. @thienlnam, @lschurr, @situchan, @dominictb eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-24. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment summary:
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.78-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
The distance in the confirmation page will be the same as the distance in the transaction thread because waypoints remain the same.
Actual Result:
The distance in the confirmation page is different. It shows a very short distance (0.01 km in my case).
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6498389_1717234236224.bandicam_2024-06-01_17-20-03-316.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @lschurrThe text was updated successfully, but these errors were encountered: