[HOLD for payment 2024-05-22] Tax - Tax amount does not update to 0.00 immediately when changing tax rate to 0% offline

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #40443
Version Number: 1.4.73-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Internal Applause Team
Slack conversation:

Action Performed:

Precondition:

• Workspace has enabled tax rate.
• Workspace currency default is tax exempt (0%).
• Foreign currency default have different tax rate (non-zero rate).
• There are at least 2 non-zero tax rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit a manual expense in foreign currency.
4. Go offline.
5. Go to transaction thread.
6. Click Tax.
7. Update tax rate to another non-zero rate.
8. Note that tax amount updates immediately.
9. Click Tax.
10. Update tax rate to Tax exempt (0%).

Expected Result:

Tax amount will update to 0.00 immediately when changing tax rate to 0% offline.

Actual Result:

Tax amount does not update to 0.00 immediately when changing tax rate to 0% offline.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6479205_1715597146807.bandicam_2024-05-13_18-42-12-497.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@johncschuster I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think this issue might be related to the #wave-collect - Release 1

[MonilBhavsar]

Looking into this

[MonilBhavsar]

Working on PR

[MonilBhavsar]

Issue fixed on staging

Screen.Recording.2024-05-14.at.5.47.36.PM.mov

[MonilBhavsar]

@DylanDylann needs to be compensated for PR review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix bug when updating tax rate to zero #42065

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@DylanDylann] Determine if we should create a regression test for this bug.
• [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johncschuster]

@DylanDylann, I see in the comment above that you should request payment via NewDot, but I don't see you listed in our internal SO as a contributor that receives payment through ND. Can you clarify how you receive payment?

I've applied the External label preemptively, just to play it safe, in case I need to create an Upwork job. If you're added to the list of folks that can accept payment via ND when it's time to pay this out, we can go that route instead.

[DylanDylann]

@johncschuster I always receive payment via Upwork

[johncschuster]

Got it! That must have been an automated comment then. Thanks for clarifying that!

I've just invited you to the job, here. Can you accept that? I'll get payment issued on the 22nd.

[johncschuster]

@DylanDylann friendly bump! Can you accept the job when you get a moment? Thanks!

[DylanDylann]

@johncschuster I accepted the offer. Thanks

[johncschuster]

Thanks! I'll issue payment tomorrow 👍 In the meantime, can you complete the BZ Checklist above?

[DylanDylann]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: [NA](#40443
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: #40443 (comment)
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal
Precondition:

Workspace has enabled tax rate.
Workspace currency default is tax exempt (0%).
Foreign currency default have different tax rate (non-zero rate).
There are at least 2 non-zero tax rates.

1. Go to workspace chat.
2. Submit a manual expense in foreign currency.
3. Go offline.
4. Go to transaction thread.
5. Click Tax.
6. Update tax rate to another non-zero rate.
7. Note that tax amount updates immediately.
8. Click Tax.
9. Update tax rate to Tax exempt (0%).
10. Verify tax amount will update to 0.00 immediately when changing tax rate to 0% offline.

Do we agree 👍 or 👎

[johncschuster]

Payment has been issued! 🎉 Thanks for your help!