[HOLD for payment 2024-05-22] Tax - Missing tax amount change in system message and incorrect new tax amount in the message

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.73-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Workspace has enabled tax rate.
• Workspace currency default is tax exempt (0%).
• Foreign currency default have different tax rate (non-zero rate).

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense in local currency.
4. Go to transaction thread.
5. Click Amount and change it to a foreign currency.
6. Note that the system message does not include tax amount change system message.
7. Click Amount.
8. Change it back to local currency.
9. Note that the system message includes tax amount change system message.

Expected Result:

In Step 6, when tax rate changes as a result of switching currency, the system message will include tax amount change, just like Step 9.
In Step 9. the system message will show the new tax amount.

Actual Result:

In Step 6, when tax rate changes as a result of switching currency from local to foreign currency, the system message does not include tax amount change.
It only shows when changing currency from foreign to local currency (Step 9).
In Step 9, the system message shows the old tax amount.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6479174_1715595254408.tax_amoun.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@sakluger I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

Recording.2446.mp4

[Julesssss]

This seems the most likely candidate IMO. If confirmed we'll seek a quick PR or revert to unblock the deploy. It's a huge PR so a fix would be preferred.

@madmax330 I haven't seen this new process where web and mobile deployers are assigned. I assume you'll remain assigned and won't remove the blocker label until it is confirmed to be front end?

[MonilBhavsar]

Found the issue. Working on a fix.
We have previously discussed that we won't be displaying a system message for an indirect change.
In this case, taxAmount changes as expense amount is updated. We won't display a system message for tax amount update, and only display system message for amount/currency change.

I also confirmed this is optimistic by signing out and signing in and confirming the system message is no longer displayed.

[MonilBhavsar]

PR is ready for review

[Julesssss]

Merged, about to CP

[Julesssss]

Fix was just CP'd to staging. Checking it off the checklist.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix system message when tax amount is updated #42051

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sakluger]

@johncschuster could you please help with payment while I'm OOO?

@Julesssss does this issue require payment, and if so, how much? It looks like it may be a regression, and in that case I think no payment would be due.

[Julesssss]

Monil submitted the PR so no payment is necessary for that. But @rushatgabhane was a C+ reviewer

[johncschuster]

Payment Summary:

Contributor+: @rushatgabhane - $250 via Manual Request

[johncschuster]

@rushatgabhane can you complete the BZ Checklist when you get a moment? Thank you!

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: support for offline tax tracking #40443

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: support for offline tax tracking #40443 (comment)

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. Yes if it doesn't already exists

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

      1. Have tax tracking enabled on a collect workspace.
      2. Have at least two tax rates.
      3. Submit an expense to the workspace with tax rate A.
      4. Update expense amount and ensure tax amount changes and there is no system message for indirect tax amount change
      5. Update currency amount and ensure tax rate and tax amount changes and there is no system message for indirect tax amount or tax rate change
      6. Update tax rate and there is no system message for indirect tax amount change
      7. Update tax amount and ensure tax amount changes and there is system message for tax amount change
   

[johncschuster]

Thank you! 🎉 The payment summary is above, and payment is due tomorrow. Please send your manual request 👍

[JmillsExpensify]

$250 approved for @rushatgabhane