[HOLD for payment 2024-06-06] [$250] Workspace - RBR is aligned to top of WS bar

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.70-1
Reproducible in staging?: y
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition: Sign up new account.

1. Add workspace
2. Go to Workspace > Workflows
3. Enable 'Make or track payments'
4. Add VBA (Regions bank)
5. Go to Workspaces tab

Expected Result:

RBR is aligned to center of WS bar

Actual Result:

RBR is aligned to top of WS bar

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e565fa0b66eb131c
• Upwork Job ID: 1787654855430000640
• Last Price Increase: 2024-05-07
• Automatic offers:
• Krishna2323 | Contributor | 0

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kavimuru]

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - RBR is aligned to top of WS bar

What is the root cause of that problem?

Styles applied to icon container and the main View of ThreeDotMenuOrPendingIcon is incorrect.

App/src/pages/workspace/WorkspacesListRow.tsx

Lines 145 to 158 in 387ab0e

	<View style={[isNarrow && styles.mr5]}>
	{isJoinRequestPending && (
	<View style={[styles.flexRow, styles.gap2, styles.alignItemsCenter, styles.flex1, styles.justifyContentEnd, !isNarrow && styles.pr4, isNarrow && styles.workspaceListBadge]}>
	<Badge
	text={translate('workspace.common.requested')}
	textStyles={styles.textStrong}
	badgeStyles={[styles.alignSelfCenter, styles.badgeBordered]}
	icon={Expensicons.Hourglass}
	/>
	</View>
	)}
	{!isJoinRequestPending && (
	<>
	<View style={[styles.flexRow, styles.flex0, styles.gap2, isNarrow && styles.mr5, styles.alignItemsCenter]}>

What changes do you think we should make in order to solve the problem?

The icon container should not have the styles.flex0 styles and the main View of ThreeDotMenuOrPendingIcon should have the styles.flexRow style applied to it.

Also we need to apply styles to icon container for alignment and spacing for narrow layouts. We can create a style object like we do with isNarrow && styles.workspaceListBadge.

App/src/pages/workspace/WorkspacesListRow.tsx

Line 147 in 387ab0e

<View style={[styles.flexRow, styles.gap2, styles.alignItemsCenter, styles.flex1, styles.justifyContentEnd, !isNarrow && styles.pr4, isNarrow && styles.workspaceListBadge]}>

App/src/pages/workspace/WorkspacesListRow.tsx

Line 158 in 387ab0e

<View style={[styles.flexRow, styles.flex0, styles.gap2, isNarrow && styles.mr5, styles.alignItemsCenter]}>

isNarrow && {flexDirection: 'column', justifyContent: 'flex-start', marginLeft: 16, marginTop: 10},

What alternative solutions did you explore? (Optional)

Result

rbr_alignment_workspace_list_row.mp4

[Krishna2323]

Proposal Updated

• Updated main solution to make the stylings work in narrow layouts also

[Krishna2323]

Proposal Updated

• Added result video

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e565fa0b66eb131c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

@isabelastisser Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Isaac017]

Here's a proposal for the Expensify project:

Title: Unifying Front-end with React Native Migration

Proposal:

I understand that Expensify is seeking to unify its front-end across platforms using React Native. The GitHub issue outlines the requirements for this migration. My proposal focuses on addressing the key challenges and providing a technical explanation of the changes I will make.

Objectives:

1. Migrate the existing front-end to React Native, ensuring a seamless user experience across platforms.
2. Implement a consistent design language and component library.
3. Ensure compatibility with existing APIs and backend infrastructure.
4. Conduct thorough testing on multiple platforms (iOS, Android, and Web).

Technical Approach:

1. Set up a new React Native project, integrating it with the existing Expensify codebase.
2. Develop a custom component library, utilizing React Native elements and Expensify's design guidelines.
3. Implement platform-specific optimizations for performance and user experience.
4. Utilize React Native's built-in navigation and routing features for a cohesive user flow.
5. Conduct thorough testing, including unit tests, integration tests, and UI tests.

Deliverables:

1. A detailed report outlining the migration process and technical decisions.
2. A fork of the Expensify/App repository with the implemented changes.
3. A pull request for merging the changes into the main codebase.
4. Screenshots and confirmation of successful testing on all platforms.

Timeline:

1. Initial setup and planning: 2 days
2. Component library development: 5 days
3. Platform-specific optimizations: 3 days
4. Testing and debugging: 5 days
5. Documentation and reporting: 2 days

Total estimated time: 17 days

Please review my proposal, and if accepted, I will post it on Upwork and begin working on the project. I will then submit the code for review and merge into the Expensify codebase.

[melvin-bot]

📣 @Isaac017! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Isaac017]

Contributor details
Your Expensify account email: isaacochagwu001@gmail.com
Upwork Profile Link: <Contributor details Your Expensify account email: https://www.upwork.com/freelancers/~01ecb4ea889e2c3a93
Here's a proposal for the Expensify project:

Title: Unifying Front-end with React Native Migration

Proposal:

I understand that Expensify is seeking to unify its front-end across platforms using React Native. The GitHub issue outlines the requirements for this migration. My proposal focuses on addressing the key challenges and providing a technical explanation of the changes I will make.

Objectives:

1. Migrate the existing front-end to React Native, ensuring a seamless user experience across platforms.
2. Implement a consistent design language and component library.
3. Ensure compatibility with existing APIs and backend infrastructure.
4. Conduct thorough testing on multiple platforms (iOS, Android, and Web).

Technical Approach:

1. Set up a new React Native project, integrating it with the existing Expensify codebase.
2. Develop a custom component library, utilizing React Native elements and Expensify's design guidelines.
3. Implement platform-specific optimizations for performance and user experience.
4. Utilize React Native's built-in navigation and routing features for a cohesive user flow.
5. Conduct thorough testing, including unit tests, integration tests, and UI tests.

Deliverables:

1. A detailed report outlining the migration process and technical decisions.
2. A fork of the Expensify/App repository with the implemented changes.
3. A pull request for merging the changes into the main codebase.
4. Screenshots and confirmation of successful testing on all platforms.

Timeline:

1. Initial setup and planning: 2 days
2. Component library development: 5 days
3. Platform-specific optimizations: 3 days
4. Testing and debugging: 5 days
5. Documentation and reporting: 2 days

Total estimated time: 17 days

Please review my proposal, and if accepted, I will post it on Upwork and begin working on the project. I will then submit the code for review and merge into the Expensify codebase.

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[Isaac017]

Contributor  isaacochagwu001@expensify.com

 https://www.upwork.com/freelancers/~01ecb4ea889e2c3a93
Here's a proposal for the Expensify project:

Title: Unifying Front-end with React Native Migration

Proposal:

I understand that Expensify is seeking to unify its front-end across platforms using React Native. The GitHub issue outlines the requirements for this migration. My proposal focuses on addressing the key challenges and providing a technical explanation of the changes I will make.

Objectives:

Migrate the existing front-end to React Native, ensuring a seamless user experience across platforms.

Implement a consistent design language and component library.

Ensure compatibility with existing APIs and backend infrastructure.

Conduct thorough testing on multiple platforms (iOS, Android, and Web).

Technical Approach:

Set up a new React Native project, integrating it with the existing Expensify codebase.

Develop a custom component library, utilizing React Native elements and Expensify's design guidelines.

Implement platform-specific optimizations for performance and user experience.

Utilize React Native's built-in navigation and routing features for a cohesive user flow.

Conduct thorough testing, including unit tests, integration tests, and UI tests.

Deliverables:

A detailed report outlining the migration process and technical decisions.

A fork of the Expensify/App repository with the implemented changes.

A pull request for merging the changes into the main codebase.

Screenshots and confirmation of successful testing on all platforms.

Timeline:

Initial setup and planning: 2 days

Component library development: 5 days

Platform-specific optimizations: 3 days

Testing and debugging: 5 days

Documentation and reporting: 2 days

Total estimated time: 17 days

Please review my proposal, and if accepted, I will post it on Upwork and begin working on the project. I will then submit the code for review and merge into the Expensify codebase.

[isabelastisser]

@thesahindia, can you please provide an update? Thanks!

[thesahindia]

@Krishna2323's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[isabelastisser]

@MonilBhavsar, please review the proposals. Thanks!

[MonilBhavsar]

Looks good to me

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@thesahindia, PR ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Workspace - RBR is aligned to top of WS bar. #42017

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

• @thesahindia requires payment through NewDot Manual Requests
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[isabelastisser]

@thesahindia, please complete the checklist before payment is due. Thanks!

[thesahindia]

It was caused by #40069. I have commented on the PR. We should have tested for the error case in that PR.

I don't think we need a test case here.

[isabelastisser]

Payment summary:

@thesahindia requires payment through NewDot Manual Requests - C+ review $250 PENDING
@Krishna2323 requires payment automatic offer (Contributor) $250

[isabelastisser]

All set!

[JmillsExpensify]

$250 approved for @thesahindia