Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2024-05-02] [Guided Setup] Implement the Stage 1 onboarding flow #39969

Closed
mountiny opened this issue Apr 9, 2024 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@mountiny
Copy link
Contributor

mountiny commented Apr 9, 2024

Implementation issue for the Onboarding Stage 1 project

The design doc is here https://docs.google.com/document/d/1sxG_RV5HTFHgdCsJUDNpqSGs09W_OPLBKbNYQfu3FHw/edit. For more details on the implementation, please read the detailed section of the document.

image

This is implemented by SWM.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dbadd33848f9de2a
  • Upwork Job ID: 1786398252777099264
  • Last Price Increase: 2024-05-03
Issue OwnerCurrent Issue Owner: @
@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 9, 2024
@mountiny mountiny added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 9, 2024
Copy link

melvin-bot bot commented Apr 9, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 9, 2024

Triggered auto assignment to @johncschuster (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 9, 2024
@mountiny mountiny assigned hoangzinh and unassigned johncschuster Apr 9, 2024
@kadiealexander kadiealexander removed their assignment Apr 11, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Apr 15, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 23, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 25, 2024
@melvin-bot melvin-bot bot changed the title Implement the Stage 1 onboarding flow [HOLD for payment 2024-05-02] Implement the Stage 1 onboarding flow Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

  • @hoangzinh requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Apr 25, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 1, 2024
@trjExpensify trjExpensify changed the title [HOLD for payment 2024-05-02] Implement the Stage 1 onboarding flow [HOLD for payment 2024-05-02] [Guided Setup] Implement the Stage 1 onboarding flow May 2, 2024
Copy link

melvin-bot bot commented May 2, 2024

Issue is ready for payment but no BZ is assigned. @joekaufmanexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented May 2, 2024

Payment Summary

Upwork Job

  • ROLE: @hoangzinh paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@joekaufmanexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@joekaufmanexpensify
Copy link
Contributor

@mountiny @francoisl @hoangzinh I see this comment, was there a regression from this issue?

@hoangzinh
Copy link
Contributor

Based on this comment #40907 (comment), I think it's a false alarm.

@joekaufmanexpensify
Copy link
Contributor

Got it, thanks for confirming! In that case, only payment needed here is $250 to @hoangzinh for C+ review via upwork.

@joekaufmanexpensify joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label May 3, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-05-02] [Guided Setup] Implement the Stage 1 onboarding flow [$250] [HOLD for payment 2024-05-02] [Guided Setup] Implement the Stage 1 onboarding flow May 3, 2024
Copy link

melvin-bot bot commented May 3, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01dbadd33848f9de2a

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 3, 2024
Copy link

melvin-bot bot commented May 3, 2024

Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new.

@joekaufmanexpensify joekaufmanexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 3, 2024
@joekaufmanexpensify
Copy link
Contributor

@hoangzinh offer for $250 sent!

@joekaufmanexpensify
Copy link
Contributor

For regression test, I don't think we need to add that here piecemeal. I see a whole suite of manual tests in the design doc for us to pass to applause.

@hoangzinh
Copy link
Contributor

Accepted. Thanks @joekaufmanexpensify

@joekaufmanexpensify
Copy link
Contributor

@hoangzinh $250 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

Upwork job closed.

@joekaufmanexpensify
Copy link
Contributor

All set, thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

6 participants