[HOLD for payment 2024-03-29] [$500] LHN - Empty space displayed in LHN after opening IOU detail page offline #38670

izarutskaya · 2024-03-20T12:59:48Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.55-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Go to https://staging.new.expensify.com/
Go offline
Click on FAB and create a new group chat
In the group chat click on "+" > Spilt bill
Create a manual request and split it with one user of the group
Navigate to the chat with the user you split the bill
Open the money request detail page

Expected Result:

No space between reports is displayed in LHN

Actual Result:

Empty space displayed in LHN after opening the IOU detail page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6420027_1710902736738.Recording__314.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0162cd9a8930d9526d
Upwork Job ID: 1773726162377322496
Last Price Increase: 2024-03-29

melvin-bot · 2024-03-20T13:00:01Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

github-actions · 2024-03-20T13:00:06Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2024-03-20T13:00:16Z

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

izarutskaya · 2024-03-20T13:01:36Z

@joekaufmanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

izarutskaya · 2024-03-20T13:02:19Z

Production

Recording.2284.mp4

joekaufmanexpensify · 2024-03-20T16:33:57Z

@youssef-lr do you think this needs to be a deploy blocker? I am not personally convinced. It's pretty niche behavior.

aimane-chnaif · 2024-03-20T16:35:38Z

This seems to be dupe of #37497. Not sure why it's marked as not reproducible in production.

youssef-lr · 2024-03-20T19:54:43Z

Testing on staging & production now

youssef-lr · 2024-03-20T19:58:33Z

@aimane-chnaif I don't think this is the same issue, I can only reproduce in staging.

youssef-lr · 2024-03-20T19:58:43Z

Going to try to find the offending PR now

youssef-lr · 2024-03-20T20:09:27Z

This is a regression from this PR, after reverting it locally I can't reproduce anymore. cc @jbroma @allroundexperts @mountiny

The steps to reproduce is to create a split offline, navigate a 1on1 money report, then navigate to the transaction thread. An empty LHN row will be displayed.

youssef-lr · 2024-03-20T20:28:01Z

This is also reproducible online, but the empty row disappears quickly

Screen.Recording.2024-03-20.at.20.27.35.mov

youssef-lr · 2024-03-20T20:37:24Z

I found out why this is happening here, I'm gonna open this up to contributors so we can hopefully find a fix

melvin-bot · 2024-03-20T20:37:33Z

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

melvin-bot · 2024-03-20T20:37:38Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

melvin-bot · 2024-03-20T20:37:47Z

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

situchan · 2024-03-24T14:28:50Z

The PR that introduced the bug has been identified. Link to the PR: perf: improve chat switch performance - fixed #38255
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/38255/files#r1532802697
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A This came from big refactor and this kind of bug couldn't be easily caught.
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Go offline
Click on FAB and create a new group chat
In the group chat click on "+" > Spilt bill
Create a manual request and split it with one user of the group
Navigate to the chat with the user you split the bill
Open the money request detail page
Verify that no space between reports is displayed in LHN

joekaufmanexpensify · 2024-03-25T14:21:39Z

Great. TY!

joekaufmanexpensify · 2024-03-29T12:48:18Z

Due today!

joekaufmanexpensify · 2024-03-29T14:50:27Z

This is a pretty niche bug and IMO does not need a regression test.

joekaufmanexpensify · 2024-03-29T14:57:06Z

Only payment needed here is $500 to @situchan for C+. Paid via upwork.

joekaufmanexpensify · 2024-03-29T14:57:16Z

Adding external to create upwork job

melvin-bot · 2024-03-29T14:57:28Z

Job added to Upwork: https://www.upwork.com/jobs/~0162cd9a8930d9526d

melvin-bot · 2024-03-29T14:57:32Z

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

joekaufmanexpensify · 2024-03-29T14:59:09Z

@situchan offer for $500 sent!

fedirjh · 2024-03-29T16:25:19Z

cc @joekaufmanexpensify I think I am eligible for payment, as the solution that I proposed was implemented.

joekaufmanexpensify · 2024-03-29T16:26:45Z

Defer to @youssef-lr on that. Mind weighing in on whether this proposal was what was used?

joekaufmanexpensify · 2024-04-01T14:56:56Z

Bumped 1:1

youssef-lr · 2024-04-01T19:01:09Z

@joekaufmanexpensify yes I did use Fedi's solution!

joekaufmanexpensify · 2024-04-01T20:10:28Z

Discussing internally

joekaufmanexpensify · 2024-04-01T20:11:37Z

@situchan $500 sent and contract ended!

joekaufmanexpensify · 2024-04-01T20:36:24Z

@fedirjh we landed on 50% comp here since we used your proposal, but you did not raise a PR

joekaufmanexpensify · 2024-04-01T20:37:12Z

@fedirjh offer sent for $250!

joekaufmanexpensify · 2024-04-01T20:42:30Z

@fedirjh $250 sent and contract ended!

joekaufmanexpensify · 2024-04-01T20:42:51Z

Upwork job closed.

joekaufmanexpensify · 2024-04-01T20:42:56Z

All set. Thanks everyone!

izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 20, 2024

melvin-bot bot assigned joekaufmanexpensify Mar 20, 2024

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 20, 2024

melvin-bot bot assigned youssef-lr Mar 20, 2024

github-actions bot mentioned this issue Mar 20, 2024

Deploy Checklist: New Expensify 2024-03-19 #38651

Closed

66 tasks

melvin-bot bot mentioned this issue Mar 20, 2024

[HOLD for payment 2024-03-29] [Performance] Chat Switch Improvement Part 1 #32793

Closed

youssef-lr added the External Added to denote the issue can be worked on by a contributor label Mar 20, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 20, 2024

melvin-bot bot assigned alitoshmatov Mar 20, 2024

youssef-lr changed the title ~~LHN - Empty space displayed in LHN after opening IOU detail page offline~~ [$500] LHN - Empty space displayed in LHN after opening IOU detail page offline Mar 20, 2024

joekaufmanexpensify added Daily KSv2 and removed Weekly KSv2 labels Mar 29, 2024

joekaufmanexpensify added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Mar 29, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 29, 2024

joekaufmanexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 29, 2024

melvin-bot bot added the Overdue label Apr 1, 2024

melvin-bot bot removed the Overdue label Apr 1, 2024

joekaufmanexpensify closed this as completed Apr 1, 2024

johncschuster mentioned this issue May 22, 2024

[$500] Android - An extra space is created at the top of the chat list when pinning and unpinning #37497

Closed

6 tasks

[HOLD for payment 2024-03-29] [$500] LHN - Empty space displayed in LHN after opening IOU detail page offline #38670

[HOLD for payment 2024-03-29] [$500] LHN - Empty space displayed in LHN after opening IOU detail page offline #38670

Comments

izarutskaya commented Mar 20, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

melvin-bot bot commented Mar 20, 2024

izarutskaya commented Mar 20, 2024

izarutskaya commented Mar 20, 2024 • edited Loading

joekaufmanexpensify commented Mar 20, 2024

aimane-chnaif commented Mar 20, 2024

youssef-lr commented Mar 20, 2024

youssef-lr commented Mar 20, 2024

youssef-lr commented Mar 20, 2024

youssef-lr commented Mar 20, 2024 • edited Loading

youssef-lr commented Mar 20, 2024

youssef-lr commented Mar 20, 2024

melvin-bot bot commented Mar 20, 2024

melvin-bot bot commented Mar 20, 2024

melvin-bot bot commented Mar 20, 2024

situchan commented Mar 24, 2024

Regression Test Proposal

joekaufmanexpensify commented Mar 25, 2024

joekaufmanexpensify commented Mar 29, 2024

joekaufmanexpensify commented Mar 29, 2024

joekaufmanexpensify commented Mar 29, 2024

joekaufmanexpensify commented Mar 29, 2024

melvin-bot bot commented Mar 29, 2024

melvin-bot bot commented Mar 29, 2024

joekaufmanexpensify commented Mar 29, 2024

fedirjh commented Mar 29, 2024

joekaufmanexpensify commented Mar 29, 2024

joekaufmanexpensify commented Apr 1, 2024

youssef-lr commented Apr 1, 2024

joekaufmanexpensify commented Apr 1, 2024

joekaufmanexpensify commented Apr 1, 2024

joekaufmanexpensify commented Apr 1, 2024

joekaufmanexpensify commented Apr 1, 2024

joekaufmanexpensify commented Apr 1, 2024

joekaufmanexpensify commented Apr 1, 2024

joekaufmanexpensify commented Apr 1, 2024

izarutskaya commented Mar 20, 2024 •

edited by melvin-bot bot

Loading

izarutskaya commented Mar 20, 2024 •

edited

Loading

youssef-lr commented Mar 20, 2024 •

edited

Loading