[$500] New order of tags do not update after reopening confirmation page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.48-0
Reproducible in staging?: y
Reproducible in production?: New Feature
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

• User is an employee of Collect workspace.
• The Collect workspace has independent multilevel tags.

1. [Employee] Go to workspace chat.
2. {Employee] Go to FAB > Request money > Manual > Enter amount.
3. [Employee] On confirmation page, note the order of multilevel tags.
4. [Admin] On Old Dot, rearrange the order of multilevel tags (do not delete them)
5. [Employee] Without refreshing the page, repeat Step 2 and 3.

Expected Result:

The new order of multilevel tags will update when reopening the confirmation page, as it works (it updates) when changing tag name.

Actual Result:

The new order of multilevel tags does not update when reopening the confirmation page. It only updates after refreshing the page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6404768_1709772124813.bandicam_2024-03-07_08-32-26-892.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0194dd2ee1e3003f2e
• Upwork Job ID: 1768169703946260480
• Last Price Increase: 2024-03-14

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[m-natarajan]

@robertjchen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think that this bug might be related to #wave6-collect-submitters

cc@greg-schroeder

[robertjchen]

Yep, not a deploy blocker per se, but definitely looks like a bug to me. Though, I'm not sure if it's on the backend cc: @greg-schroeder

[luacmartins]

Seems like we're not sending pusher updates for the reordering. Maybe something that https://github.com/Expensify/Auth/pull/9773 will solve

[robertjchen]

That makes sense, let's revisit after that change goes out.

[luacmartins]

Cool, put a hold for that Auth PR - https://github.com/Expensify/Auth/pull/9773

[Christinadobrzyn]

PR is closed https://github.com/Expensify/Auth/pull/9773

Testing the steps in the OP again, I think this might be fixed!

2024-03-13_12-12-16.mp4

Gonna ask QA to test - https://expensify.slack.com/archives/C9YU7BX5M/p1710303354198479

[kavimuru]

@Christinadobrzyn Bug is still reproducible by the tester.

bandicam.2024-03-13.20-49-38-989.mp4

[Christinadobrzyn]

Ah okay, I deleted the tags in my test here, not moved them so that is the difference. I can reproduce the steps in the OP.

I think this might be internal, @luacmartins @robertjchen should this remain be internal?

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0194dd2ee1e3003f2e

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @situchan (Internal)

[robertjchen]

The fix was deployed last week. @m-natarajan could you please help confirm if the issue is still reproducible? 🙏

[Christinadobrzyn]

Asking QA to test too - I think this is resolved - https://expensify.slack.com/archives/C9YU7BX5M/p1711355439541929

[kavimuru]

@Christinadobrzyn issue not reproducible anymore.

20240325_222015.mp4

[robertjchen]

Thanks for helping test, closing this out 👍