[HOLD for payment 2024-03-13] [$500] Video - App returns to previous thread when scrubbing video in thread

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.43-2
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to chat.
3. Send a video.
4. Send a reply to the video in thread.
5. Send a reply to the video reply in Step 3.
6. Play the video in thread.
7. Click on the video player to adjust the playback.

Expected Result:

App will stay in the same thread in Step 5.

Actual Result:

App returns to thread in Step 4.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385635_1708430667893.bandicam_2024-02-20_14-47-28-002.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010e97f0baf89a789a
• Upwork Job ID: 1759959992185339904
• Last Price Increase: 2024-02-20

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010e97f0baf89a789a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[iwiznia]

Posted here https://expensify.slack.com/archives/C01GTK53T8Q/p1708443084946829 we might revert #30829

[kowczarz]

Hey! I will take a look at it.

[puneetlath]

Looks like the PR didn't totally fix it. But I'm removing the deploy blocker label based on discussion here.

[Skalakid]

Hi, I prepared the PR with the fix for this issue, since the previous one was reverted

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix app returns to previous thread when scrubbing video in thread #37270

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests
• @kowczarz does not require payment (Contractor)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @laurenreidexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @sobitneupane owed $500 via NewDot
• Contributor: @kowczarz is from an agency-contributor and not due payment

BugZero Checklist (@laurenreidexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1759959992185339904/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[laurenreidexpensify]

@sobitneupane is there anything in the checklist we need to complete here before closing? thanks

[melvin-bot]

@iwiznia, @sobitneupane, @laurenreidexpensify, @kowczarz Huh... This is 4 days overdue. Who can take care of this?

[sobitneupane]

Will work on the checklist asap.

[sobitneupane]

As the issue was reported by Applause- Internal Team, I am not sure if the regression test is needed.
Regression Test Proposal:

1. Go to chat.
2. Send a video.
3. Send a reply to the video in thread.
4. Send a reply to the video reply in Step 3.
5. Play the video in thread.
6. Click on the video player to adjust the playback.
7. Verify that app still remains in the thread in Step 4.

Do we agree 👍 or 👎

[sobitneupane]

The Video Player feature was added by #30829 PR, which likely overlooked this particular case. Since it's an edge case that can only be reproduced by replying to a reply in a video message, it could have been easily missed.

[sobitneupane]

Requested payment in newDot.

Payment Summary: #36906 (comment)

[JmillsExpensify]

$500 approved for @sobitneupane based on summary.