[HOLD for payment 2024-03-11] [HOLD for #36401] [$500] Reimburse - Pressing 'Enter' key on 'Rate' page refreshes the page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.41-2
Reproducible in staging?: y
Reproducible in production?: n (new feature)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Open workspace settings page
2. Click on 'Reimbursements'
3. Click on 'Rate'
4. Click on 'Rate' again
5. Modify the rate > press 'Enter' key

Expected Result:

Amount change should be saved

Actual Result:

Page refreshes

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6378609_1707856570560.Screen_Recording_2024-02-13_at_11.34.36_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01255e944bed02c24a
• Upwork Job ID: 1757576298278928384
• Last Price Increase: 2024-02-14

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[ZhenjaHorbach]

@shubham1206agra
Is it yours?)

Similar to #36363

[ghost]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reimburse - Pressing 'Enter' key on 'Rate' page refreshes the page

What is the root cause of that problem?

The main root cause of the problem is that Form is getting submitted automatically when we hit Enter key on the keyboard.

App/src/pages/workspace/reimburse/WorkspaceRateAndUnitPage/RatePage.tsx

Lines 85 to 105 in 19e2849

	<FormProvider
	formID={ONYXKEYS.FORMS.WORKSPACE_RATE_AND_UNIT_FORM}
	submitButtonText={translate('common.save')}
	validate={validate}
	onSubmit={submit}
	enabledWhenOffline
	style={[styles.flexGrow1]}
	shouldHideFixErrorsAlert
	submitFlexEnabled={false}
	submitButtonStyles={[styles.mh5, styles.mt0]}
	>
	<InputWrapperWithRef
	InputComponent={AmountForm}
	inputID={INPUT_IDS.RATE}
	currency={props.policy?.outputCurrency ?? CONST.CURRENCY.USD}
	extraDecimals={1}
	defaultValue={(
	(typeof props.workspaceRateAndUnit?.rate === 'string' ? parseFloat(props.workspaceRateAndUnit.rate) : defaultValue) / CONST.POLICY.CUSTOM_UNIT_RATE_BASE_OFFSET
	).toFixed(3)}
	/>
	</FormProvider>

What changes do you think we should make in order to solve the problem?

The main change that will stop this issue is, we need to stop the Form from getting submitted, when we hit Enter keyboard, by adding some kind off e.preventDefault(), which is basically the default behaviour of the form, which will not only just stop submitting the form, but would also stop the page from reloading again and again on hitting Enter key.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01255e944bed02c24a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[deetergp]

I don't think this is a blocker. I have confirmed that the bug exists in main and that the PR that @shubham1206agra raised for #36363 fixes this one too.

I was going to say that I'd expect hitting Enter would function the same clicking the Save button, but isn't how production works either.

[shubham1206agra]

Oh I am working on this on separate PR. This is from another PR I raised earlier.

[cubuspl42]

I understand that PR #36401 fixes this issue, right?

[Christinadobrzyn]

@deetergp or @Ollyws could you confirm this for us? #36439 (comment)

[Ollyws]

Let's hold this one for #36401

[cubuspl42]

This issue is now being handled in the regression path, and PR #36401 has been created to solve it. I'm not sure if we call such cases "holding".

Anyway, I'll make sure to make that PR ready for merging ASAP.

[shubham1206agra]

Clarification here: The expected behaviour should be that the page should not refresh. We do not submit form on pressing Enter now on this specific page.

[cubuspl42]

Unless there's any objection, we'll assume the expected behavior @shubham1206agra mentioned.

[getusha]

Clarification here: The expected behaviour should be that the page should not refresh. We do not submit form on pressing Enter now on this specific page.

Is there any way to allow submitting the form on enter yet preventing the refresh?

[shubham1206agra]

To prevent refresh, I already have a PR in place.

For submitting the form on Enter, I need to change so many components to achieve the same, so it might be a feature request for me. (This is context to this component only).

[getusha]

For submitting the form on Enter, I need to change so many components to achieve the same, so it might be a feature request for me. (This is context to this component only).

I feel like this should be handled here? or as a follow up? @shubham1206agra

[shubham1206agra]

Let me see if there's a simple fix to this. If there is, I will add it in the same PR.

[getusha]

thanks @shubham1206agra, and the expected result is Amount change should be saved 😄

[shubham1206agra]

@getusha Please check now. This is now same as Expected behavior.

[deetergp]

Where are we at with this one?

[cubuspl42]

@deetergp

Good question 🤔

PR #36401 is still open, but it's both C+ and internally approved. Not merged yet, though. There was some post-approval discussion between @shubham1206agra and @getusha.

[deetergp]

Nice! Looks like it got merged yesterday.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix form default behavior #36401

If no regressions arise, payment will be issued on 2024-03-11. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[cubuspl42]

• No payment due for @Ollyws
• BugZero checklist is redundant, as this was handled as a regression

[deetergp]

I think that means we can close this one out then, right?

[Christinadobrzyn]

Yep! closing!