[HOLD for payment 2024-03-07] [$500] Top part of the page becomes darker when user goes to the chats page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.40-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Pre-requisite: the user must be logged in.

1. Keep switching between the chats and workspaces pages.
2. Verify that the top part of the page becomes darker when user goes to the chats page.

Expected Result:

The top part of the page should remain in the same shade of white.

Actual Result:

The top part of the page becomes darker.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6377344_1707775492415.Sjkx7351_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ff0ec4f217764dfa
• Upwork Job ID: 1757172368748474368
• Last Price Increase: 2024-02-19
• Automatic offers:
• alitoshmatov | Reviewer | 0
• jeremy-croff | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ff0ec4f217764dfa

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[jeremy-croff]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app status bar is not the same color on the home screen

What is the root cause of that problem?

The color that is set on the home screen is slightly different than the other screens

What changes do you think we should make in order to solve the problem?

We can update

App/src/styles/theme/themes/light.ts

Line 96 in 07d97ef

backgroundColor: colors.productLight200,

to colors.productLight100. There's a corresponding dark theme that also needs to be updated to backgroundColor: colors.productDark100, for that screen.

What alternative solutions did you explore? (Optional)

[jeremy-croff]

https://github.com/Expensify/App/pull/32512/files updated some of the theme background colors without adjusting the status bar

[alexpensify]

@alitoshmatov - keep us posted if this proposal will fix the issue. Thanks!

[alitoshmatov]

@jeremy-croff Thank you for proposal, can provide some screen shots of your solution working. Also does changing this color effect other places of the app?

[jeremy-croff]

@jeremy-croff Thank you for proposal, can provide some screen shots of your solution working. Also does changing this color effect other places of the app?

2024-02-16_18-04-52.mp4

This change is scoped to the home screen route.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@alexpensify, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alexpensify]

Catching up from being OOO, @alitoshmatov any update to @jeremy-croff's reply? Thanks!

[alitoshmatov]

That looks great, let's go with @jeremy-croff 's proposal

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[alexpensify]

@yuwenmemon we need your review here. Thanks!

[melvin-bot]

@yuwenmemon @alexpensify @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@yuwenmemon, @alexpensify, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @jeremy-croff 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[jeremy-croff]

Acknowledged, will be able to provide this within the next 24hr. Thank you!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix(36385): update status bar colors #37244

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment automatic offer (Reviewer) $500
• @jeremy-croff requires payment automatic offer (Contributor) $500

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
• [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@alitoshmatov] Determine if we should create a regression test for this bug.
• [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

Awesome, looks like automation kicked in here.

---

Heads up, I will be offline until Tuesday, March 5, 2024. I will not be actively watching over this GitHub during that period. If anything urgent is needed here, please ask for help in the Open Source Slack Room-- thanks!

[alexpensify]

I've updated the payment summary here #36385 (comment) for the following job in Upwork:

https://www.upwork.com/jobs/~01ff0ec4f217764dfa

Closing since everyone has been paid here.