-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD E/E #359760] [$500] No "Hold Request" and "Add a receipt" option on workspace expense report as Admin #36202
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01c35580d297f84569 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh ( |
Triggered auto assignment to @MitchExpensify ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Auto-assign attempt failed, all eligible assignees are OOO. |
As the test step coming from my PR, I would like to clarify one thing. The delete request and add receipt option will be shown if the user is an admin AND the action/request owner, so this is not a bug. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
@bernhardoj could you share where did we discuss about this behavior? Because I think the Admin should have permission to delete request option, shouldn't they? |
Thank @bernhardoj. @MitchExpensify what do you think about our new expected behavior? |
Gonna mark this as a non-blocker as people on Collect policies are not actually using these flows yet |
@hoangzinh, @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
I've added a fix here since I touched that logic in the PR 06f3d4d, this is aligned with what we have in OldDot |
So this will be fixed by #46931 in review, right? |
Yup! |
@hoangzinh, @youssef-lr, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Not overdue, PR has been merged |
@hoangzinh, @youssef-lr, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@youssef-lr The PR #46931 has been deployed to Prod. Are we good to re-test this issue? |
@hoangzinh, @youssef-lr, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@hoangzinh original posting expired so here is a new one in upwork https://www.upwork.com/jobs/~014ecea72e003c577c lmk when you accept! |
It's an internal issue and I haven't reviewed the PR so no payment for me @kevinksullivan |
@hoangzinh, @youssef-lr, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
still looking for internal volunteer |
@kevinksullivan It appears that we're good to close this issue #36202 (comment). Arent' we? 🤔 |
@hoangzinh, @youssef-lr, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Not overdue, I think we can close this issue |
#36202 (comment) - yep, closing. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing #35744
Version Number: 1.4.39-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
There should be Hold Request and Add a receipt option on Admins side
Actual Result:
No "Hold Request" and "Add a receipt" option on workspace expense report as Admin
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6372780_1707437362871.Recording__2143.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: