Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wave 8] [Ideal Nav] Three not-found pages appear when a non-existing workspace is accessed with an invite link #35623

Closed
1 of 6 tasks
hayata-suenaga opened this issue Feb 2, 2024 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@hayata-suenaga
Copy link
Contributor

Action Performed:

  1. On a browser, go to https://dev.new.expensify.com:8082/workspace/0680EF3C70411F57/invite

Expected Result:

One single Not-Found page Hmm... it's not here should appear

Actual Result:

Three Not-Found pages appear

Screenshot 2024-02-01 at 6 44 52 PM

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Attached above

View all open jobs on GitHub

@hayata-suenaga hayata-suenaga added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 2, 2024
@hayata-suenaga hayata-suenaga self-assigned this Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@hayata-suenaga
Copy link
Contributor Author

@Expensify/design could you confirm what the UI should be when a non-existing workspace is accessed?

Please refer to the current UI in the issue description.

@hayata-suenaga hayata-suenaga changed the title Three not-found pages appear when a non-existing workspace is accessed with an invite link [Wave 8] [Ideal Nav] Three not-found pages appear when a non-existing workspace is accessed with an invite link Feb 2, 2024
@shawnborton
Copy link
Contributor

I think the idea here was to just show one "not found" view that spans across the entire app, not three distinct sections. Is that possible? cc @trjExpensify

@trjExpensify
Copy link
Contributor

Right, we created an issue here: #34234

@kosmydel are you still needing to work on this one?

@trjExpensify
Copy link
Contributor

Light:

image

Dark:

Screenshot 2024-01-15 at 10 20 59

@hayata-suenaga
Copy link
Contributor Author

ah I remembered that this was discussed before, but I thought the work is already done and that this is another regression.

In this case, we can combine this one with [Wave 8] [Ideal Nav] Improve "Hmm... it's not there" being duplicated across two content areas.

Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
No open projects
Development

No branches or pull requests

4 participants