[HOLD for payment 2024-08-02] [Wave Collect] [Ideal Nav] Improve "Hmm... it's not there" being duplicated across two content areas

[trjExpensify]

Coming from here.

Problem
With the new ideal navigation layout, we'll run into an instance where the "page not found" illustration is duplicated across two content areas on web/desktop. For example, when you try to access a workspace that has been deleted via a URL link to its settings:

Solution
Instead of showing it twice, we'll instead:

• Use a full page instead
• Clicking the back caret brings you back to the screen which you were at when you tried to access the missing workspace.
• If you don’t have a previous screen to return to, we return to the Chats tab of the “All” view.

CC: @hayata-suenaga @mountiny @shawnborton @JmillsExpensify @kosmydel @adamgrzybowski @s77rt

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[melvin-bot]

Triggered auto assignment to @miljakljajic (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[hayata-suenaga]

looking at the discussion in the linked Slack thread

[shawnborton]

This is what it looks like at full screen btw:

[kosmydel]

Hey, here is a preview of what it looks like.

[shawnborton]

That seems good to me!

[trjExpensify]

Nice! So I think we can take this off planning. @kosmydel, are you taking care of this so I can assign you? Also if so, can you link the PR to this issue? Thanks!

[kosmydel]

Sure, it will be included in our ideal nav branch after it goes through our internal SWM review.

[trjExpensify]

Nice, assigned you. Let us know once it has been included and then we can close it out.

[shawnborton]

Not overdue, I think we're still making progress here?

[hayata-suenaga]

@kosmydel Please also refer to this regression and check that the issue reported there is also fixed with your PR 🙇

[kosmydel]

Hey, I started working on this issue today. I'm trying to find a solution to cover all cases in a clean way. However, it looks like a more complex problem, especially for RHP modals.

[hayata-suenaga]

@kosmydel, thank you for sharing the estimated work required to resolve this issue.

I'll adjust the priority of this issue to a weekly status. Please prioritize other regressions that have higher priorities and simpler solutions.

update: it already has the weekly priority!

[kosmydel]

@hayata-suenaga I've prepared a very early draft of the PR. I still have to test it thoroughly.

---

I found a one issue which makes it impossible to test it:

1. Log out
2. Go to some WS link, e.g. https://staging.new.expensify.com/workspace/adsasddssad/rateandunit (doesn't matter if policy exist or not)
3. Log in
4. Infinity loading

Workaround:
Go to the chat list, wait until all reports are loaded, try to open the link again.

Loading the Onyx state doesn't work from deeplinks at all.

[kosmydel]

This one is being reviewed by @situchan.

[trjExpensify]

PR is in review, ready for a look from @neil-marcellini.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: three not found view v2 #41665

If no regressions arise, payment will be issued on 2024-08-02. 🎊

For reference, here are some details about the assignees on this issue:

• @kosmydel does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@kosmydel] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[situchan]

Please assign me here

[trjExpensify]

Payment summary as follows:

• $250 to @situchan for the PR review

Offer sent.

[situchan]

Can this be 500?

reasoning:

• super old issue (before price change)
• size of PR which fixes multiple issues at once
• required lots of testing as seen in QA Steps of PR

[trjExpensify]

super old issue (before price change)

Fair. Can you accept the offer so I can pay it though?

[melvin-bot]

@shawnborton, @trjExpensify, @Gonals, @kosmydel, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

Paid, closing!