[HOLD for payment 2024-02-26] [$500] Chat - "Hidden" is not shown on the header of avatar for "Hidden" contact

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.34-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open 1:1 DM with Hidden user (yonghongkok2+03011@gmail.com
2. Click on the chat header.
3. Click on the avatar.

Expected Result:

The header shows "Hidden"

Actual Result:

The header is blank and missing "Hidden"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362814_1706731188196.bandicam_2024-02-01_02-48-30-736.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010dd17add55a87ae6
• Upwork Job ID: 1752801163354193920
• Last Price Increase: 2024-01-31
• Automatic offers:
• mollfpr | Reviewer | 0
• ZhenjaHorbach | Contributor | 0

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010dd17add55a87ae6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - "Hidden" is not shown on the header of avatar for "Hidden" contact

What is the root cause of that problem?

We have a condition here such that we will display empty string if we don't get user name.

App/src/pages/settings/Profile/ProfileAvatar.tsx

Line 37 in ed95bc0

headerTitle={personalDetail?.displayName ?? ''}

What changes do you think we should make in order to solve the problem?

Just remove the empty string and put hidden value as a alternative if we don't get user email

What alternative solutions did you explore? (Optional)

NA

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - "Hidden" is not shown on the header of avatar for "Hidden" contact

What is the root cause of that problem?

In the ReportAvatar component, we do not use hidden but just an empty string if the personalDetail.displayName is not available.

App/src/pages/settings/Profile/ProfileAvatar.tsx

Lines 36 to 37 in ed95bc0

	<AttachmentModal
	headerTitle={personalDetail?.displayName ?? ''}

What changes do you think we should make in order to solve the problem?

Instead of falling back on an empty string, we change to 'common.hidden'.

For example:

<AttachmentModal
    headerTitle={personalDetail?.displayName ?? translate('common.hidden')}
    ...

For best standards, we should use the useLocalize hook to translate 'common.hidden'.

const {translate} = useLocalize();

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - "Hidden" is not shown on the header of avatar for "Hidden" contact

What is the root cause of that problem?

The main problem with this issue is that when we don't have displayName we show empty string

App/src/pages/settings/Profile/ProfileAvatar.tsx

Line 37 in ed95bc0

headerTitle={personalDetail?.displayName ?? ''}

What changes do you think we should make in order to solve the problem?

To fix this issue we can use logic from the ProfilePage and use PersonalDetailsUtils.getDisplayNameOrDefault

App/src/pages/ProfilePage.js

Line 103 in d598291

const displayName = PersonalDetailsUtils.getDisplayNameOrDefault(details);

And then pass result this function in headerTitle

I think this is the best option
Because we will maintain consistency between screens (Including for displaying Hidden)

What alternative solutions did you explore? (Optional)

NA

[Tony-MK]

@RohanSasne, I noticed you changed your Prospal after I posted mine.

[allgandalf]

hey @Tony-MK, thanks for pointing out , i was updating my proposal while you posted yours, there is two minute delay, i assure you i haven't taken any inspiration from your proposal to write mine :)

[mollfpr]

Thank you guys for the proposals! The proposal from @ZhenjaHorbach looks the best for the fix in this issue. I agree to use getDisplayNameOrDefault to show the modal title.

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@tylerkaraszewski, @mollfpr, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mollfpr]

Friendly bump @tylerkaraszewski

[melvin-bot]

@tylerkaraszewski, @mollfpr, @miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 @mollfpr 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ZhenjaHorbach]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

PR will be ready on weekend

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix bug with Hidden is not shown on the header of avatar for Hidden contact #36290

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment automatic offer (Reviewer)
• @ZhenjaHorbach requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:

#28999

[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/28999/files#r1503614748

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Open 1:1 DM with Hidden user (yonghongkok2+03011@gmail.com)
2. Click on the chat header.
3. Click on the avatar.
4. Verify that Hiden is displayed on the avatar screen
5. 👍 or 👎

[mollfpr]

@miljakljajic I'll do the manual request in NewDot, could you give the payment summary? Thank you!

[miljakljajic]

@mollfpr is owed 500 USD for their role as reviewer

[miljakljajic]

@ZhenjaHorbach are you paid in upwork? I can't access the offer via that link, it throws up an error. I can send another?

[ZhenjaHorbach]

@ZhenjaHorbach are you paid in upwork? I can't access the offer via that link, it throws up an error. I can send another?

Hello)
Strange)
This is my first time like this
But I think yes, you can resend the offer)

[miljakljajic]

@ZhenjaHorbach what's your name in upwork? I tried to search for you but it isn't coming up

[ZhenjaHorbach]

@ZhenjaHorbach what's your name in upwork? I tried to search for you but it isn't coming up

Here is the link
https://www.upwork.com/freelancers/~01e2ef043508da9f2c

[miljakljajic]

Sent - let me know when you accept

[miljakljajic]

Paid!

[JmillsExpensify]

$500 approved for @mollfpr based on summary above.