[$500] IOU - Description and Merchant in IOU preview are displayed in different style

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.33-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:

Action Performed:

1. Go to 1:1 DM.
2. Create two money requests - one with merchant, and another one with only description.
3. Go to IOU report.

Expected Result:

Merchant and Description will be displayed in IOU preview in the same style.

Actual Result:

Merchant is not bolded and appear grayed out, while the description is bolded in IOU preview.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6360790_1706616061774.20240130_123505.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01370109af3b78ad99
• Upwork Job ID: 1752312317782040576
• Last Price Increase: 2024-01-30
• Automatic offers:
• bernhardoj | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01370109af3b78ad99

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[kbecciv]

We think that this bug might be related to #vip-bills
CC @davidcardoza

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - Description and Merchant in IOU preview are displayed in different style

What is the root cause of that problem?

The main problem with issue is that we use different component with different styles

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 337 to 338 in 27271d5

	{shouldShowDescription && <RenderHTML html={parser.replace(merchantOrDescription)} />}
	{shouldShowMerchant && <Text style={[styles.textLabelSupporting, styles.textNormal]}>{merchantOrDescription}</Text>}

What changes do you think we should make in order to solve the problem?

To fix this issue we can use the same styles and components for these texts

But there is a bit unclear what we are expected
So before we change styles and components
Design team help needed

But since before we had problem with markdown
HTML component looks beter

What alternative solutions did you explore? (Optional)

NA

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merchant is not bolded and appear grayed out, while the description is bolded in IOU preview.

What is the root cause of that problem?

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 337 to 338 in 27271d5

	{shouldShowDescription && <RenderHTML html={parser.replace(merchantOrDescription)} />}
	{shouldShowMerchant && <Text style={[styles.textLabelSupporting, styles.textNormal]}>{merchantOrDescription}</Text>}

we are rendering merchant and description in 2 different way

What changes do you think we should make in order to solve the problem?

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 337 to 338 in 27271d5

	{shouldShowDescription && <RenderHTML html={parser.replace(merchantOrDescription)} />}
	{shouldShowMerchant && <Text style={[styles.textLabelSupporting, styles.textNormal]}>{merchantOrDescription}</Text>}

Because in 2 cases, we both render the same value merchantOrDescription. So we should update like that
Option 1:

{(shouldShowDescription || shouldShowMerchant) && <RenderHTML html={parser.replace(merchantOrDescription)} />} 

Option 2:

 {(shouldShowDescription || shouldShowMerchant) && <Text style={[styles.textLabelSupporting, styles.textNormal]}>{merchantOrDescription}</Text>} 

We need to ask the design team to decide which option we should go with

What alternative solutions did you explore? (Optional)

NA

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The text color style between merchant and description is different.

What is the root cause of that problem?

The description is rendered with RenderHTML while the merchant is rendered with text with a style that has a color of textSupporting.

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 337 to 338 in 82ae62f

	{shouldShowDescription && <RenderHTML html={parser.replace(merchantOrDescription)} />}
	{shouldShowMerchant && <Text style={[styles.textLabelSupporting, styles.textNormal]}>{merchantOrDescription}</Text>}

The default style for RenderHTML can be seen below which is different from the merchant text style (the color).

App/src/styles/index.ts

Lines 217 to 220 in 82ae62f

	baseFontStyle: {
	color: theme.text,
	fontSize: variables.fontSizeNormal,
	fontFamily: FontUtils.fontFamily.platform.EXP_NEUE,

What changes do you think we should make in order to solve the problem?

To make them both show the same color, we can wrap the description with <muted-text> tag.

{shouldShowDescription && <RenderHTML html={`<muted-text>${parser.replace(merchantOrDescription)}</muted-text>`} />}

[melvin-bot]

@anmurali, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rushatgabhane]

reviewing

[rushatgabhane]

I like @bernhardoj's proposal 🎀 👀 🎀
#35393 (comment)

The expected result is - the preview should have color textSupporting and the description should support markdown

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[anmurali]

@marcochavezf based on #35393 (comment), should we assign the job to @bernhardoj ?

[marcochavezf]

Yes, assigning @bernhardoj 🚀 thanks for the review @rushatgabhane, and apologies for the delay

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @rushatgabhane

[melvin-bot]

This issue has not been updated in over 15 days. @marcochavezf, @anmurali, @rushatgabhane, @bernhardoj eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[rushatgabhane]

@anmurali could you please attach payment summary, thanks 🙇

[rushatgabhane]

payment request here https://staging.new.expensify.com/r/1789662421125982

[JmillsExpensify]

@anmurali please add a payment summary when you get a chance.

[anmurali]

• Contributor: @bernhardoj $500 via Upwork
• Contributor+: @rushatgabhane $500 via NewDot

[anmurali]

@JmillsExpensify added above and paid @bernhardoj. I am closing the issue as it sounds like you already have a ND request for @rushatgabhane and you can check it off here after you process payment for this on ND.

[JmillsExpensify]

$500 approved for @rushatgabhane based on summary.