[$500] Room - Member avatar tooltip shows "Hidden" in room member list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.31-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Create a room
2. Go to the room
3. Click on the room header > Members
4. Hover over member avatar

Expected Result:

Member avatar shows the correct user name or contact email

Actual Result:

Member avatar shows "Hidden"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6353426_1706113515703.20240124_200555__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0191a6dde0cd6d53c6
• Upwork Job ID: 1755268736264658944
• Last Price Increase: 2024-02-07
• Automatic offers:
• dukenv0307 | Contributor | 28149073

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp.
CC @quinthar

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Member avatar shows "Hidden"

What is the root cause of that problem?

UserDetailTooltip is rendered base on accountID prop but we don't add id as accountID of the user into icons in member option of RoomMemberPage, we should add id as accountID

App/src/pages/RoomMembersPage.js

Line 220 in 8ad78dc

type: CONST.ICON_TYPE_AVATAR,

App/src/components/SubscriptAvatar.tsx

Line 44 in f2bcff0

accountID={Number(mainAvatar?.id ?? -1)}

What changes do you think we should make in order to solve the problem?

We should add id: accountID into icons field of member option

App/src/pages/RoomMembersPage.js

Line 220 in 8ad78dc

type: CONST.ICON_TYPE_AVATAR,

icons: [
    {
        source: UserUtils.getAvatar(details.avatar, accountID),
        name: details.login,
        type: CONST.ICON_TYPE_AVATAR,
        id: accountID
    },
],

What alternative solutions did you explore? (Optional)

NA

[thienlnam]

Removing the blocker since I don't think this needs to block deploy, but something we should definitely fix

[melvin-bot]

@puneetlath Eep! 4 days overdue now. Issues have feelings too...

[situchan]

If requires C+ review, I can help

[melvin-bot]

@puneetlath Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@puneetlath 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

@puneetlath 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0191a6dde0cd6d53c6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[puneetlath]

Sorry for the delay here. @thesahindia mind reviewing the existing proposal?

[thesahindia]

@dukenv0307's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@thesahindia The PR is ready for review.

[dukenv0307]

@puneetlath Seems Melvin is away. The PR was deployed to production 2 weeks ago, can we proceed with payments here.

Thank you!

[puneetlath]

Payment summary:

• C - $500 - @dukenv0307 - paid via Upwork
• C+ - $500 - @thesahindia - to be paid via NewDot.

@thesahindia please request on NewDot.

Thanks everyone!

[JmillsExpensify]

I need the exact amounts for payment in the summary. Thank ya!

[puneetlath]

Whoops, sorry about that @JmillsExpensify. Updated.

[JmillsExpensify]

Thank you! $500 approved for @thesahindia