Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-18] [TS Migration] Standardize approach to Onyx pendingFields #34662

Closed
roryabraham opened this issue Jan 17, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. Typescript Migration

Comments

@roryabraham
Copy link
Contributor

Slack context: https://expensify.slack.com/archives/C0593T50UHG/p1705346773892779

Problem

We do not have a consistent pattern for pendingFields in Onyx, resulting in multiple divergent implementations, greater likelihood of bugs, and developer overhead to choose the "correct" one.

Solution

Standardize our approach to pendingFields in Onyx.

@roryabraham roryabraham added Improvement Item broken or needs improvement. Typescript Migration labels Jan 17, 2024
@roryabraham roryabraham self-assigned this Jan 17, 2024
@roryabraham
Copy link
Contributor Author

cc @blazejkustra @fabioh8010

@ghost
Copy link

ghost commented Jan 17, 2024

dibs

@roryabraham roryabraham added the Weekly KSv2 label Jan 17, 2024
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@roryabraham
Copy link
Contributor Author

Sorry @AnshuAgarwal24, this topic was discussed in slack before an issue was created, and we already had an assignment in mind. I would've assigned them right away but because of our GitHub configuration they need to comment first before we can assign them.

@roryabraham
Copy link
Contributor Author

Just answered some questions in the draft PR

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Weekly KSv2 labels Feb 1, 2024
@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

@DylanDylann
Copy link
Contributor

@roryabraham Could you help to assign a CME to this issue for payment?

@mountiny mountiny added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 Reviewing Has a PR in review labels Mar 18, 2024
@mountiny mountiny changed the title [TS Migration] Standardize approach to Onyx pendingFields [HOLD for payment 2024-03-18] [TS Migration] Standardize approach to Onyx pendingFields Mar 18, 2024
@mountiny
Copy link
Contributor

@puneetlath assigned you back since you have been previously assigned by the NewFeature label

I believe this is ready to payout to @DylanDylann for $250 for the review

Copy link

melvin-bot bot commented Mar 18, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@puneetlath
Copy link
Contributor

@DylanDylann can you link me your Upwork profile?

@DylanDylann
Copy link
Contributor

@puneetlath
Copy link
Contributor

@DylanDylann sent you an offer: https://www.upwork.com/nx/wm/offer/101473125

Please ping me on this issue once you've accepted.

@DylanDylann
Copy link
Contributor

@puneetlath Accepted. Thanks

@puneetlath
Copy link
Contributor

Paid, thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. Typescript Migration
Projects
Development

No branches or pull requests

5 participants