Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'sanitizeStringForJSONParseTest.js' test to TypeScript #25264

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 10 comments
Closed
Assignees
Labels
NewFeature Something to build that is a new item. Not a priority Reviewing Has a PR in review Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
tests/unit/sanitizeStringForJSONParseTest.js 1
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot reopened this Nov 23, 2023
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

@JKobrynski
Copy link
Contributor

The PR is ready for review!

Copy link
Author

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Feb 20, 2024
Copy link
Author

melvin-bot bot commented Feb 20, 2024

@roryabraham
Copy link
Contributor

This is done. It's just a test so "deployed" as soon as it's merged

@DylanDylann
Copy link
Contributor

DylanDylann commented Feb 28, 2024

@roryabraham @zanyrenney I reviewed the PR as a C+ contributor. Could you help to assign me to this issue and handle payment here

@DylanDylann
Copy link
Contributor

No payment as mentioned here. Let's close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Not a priority Reviewing Has a PR in review Task Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

4 participants