[HOLD for payment 2024-02-20] [$500] [ECARD TRANSACTIONS] Pay elsewhere button is missing the reimbursable total

[kevinksullivan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C05DWUDHVK7/p1705442420036949?thread_ts=1705442308.576449&cid=C05DWUDHVK7

Action Performed:

1. Create a free workspace and set it as your default
2. Add a manual request
3. Tap into the report
4. Select the payment option dropdwown

Expected Result:

Both Pay with Expensify and Pay elsewhere buttons should include the reimbursable total you are paying in the button copy

Actual Result:

Pay elsewhere does not include this total

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e5409827a7bf0019
• Upwork Job ID: 1748141602955698176
• Last Price Increase: 2024-01-19
• Automatic offers:
• c3024 | Reviewer | 28110702
• esh-g | Contributor | 28110704

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[esh-g]

Proposal

Please re-state the problem we are trying to solve?

Both Pay with Expensify and Pay elsewhere buttons should include the reimbursable total you are paying in the button copy but 'pay elsewhere' doesn't have that.

What is the root cause of the problem?

No logic to add amount to pay elsewhere

What changes should be made to fix this?

App/src/languages/en.ts

Lines 598 to 599 in a8acf44

	settleExpensify: ({formattedAmount}: SettleExpensifyCardParams) => (formattedAmount ? `Pay ${formattedAmount} with Expensify` : `Pay with Expensify`),
	payElsewhere: 'Pay elsewhere',

We should modify payElsewhere: 'Pay elsewhere' translation to the following:

payElsewhere: ({formattedAmount}: SettleExpensifyCardParams) => (formattedAmount ? `Pay ${formattedAmount} elsewhere` : `Pay elsewhere`),

Then pass the formattedAmount here:

App/src/components/SettlementButton.js

Line 163 in a8acf44

text: translate('iou.payElsewhere'),

Just like we do for expensify here:

App/src/components/SettlementButton.js

Line 158 in a8acf44

text: translate('iou.settleExpensify', {formattedAmount}),

We can also of course modify the name of SettleExpensifyCardParams to something like SettlementOptionParams to reflect it's alter usage.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e5409827a7bf0019

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[c3024]

@esh-g 's proposal here looks good to me.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @esh-g 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

This issue has not been updated in over 15 days. @blimpich, @grgia, @esh-g, @c3024 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add formatted amount to pay elsewhere #34854

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

• @esh-g requires payment automatic offer (Contributor)
• @c3024 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[c3024]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR: Update Expense Report View / Headers #22484
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22484/files#r1493748140
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not started because this has been appearing this way but now it is preferred to add amount in the Pay elsewhere as well.
• [@c3024] Determine if we should create a regression test for this bug. No, I think this is not a significant bug that meaningfully affects user experience adversely.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. NA

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @jliexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[jliexpensify]

Just catching up - I will need to create a new Upworks job as the old one was closed.

[jliexpensify]

Payment Summary

• Contributor: @esh-g $500
• C+: @c3024 $500

New Upworks Job

[c3024]

Offer accepted!

[jliexpensify]

Paid and job closed!