Implement the full Screen Settings page

[hayata-suenaga]

As part of the Ideal Nav overhaul, implement the Full Screen settings according to the requirements specified in the design doc.

Parent Issue: #32689

[melvin-bot]

Triggered auto assignment to @twisterdotcom (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[hayata-suenaga]

@kosmydel from Software Mansion is going to work on this issue 🎉

[kosmydel]

Hey, I’m from Software Mansion and I will work on this issue.

[melvin-bot]

@twisterdotcom, @kosmydel Eep! 4 days overdue now. Issues have feelings too...

[twisterdotcom]

Still in draft.

[hayata-suenaga]

@kosmydel feel free to mark the PR ready for review so that you can get feedbacks early in the progress 🙇

[kosmydel]

@kosmydel feel free to mark the PR ready for review so that you can get feedbacks early in the progress 🙇

Hey, sorry for not posting an update here.
This change will be included in our internal feature branch. We did it, as we had to glue Bottom Tab Navigator with Full Screen Settings, and it was easier to maintain it that way. So to sum up, it will be one PR with navigation changes.

[melvin-bot]

@twisterdotcom, @kosmydel Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@twisterdotcom, @kosmydel 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@twisterdotcom, @kosmydel 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

@twisterdotcom, @kosmydel 10 days overdue. Is anyone even seeing these? Hello?

[kosmydel]

Hey, the PR including full-screen account settings is available here.

[twisterdotcom]

@hayata-suenaga do we need a C+ assigned here for payment too. That PR has @blazejkustra reviewing - should I assign them here too?

[twisterdotcom]

Bump on my Q @hayata-suenaga.

[twisterdotcom]

@s77rt you're testing it seems in the PR. Are you assigned somewhere else for this? Or do you need assigning for payment for that here? Otherwise, I think this issue can be closed given this is being resolved by the larger PR for ideal nav.

[hayata-suenaga]

@twisterdotcom I apologize I was OOO

I don't think we don't need payment for @s77rt because we don't even have a PR for this issue (the code change was done in the Software Mansion's internal branch.

[s77rt]

I'm not sure where I'm supposed to be assigned. Maybe it should be in the parent issue #32689

[hayata-suenaga]

@s77rt did you review any PR for this issue?

[s77rt]

No but those 2 PRs (full screen navigator and bottom tabs navigator) are being handled in one PR here #33280

[s77rt]

So technically yes 😅 I'm reviewing those PRs

[hayata-suenaga]

ah I see they didn't link the issue to their PR... can you ask in the PR to be assigned to any of the relevant issues? I'm sorry for the confusion 🙇

[s77rt]

Should we close this and #32941? The relevant issue is the parent issue