[Hold for payment 2024-02-12] [$1500] Implement a new navigator for the Ideal Nav overhaul

[hayata-suenaga]

Implement the new navigation system for the Ideal Nav project.

The detailed requirements for the new navigation structure are stipulated in this design doc.

@adamgrzybowski from Software Mansion will do the implementation work. We will keep track of the progress using this issue.

Potential new requirement that hasn't made it to the design doc yet.

Child issues

• [HOLD for payment 2024-01-02] [HOLD for payment 2023-12-28] [$500] Implement Left Hand Nav #32939
• Implement the full Screen Settings page #32940
• Implement Bottom Tab Navigator #32941

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[adamgrzybowski]

👋

[adamgrzybowski]

Hey @hayata-suenaga this issue seems quite general. We divided our work on the structure of navigation into three separate task

Left hand navigator - @WojtekBoman
Full screen settings page - @kosmydel
Bottom tab navigator - @adamgrzybowski

Maybe we could create these issues to track progress more accurately?

[hayata-suenaga]

Created an issue for each piece of the new navigation feature as listed above by Adam. These issues should appear below this comment as links.

Is @kosmydel working on the full screen settings page for the account for workspace or both? Seems like @kosmydel is working on the full screen page for the account settings page. Are you also planning to work on the workspace settings page? For the workspace settings page, you can use this issue.

[hayata-suenaga]

I am assigning myself to this tracking issue for three navigation-related issues.

@adamgrzybowski if you need a feature branch to which to merge navigation-related branches, please use https://github.com/Expensify/App/tree/ideal-nav that Vit created.

[s77rt]

@hayata-suenaga Can you assign me here?

[hayata-suenaga]

the work is on progress

[hayata-suenaga]

the feature branch is very close to be merged

[s77rt]

@hayata-suenaga Can you please assign a BZ member for payment processing?

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[hayata-suenaga]

An expert agency engineer authored the PR, so the only payment we need is for C+.

@lschurr The PR @s77rt (C+) reviewed was super huge. They deserve at least twice the usual payment. I'd say 3x.

[lschurr]

Sounds good @hayata-suenaga! Can you link me to the specific PR so I can see when it's merged for payment?

[hayata-suenaga]

ah sorry about that

here is the PR

[lschurr]

Thanks! Looks like it was deployed to prod on Feb 5th, so we'll pay on Feb 12th.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[hayata-suenaga]

by the way, there are multiple regressions that stemmed from the PR, but all these regressions were expected. They should not reduce the payout to @s77rt

[s77rt]

Thank you! But I'm good with the standard $500. Not counting those regression is enough

[lschurr]

We discussed internally and decided $1500 is a fair price for the amount of work you put into this one @s77rt :)

[lschurr]

Sent offer in Upwork: https://www.upwork.com/nx/wm/offer/100843971

[s77rt]

Accepted! Thank you!

[lschurr]

Paid in Upwork :)

[hayata-suenaga]

thank you so much and great work @s77rt !