[Awaiting Checklist Completion] [$500] Hovering over multiline link for few times removes message background color

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.85-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697542987624259

Action Performed:

1. Open the app
2. Open any report
3. Send multiline link with one line space in between
4. Hover over them back and forth for few times
5. Observe that app removes background color from message and hovering over whole length of message still doesn't enable background color

Expected Result:

App should not remove background color from messages when we are hovering on it

Actual Result:

App removes background color from messages even when we are hovering on it if we hover back and forth on multline link for few times

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

mac.chrome.moving.cursor.over.multiline.link.removes.bg.color.mov

Recording.116.mp4

MacOS: Desktop

mac.desktop.moving.cursor.over.multline.link.removes.bg.color.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c1eee5b08ec459f3
• Upwork Job ID: 1714379542416052224
• Last Price Increase: 2023-10-24
• Automatic offers:
• 0xmiroslav | Reviewer | 27488648
• bernhardoj | Contributor | 27488649
• dhanashree-sawant | Reporter | 27488650

Issue Owner

Current Issue Owner: @0xmiroslav

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c1eee5b08ec459f3

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hover over a link message and then move the mouse up quickly sometimes remove the message hover effect even though our mouse is still hovering over it.

What is the root cause of that problem?

When we hover over a link, a tooltip will show. When we move up our mouse quickly, our mouse will briefly hover over the tooltip. In Hoverable, we have a logic to remove the hover effect if we hover over an element that is not the child of the currently hovered element, in our case the ReportActionItem.

App/src/components/Hoverable/index.js

Lines 111 to 121 in 9664f8c

	const unsetHoveredIfOutside = (e) => {
	if (!ref.current || !isHovered) {
	return;
	}
	if (ref.current.contains(e.target)) {
	return;
	}
	setIsHovered(false);
	};

The tooltip is not a child of ReportActionItem because we put the tooltip on the body element, so the hover effect will lost.

What changes do you think we should make in order to solve the problem?

The simplest solution is to set pointerEvents: none to the tooltip, so mouseover won't be triggered on a tooltip.

What alternative solutions did you explore? (Optional)

In unsetHoveredIfOutside, we can add another check to ignore the logic if the hovered element is a tooltip or its children (this is important because mouseover will be triggered for all children).

const unsetHoveredIfOutside = (e) => {
+   if (e.target.closest('[data-tag="tooltip"]')) {
+       return;
+   }

TooltipRenderedOnPageBody.js

<Animated.View
+   dataSet={{tag: 'tooltip'}}

[ashuvssut]

(NOT a Proposal)

Root cause

Here's a Video with voiceover explaining the Root cause

Please unmute the audio in the following video

root.cause.hover.ReportActionItem.mp4

I Proposed a wrong solution. So I removed my Proposal and i m leaving this video from my proposal bcz i think this might be helpful

[melvin-bot]

@twisterdotcom, @0xmiroslav Huh... This is 4 days overdue. Who can take care of this?

[twisterdotcom]

@0xmiroslav let me know what you think of @ashuvssut or @bernhardoj's proposals.

@ashuvssut - I do think the video is nice, but could you follow the normal template in future please?

[ashuvssut]

I had a proposal before. But when I saw at @bernhardoj's proposal, I realized that my solution was wrong. So, I removed my proposal 😅

[twisterdotcom]

Shall we get @bernhardoj on this then @0xmiroslav?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[twisterdotcom]

bump @0xmiroslav

[0xmiros]

reviewing

[melvin-bot]

@twisterdotcom, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[0xmiros]

updating today

[melvin-bot]

@twisterdotcom @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[0xmiros]

@bernhardoj's proposal looks good.
As tooltip itself doesn't require hover, the main solution (pointerEvents: none) is fine to me.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[deetergp]

I agree with @0xmiroslav, let's go with @bernhardoj 👍

[melvin-bot]

📣 @0xmiroslav 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @0xmiroslav

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix hover over message link tootlip clears the report action hover color #30780

If no regressions arise, payment will be issued on 2023-11-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment offer (Contributor)
• @0xmiroslav requires payment offer (Reviewer)
• @dhanashree-sawant requires payment offer (Reporter)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

Ah, I was OOO yesterday. Doing this now.

[twisterdotcom]

Payment Summary:
@bernhardoj paid $500 here (Contributor)
@0xmiroslav paid $500 here (Reviewer)
@dhanashree-sawant paid $50 here (Reporter)

@0xmiroslav please complete the checklist.

[0xmiros]

No regression. As this is edge case and minor style issue, I think we can skip regression test.