Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split - Total group split details card does not appear in chat until the chat is revisited #29634

Closed
6 tasks done
lanitochka17 opened this issue Oct 14, 2023 · 18 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 14, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.84-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Issue found when executing PR #29424

Action Performed:

Precondition: User A is a workspace admin and User B is a workspace member

  1. [User A] Open the workspace chat with User B
  2. [User B] Go to FAB > Request money > Manual > Enter amount > Next
  3. [User B] Select Split on the workspace chat in Step 1 > Create the bill split

Expected Result:

On User A's side, the total group split details card will appear along with individual split preview

Actual Result:

On User A's side, only the invididual split preview appears. The total group split details card does not appear until the chat is revisited

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6237350_1697315062260.bandicam_2023-10-15_03-10-24-626.mp4
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0137b2e4cc6c36c506
  • Upwork Job ID: 1713664488466337792
  • Last Price Increase: 2023-10-15
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 14, 2023

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 14, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 14, 2023

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny mountiny added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 15, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0137b2e4cc6c36c506

@melvin-bot
Copy link

melvin-bot bot commented Oct 15, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

@mountiny
Copy link
Contributor

This will most likely have to be internal and we need to ensure the split action is pushed to the groupchat too. I dont think it has to be a deploy blocker though so demoting cc @youssef-lr

@neil-marcellini
Copy link
Contributor

Thanks Vit. @youssef-lr have you been working on this lately and would you like to take it over? That would be a big help to me.

@youssef-lr
Copy link
Contributor

Sure @neil-marcellini :)

@youssef-lr
Copy link
Contributor

Working on this tomorrow.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

@youssef-lr, @Christinadobrzyn, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Christinadobrzyn
Copy link
Contributor

hi @youssef-lr let us know if you have a PR or update for this! Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@youssef-lr
Copy link
Contributor

PR is underway @Christinadobrzyn

@youssef-lr youssef-lr added the Reviewing Has a PR in review label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2023

@youssef-lr, @Christinadobrzyn, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

@youssef-lr
Copy link
Contributor

This should be fixed now.

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Oct 31, 2023

Awesome! Let me know if these payouts look accurate!

Payouts due:

Issue Reporter: NA
Contributor: NA
Contributor+: @0xmiroslav NA based on #29634 (comment)

Eligible for 50% #urgency bonus? NA - internal

Upwork job is here.

@0xmiros
Copy link
Contributor

0xmiros commented Oct 31, 2023

It was backend fix and no payment required here

@Christinadobrzyn
Copy link
Contributor

Ah okay, thanks @0xmiroslav - closed the Upwork job. Closing this as complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants