[HOLD for payment 2023-10-27] [$250] Dev: Emojipicker in Set status page has a text cursor instead of pointer

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: Dev 1.3.79.3
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696763872801869

Action Performed:

Pre condition: Make sure you have Beta for status feature

1. Navigate to Profile -> Status -> Set Status
2. Hover on Emoji Picker Drop Down Button

Expected Result:

Emojipicker Dropdown button has a pointer cursor

Actual Result:

Emojipicker Dropdown button has a text cursor.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

n/a

Android: mWeb Chrome

n/a

iOS: Native

n/a

iOS: mWeb Safari

n/a

MacOS: Chrome / Safari

Screen.Recording.2023-10-08.at.4.42.59.PM.mov

MacOS: Desktop

Screen.Recording.2023-10-08.at.4.51.16.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018aae903757e06f35
• Upwork Job ID: 1711460039105232896
• Last Price Increase: 2023-10-10
• Automatic offers:
• ishpaul777 | Contributor | 27225708
• ishpaul777 | Reporter | 27225711

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emojipicker in Set status page has a "text" cursor instead of pointer

What is the root cause of that problem?

We have not added styles for pointer cursor here.

App/src/styles/styles.js

Lines 3539 to 3550 in 389d7b0

	emojiPickerButtonDropdown: {
	justifyContent: 'center',
	backgroundColor: theme.activeComponentBG,
	width: 86,
	height: 52,
	borderRadius: 26,
	alignItems: 'center',
	paddingLeft: 10,
	paddingRight: 4,
	marginBottom: 32,
	alignSelf: 'flex-start',
	},

What changes do you think we should make in order to solve the problem?

add ...cursor.cursorPointer at the end of emojiPickerButtonDropdown

  emojiPickerButtonDropdown: {
        justifyContent: 'center',
        backgroundColor: theme.activeComponentBG,
        width: 86,
        height: 52,
        borderRadius: 26,
        alignItems: 'center',
        paddingLeft: 10,
        paddingRight: 4,
        marginBottom: 32,
        alignSelf: 'flex-start',
        ...cursor.cursorPointer,

    },

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[kbecciv]

Proposal by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696763872801869

Proposal

Problem

Emojipicker in Set status page has a "text" cursor instead of pointer

Root Cause

We are setting the accessibilityRole="text" for PressableWithoutFeedback used for the dropdown which result in curesor style as "text" I have aasked clarifying question why we used "text" instead of "button" (here)[https://github.com//pull/23267]

Changes

We can change accessibilityRole=CONST.ACCESSIBILITY_ROLE.BUTTON or expilicty add cursor style to cursorPointer and cursorDisabled when disabled

Reply…
Also send to expensify-bugs

[ishpaul777]

edit : Fixed some typos from ^

Proposal

Problem

Emojipicker in Set status page has a "text" cursor instead of pointer

Root Cause

We are setting the accessibilityRole="text" for PressableWithoutFeedback used for the dropdown which result in cursor style as "text". I have asked clarifying question why we used "text" instead of "button" here

Changes

We can change accessibilityRole=CONST.ACCESSIBILITY_ROLE.BUTTON or expilicty add cursor style to cursorPointer and cursorDisabled when disabled

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018aae903757e06f35

[melvin-bot]

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

[vadymbokatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emojipicker in Set status page has a "text" cursor instead of pointer

What is the root cause of that problem?

App/src/components/EmojiPicker/EmojiPickerButtonDropdown.js

Lines 40 to 48 in 4a24fd6

	<PressableWithoutFeedback
	ref={emojiPopoverAnchor}
	style={styles.emojiPickerButtonDropdown}
	disabled={props.isDisabled}
	onPress={onPress}
	nativeID="emojiDropdownButton"
	accessibilityLabel="statusEmoji"
	accessibilityRole="text"
	>

accessibilityRole="text" in the PressableWithoutFeedback is the root cause of this issue.

What changes do you think we should make in order to solve the problem?

we can add cursor: 'pointer' to style of PressableWithoutFeedback or change accessibilityRole to button.

[melvin-bot]

Upwork job price has been updated to $250

[cead22]

Simple bug, trivial fix, so I decreased the bounty

[melvin-bot]

@allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[allroundexperts]

@ishpaul777's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@allroundexperts, @stitesExpensify, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ishpaul777]

@stitesExpensify gentle bump for payment. Thanks!

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[stitesExpensify]

Hey @JmillsExpensify can we pay @ishpaul777 and @allroundexperts please? This PR has been merged for a while

[melvin-bot]

@JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[JmillsExpensify]

@allroundexperts do you mind filling out the BZ checklist for payment? In the meantime, I'll pay out the contributor based on the following payment summary:

• Issue reporter: @ishpaul777 $50
• Contributor: @ishpaul777 $375 (incl. urgency bonus)
• Contributor+: @allroundexperts $375 (incl. urgency bonus)

[JmillsExpensify]

Whoops updating the prices per this comment.

[JmillsExpensify]

Contributor paid out. Will circle back on C+.

[melvin-bot]

@JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

@allroundexperts Looks like this one lacks a checklist, though at that point I can approve payment and we can close this one out.

[melvin-bot]

@JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@JmillsExpensify, @allroundexperts, @stitesExpensify, @ishpaul777 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[JmillsExpensify]

Still awaiting a checklist.

[JmillsExpensify]

Actually, going to go ahead and close this one out. I can verify checklist ahead of approving payment via NewDot.

[allroundexperts]

Checklist

1. [Feat #23130] Add custom status settings to profile #23267
2. https://github.com/Expensify/App/pull/23267/files#r1407485604
3. N/A
4. I think this is really minor and a regression test is not needed. However, if there's disagreement, then the steps given in the OP seems to be clear enough.

[JmillsExpensify]

Thanks @allroundexperts. $375 payment approved based on this comment.