[HOLD for payment 2023-10-23][$250] Upgrade lottie-react-native to 6.3.1

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Slack convo: https://expensify.slack.com/archives/C04878MDF34/p1695304606676759

Problem

There are breaking changes in lottie-react-native 6.0 and we're still using 5.1.6. There are E/App changes needed to complete #26871

Solution

Upgrade E/App to use lottie-react-native 6.3.1+

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012d74e563bdfd8754
• Upwork Job ID: 1706290261133504512
• Last Price Increase: 2023-09-25
• Automatic offers:
• ZhenjaHorbach | Contributor | 26874866
• situchan | Contributor | 26992172

[melvin-bot]

@roryabraham the AutoAssignerTriage label has been deprecated. Please use Bug for issue triage. See https://stackoverflowteams.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012d74e563bdfd8754

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Upwork job price has been updated to $250

[ghost]

Dibs

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue

Upgrade lottie-react-native to 6.3.1

What is the root cause of that problem?

There are breaking changes in lottie-react-native 6.0

What changes do you think we should make in order to solve the problem?

We need to update version in package.json

Also, we need to check updates for react-native-web-lottie
And update the version and patch

What alternative solutions did you explore? (Optional)

NA

And so that there would be fewer questions later ))))

[b4s36t4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Upgrade lottie-react-native to 6.3.1

What is the root cause of that problem?

NA RC

What changes do you think we should make in order to solve the problem?

1. Upgrading from v5 to v6 has few breaking changes, and at this point there's nothing that we're using which causes any breaking changes. So we can easily upgrade to the lottie-react-native to latest verion.

2. Deprecate support for react-native-web-lottie, as mentioned in description we're moving with .lottie files so web-lottie is not required. (remove from package)

3. Install @dotlottie/react-player for web support.

Since we can not support webpack/babel alias support for this package we can create a cross-platform component Just as a layer for the platform specific packages.

Like inside components folder we would create index.js/ts and export a wrapper component with name as Lottie and index.website.js to create a wrapper component which uses Lottie from @dotlottie/react-player package.

for @dotlottie/react-player we should check that json animations are support or not, if we not first we should migrate all .json file to .lottie files then we should move ahead with this implementation

What alternative solutions did you explore? (Optional)

NA

[b4s36t4]

I think we have a draft PR ready with lottie-react-native for web support so Just upgrading and removing the dependecy of lottie-web-react-native should complete the work.

[roryabraham]

Install @dotlottie/react-player for web support.

Definitely out-of-scope for this issue. We're working building web support directly into lottie-react-native in #26871

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($250)

[allroundexperts]

@dylanexpensify It seems like @situchan has already reviewed the PR for this.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @ZhenjaHorbach got assigned: 2023-09-26 02:09:07 Z
• when the PR got merged: 2023-10-11 11:59:26 UTC
• days elapsed: 11

On to the next one 🚀

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Upgrade lottie-react-native to 6.3.1 #28267

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @ZhenjaHorbach requires payment offer (Contributor)
• @situchan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Upgrade lottie-react-native to 6.3.1 #28267

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @ZhenjaHorbach requires payment offer (Contributor)
• @situchan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Upgrade lottie-react-native to 6.3.1 #28267

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @ZhenjaHorbach requires payment offer (Contributor)
• @situchan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Upgrade lottie-react-native to 6.3.1 #28267

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @ZhenjaHorbach requires payment offer (Contributor)
• @situchan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[allroundexperts]

Un-assigning myself since this was handled solely by @situchan!

[melvin-bot]

@roryabraham, @Christinadobrzyn, @dylanexpensify, @ZhenjaHorbach, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[roryabraham]

@Christinadobrzyn @dylanexpensify this is ready for payment

[Christinadobrzyn]

Gotcha!

Payment summary:

Bug reporter: NA
Contributor: $250 @ZhenjaHorbach (paid in Upwork)
Contributor+: $250 @situchan (paid in Upwork)

Bonus: N - based on #28132 (comment)

Upwork job - https://www.upwork.com/jobs/~012d74e563bdfd8754