[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Web - Green drag and drop area does not show in full screen #28014

kbecciv · 2023-09-22T13:40:23Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Click on FAB icon and select Request money
Go to scan tab
Upload receipt and request money
Go to transaction thread
Click on image
Click on three dots and select replace
Try to drop image

Expected Result:

green drag and drop area should show in full screen same as scan tab

Actual Result:

drag and drop area does not cover full screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.73-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-20.at.4.46.48.PM.mov

Recording.4683.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695210899596209

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019a657764a62d532c
Upwork Job ID: 1705215482777022464
Last Price Increase: 2023-09-22
Automatic offers:

hoangzinh | Reviewer | 26876728
gadhiyamanan | Contributor | 26876729
gadhiyamanan | Reporter | 26876731

dukenv0307 · 2023-09-22T13:40:24Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

green drag and drop area does not show in full screen

What is the root cause of that problem?

In EditRequestReceiptPage, we don't wrap the header into DragAndDropProvider the same as MoneyRequestSelectorPage. So the green drag and drop area does not show in full screen

App/src/pages/EditRequestReceiptPage.js

Lines 35 to 39 in e52f21a

    
           <HeaderWithBackButton 
        
               title={translate('common.receipt')} 
        
               onBackButtonPress={Navigation.goBack} 
        
           /> 
        
           <DragAndDropProvider>

What changes do you think we should make in order to solve the problem?

We should move HeaderWithBackButton into DragAndDropProvider

<DragAndDropProvider>
    <HeaderWithBackButton
        title={translate('common.receipt')}
        onBackButtonPress={Navigation.goBack}
    />

    <ReceiptSelector
        route={route}
        transactionID={transactionID}
    />
</DragAndDropProvider>

What alternative solutions did you explore? (Optional)

NA

ahmedGaber93 · 2023-09-22T13:40:24Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

green drag and drop area does not show in full screen in EditRequestReceiptPage.js but it shown in MoneyRequestSelectorPage.js

What is the root cause of that problem?

the root cause is the HeaderWithBackButton is not a child of DragAndDropProvider.

App/src/pages/EditRequestReceiptPage.js

Lines 35 to 44 in 94c07ea

    
           <HeaderWithBackButton 
        
               title={translate('common.receipt')} 
        
               onBackButtonPress={Navigation.goBack} 
        
           /> 
        
           <DragAndDropProvider> 
        
               <ReceiptSelector 
        
                   route={route} 
        
                   transactionID={transactionID} 
        
               /> 
        
           </DragAndDropProvider>

What changes do you think we should make in order to solve the problem?

we need to move HeaderWithBackButton inside DragAndDropProvider

What alternative solutions did you explore? (Optional)

N/A

melvin-bot · 2023-09-22T13:40:29Z

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-22T13:40:29Z

Job added to Upwork: https://www.upwork.com/jobs/~019a657764a62d532c

melvin-bot · 2023-09-22T13:40:31Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-09-22T13:40:34Z

Triggered auto assignment to @lschurr (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot · 2023-09-22T13:40:41Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

gadhiyamanan · 2023-09-22T13:41:03Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

green drag and drop area does not show in full screen

What is the root cause of that problem?

HeaderWithBackButton is excluded from DragAndDropProvider here

What changes do you think we should make in order to solve the problem?

Add HeaderWithBackButton as child element of DragAndDropProvider in EditRequestReceiptPage.js

App/src/pages/EditRequestReceiptPage.js

Lines 36 to 45 in a240941

    
           <HeaderWithBackButton 
        
               title={translate('common.receipt')} 
        
               onBackButtonPress={Navigation.goBack} 
        
           /> 
        
           <DragAndDropProvider> 
        
               <ReceiptSelector 
        
                   route={route} 
        
                   transactionID={transactionID} 
        
               /> 
        
           </DragAndDropProvider>

What alternative solutions did you explore? (Optional)

N/A

kbecciv · 2023-09-22T13:41:18Z

Proposal by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695210899596209

Proposal

Please re-state the problem that we are trying to solve in this issue.

green drag and drop area does not show in full screen

What is the root cause of that problem?

HeaderWithBackButton is excluded from DragAndDropProvider here

What changes do you think we should make in order to solve the problem?

Add HeaderWithBackButton as child element of DragAndDropProvider in EditRequestReceiptPage.js

App/src/pages/EditRequestReceiptPage.js

Lines 36 to 45 in a240941

    
           <HeaderWithBackButton 
        
               title={translate('common.receipt')} 
        
               onBackButtonPress={Navigation.goBack} 
        
           /> 
        
           <DragAndDropProvider> 
        
               <ReceiptSelector 
        
                   route={route} 
        
                   transactionID={transactionID} 
        
               /> 
        
           </DragAndDropProvider>

What alternative solutions did you explore? (Optional)

N/A

c3024 · 2023-09-22T13:45:41Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Drag and drop highlighting when replacing the receipt from 3 dot menu is different from the drag and drop highlighting in request money scan page.

What is the root cause of that problem?

We are wrapping only the ReceiptSelector here with DragAndDropProvider

App/src/pages/EditRequestReceiptPage.js

Lines 35 to 44 in 9ab20c5

    
           <HeaderWithBackButton 
        
               title={translate('common.receipt')} 
        
               onBackButtonPress={Navigation.goBack} 
        
           /> 
        
           <DragAndDropProvider> 
        
               <ReceiptSelector 
        
                   route={route} 
        
                   transactionID={transactionID} 
        
               /> 
        
           </DragAndDropProvider>

unlike here

App/src/pages/iou/MoneyRequestSelectorPage.js

Lines 88 to 93 in 9ab20c5

    
           <DragAndDropProvider 
        
               isDisabled={props.selectedTab !== CONST.TAB.SCAN} 
        
               setIsDraggingOver={setIsDraggingOver} 
        
           > 
        
               <View style={[styles.flex1, safeAreaPaddingBottomStyle]}> 
        
                   <HeaderWithBackButton

that wraps the header as well.

What changes do you think we should make in order to solve the problem?

We wrap the header as well like this in EditRequestReceiptPage

            <DragAndDropProvider>
                <HeaderWithBackButton
                    title={translate('common.receipt')}
                    onBackButtonPress={Navigation.goBack}
                />
                <ReceiptSelector
                    route={route}
                    transactionID={transactionID}
                />
            </DragAndDropProvider>

What alternative solutions did you explore? (Optional)

If we don't want the header highlighting for both cases we might wrap with DragAndDropProvider from only here in MoneyRequestSelectorPage

App/src/pages/iou/MoneyRequestSelectorPage.js

Line 97 in 9ab20c5

{iouType === CONST.IOU.MONEY_REQUEST_TYPE.REQUEST ? (

excluding the HeaderWithBackButton

hoangzinh · 2023-09-22T15:38:16Z

Thanks for proposals, everyone. All of proposals have correct RCA and have the same approach. But because @gadhiyamanan is first, I think we should go with his proposal.

@gadhiyamanan's proposal #28014 (comment) looks good to me. I traced back the original PR #23046 of the Receipt tab but it doesn't describe how the Drop zone looks like. But in the recent related issue #25709, it seems we would like to make it cover the entire RHN screen. As such, we need to make the Drop zone cover the entire RHN screen in the Edit receipt page as well.

🎀 👀 🎀 C+ reviewed

melvin-bot · 2023-09-22T15:38:22Z

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

lschurr · 2023-09-25T04:31:52Z

Bump @roryabraham - as long as we all agree, we just need to assign this one to @gadhiyamanan

melvin-bot · 2023-09-26T05:13:41Z

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2023-09-26T05:13:44Z

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2023-09-26T05:13:48Z

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2023-10-03T15:34:52Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-03T15:34:56Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix Green drag and drop area #28219

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@hoangzinh requires payment offer (Reviewer)
@gadhiyamanan requires payment offer (Contributor)
@gadhiyamanan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-03T15:34:58Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hoangzinh] Determine if we should create a regression test for this bug.
[@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-05T00:04:50Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix desktop green drag and drop area #28579

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@hoangzinh requires payment offer (Reviewer)
@gadhiyamanan requires payment offer (Contributor)
@gadhiyamanan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-05T00:04:52Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hoangzinh] Determine if we should create a regression test for this bug.
[@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

dylanexpensify · 2023-10-10T11:09:43Z

Payment summary:

Reporter: @gadhiyamanan $50 @dhairyasenjaliya $50
Contributor: @gadhiyamanan $500
Contributor+: @hoangzinh $500

dhairyasenjaliya · 2023-10-10T11:15:47Z

Hy @dylanexpensify im also eligible for reporting since after this pr issue still exists on desktop which i have reported here https://expensify.slack.com/archives/C049HHMV9SM/p1695970479763139?thread_ts=1695970479.763139&cid=C049HHMV9SM

dylanexpensify · 2023-10-10T18:38:53Z

updated @dhairyasenjaliya!

hoangzinh · 2023-10-10T23:17:21Z

BugZero Checklist:

The PR that introduced the bug has been identified. Link to the PR: Replace receipt #26508
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/26508/files#r1353623634
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A It's just a small UI improvement
Determine if we should create a regression test for this bug: ❌ No, I think It's just a small UI improvement

hoangzinh · 2023-10-16T10:14:16Z

Quick bump @dylanexpensify on the payout

dylanexpensify · 2023-10-16T10:26:00Z

on it!

dylanexpensify · 2023-10-16T10:28:45Z

@dhairyasenjaliya please apply!

dylanexpensify · 2023-10-16T10:28:54Z

@hoangzinh @gadhiyamanan both of you have been paid!

dhairyasenjaliya · 2023-10-16T10:31:08Z

@dylanexpensify can you invite seems like currently I'm out of connects on Upwork at moment to apply :(

dylanexpensify · 2023-10-16T10:59:36Z

@dhairyasenjaliya done!

dhairyasenjaliya · 2023-10-16T11:00:29Z

thank you and accepted @dylanexpensify

dylanexpensify · 2023-10-16T11:01:05Z

offer sent @dhairyasenjaliya !

dylanexpensify · 2023-10-16T11:02:17Z

done!

kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 labels Sep 22, 2023

kbecciv added the Bug Something is broken. Auto assigns a BugZero manager. label Sep 22, 2023

melvin-bot bot changed the title ~~Web - Green drag and drop area does not show in full screen~~ [$500] Web - Green drag and drop area does not show in full screen Sep 22, 2023

melvin-bot bot assigned dylanexpensify Sep 22, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 22, 2023

melvin-bot bot assigned lschurr Sep 22, 2023

melvin-bot bot assigned hoangzinh Sep 22, 2023

melvin-bot bot assigned roryabraham Sep 22, 2023

melvin-bot bot added the Overdue label Sep 25, 2023

melvin-bot bot removed the Overdue label Sep 25, 2023

roryabraham assigned gadhiyamanan Sep 26, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 26, 2023

gadhiyamanan mentioned this issue Sep 26, 2023

Fix Green drag and drop area #28219

Merged

59 tasks

melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 3, 2023

melvin-bot bot changed the title ~~[$500] Web - Green drag and drop area does not show in full screen~~ [HOLD for payment 2023-10-10] [$500] Web - Green drag and drop area does not show in full screen Oct 3, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 3, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 5, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-10-10] [$500] Web - Green drag and drop area does not show in full screen~~ [HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Web - Green drag and drop area does not show in full screen Oct 5, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 10, 2023

hoangzinh mentioned this issue Oct 10, 2023

Replace receipt #26508

Merged

59 tasks

melvin-bot bot added the Overdue label Oct 13, 2023

melvin-bot bot removed the Overdue label Oct 16, 2023

dylanexpensify closed this as completed Oct 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Web - Green drag and drop area does not show in full screen #28014

[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Web - Green drag and drop area does not show in full screen #28014

kbecciv commented Sep 22, 2023 •

edited by melvin-bot bot

Loading

dukenv0307 commented Sep 22, 2023

ahmedGaber93 commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

gadhiyamanan commented Sep 22, 2023

kbecciv commented Sep 22, 2023

c3024 commented Sep 22, 2023

hoangzinh commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

lschurr commented Sep 25, 2023

melvin-bot bot commented Sep 26, 2023

melvin-bot bot commented Sep 26, 2023

melvin-bot bot commented Sep 26, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023

dylanexpensify commented Oct 10, 2023 •

edited

Loading

dhairyasenjaliya commented Oct 10, 2023

dylanexpensify commented Oct 10, 2023

hoangzinh commented Oct 10, 2023 •

edited

Loading

hoangzinh commented Oct 16, 2023

dylanexpensify commented Oct 16, 2023

dylanexpensify commented Oct 16, 2023

dylanexpensify commented Oct 16, 2023

dhairyasenjaliya commented Oct 16, 2023

dylanexpensify commented Oct 16, 2023

dhairyasenjaliya commented Oct 16, 2023

dylanexpensify commented Oct 16, 2023

dylanexpensify commented Oct 16, 2023

[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Web - Green drag and drop area does not show in full screen #28014

[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Web - Green drag and drop area does not show in full screen #28014

Comments

kbecciv commented Sep 22, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

dukenv0307 commented Sep 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ahmedGaber93 commented Sep 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

gadhiyamanan commented Sep 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

kbecciv commented Sep 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

c3024 commented Sep 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

hoangzinh commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

lschurr commented Sep 25, 2023

melvin-bot bot commented Sep 26, 2023

melvin-bot bot commented Sep 26, 2023

melvin-bot bot commented Sep 26, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023

dylanexpensify commented Oct 10, 2023 • edited Loading

dhairyasenjaliya commented Oct 10, 2023

dylanexpensify commented Oct 10, 2023

hoangzinh commented Oct 10, 2023 • edited Loading

BugZero Checklist:

hoangzinh commented Oct 16, 2023

dylanexpensify commented Oct 16, 2023

dylanexpensify commented Oct 16, 2023

dylanexpensify commented Oct 16, 2023

dhairyasenjaliya commented Oct 16, 2023

dylanexpensify commented Oct 16, 2023

dhairyasenjaliya commented Oct 16, 2023

dylanexpensify commented Oct 16, 2023

dylanexpensify commented Oct 16, 2023

kbecciv commented Sep 22, 2023 •

edited by melvin-bot bot

Loading

dylanexpensify commented Oct 10, 2023 •

edited

Loading

hoangzinh commented Oct 10, 2023 •

edited

Loading