[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] [iOS] - Workspace - Distance rate separator in Spanish causes errors #27595
Comments
izarutskaya
added
External
|
Triggered auto assignment to @anmurali ( |
melvin-bot
bot
changed the title
|
Job added to Upwork: https://www.upwork.com/jobs/~01a56c81afd242643d |
Bug0 Triage Checklist (Main S/O)
|
melvin-bot
bot
added
the
Help Wanted
|
Triggered auto assignment to @CortneyOfstad ( |
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.The comma used as a decimal separator for the distance rate when the current language is Spanish is causing a form validation error. What is the root cause of that problem?Spanish uses a comma as the decimal separator, while English uses a dot. What changes do you think we should make in order to solve the problem?Solution 1 -} else if (parseFloat(values.rate) <= 0) {
+} else if (parseFloat(values.rate.replace(new RegExp(`\\${decimalSeparator}`, 'i'), '.')) <= 0) {
errors.rate = 'workspace.reimburse.lowRateError';
}Or to make things simpler: It looks like the simpler approach is already being used in the We can also conditionally perform the regex replacement if the current language is Spanish. Solution 2 What alternative solutions did you explore? (Optional)None. |
|
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
|
Bumped @situchan on the linked Slack thread - https://expensify.slack.com/archives/C049HHMV9SM/p1695666036355529?thread_ts=1694604963.679959&cid=C049HHMV9SM |
|
@akinwale thanks for the proposal. I think there should be pattern to parse locale based numeric values in the app. |
@situchan There isn't one. The closest thing we have for an amount regex is in the I believe if there was, then we wouldn't be replacing the locale digit, ',' with a '.'. The methods for doing this were moved in this PR: 5b33d50. Check for the So here, we can use: Additionally, we only need to worry about the decimal separator here. It looks like thousands separators are not supported for the rate input. |
|
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
|
Bumped @situchan on slack again. |
melvin-bot
bot
changed the title
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-20. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
melvin-bot
bot
changed the title
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-23. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
melvin-bot
bot
changed the title
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-23. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Checklist
Regression test
Do we 👍 or 👎 ? |
|
@anmurali Just noting here that the PR was initially deployed to production on 2023-10-13, so the actual payment due date is 2023-10-20. Melvin got confused with a bunch of subsequent deployment issues which happened afterwards. Thanks. |
|
Can I get a payment summary for this issue? |
|
@nkuoch, @akinwale, @anmurali, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick! |
|
|
$750 payment approved for @allroundexperts based on summary. |
|
@nkuoch, @akinwale, @anmurali, @allroundexperts Huh... This is 4 days overdue. Who can take care of this? |
|
Done. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
There should be no errors displayed
Actual Result:
There is error displayed and only when you use "." as a separator (not ",") is it working
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: v1.3.70-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2023-09-13.at.11.29.28.mov
Rpreplay.Final1694889723.mp4
Expensify/Expensify Issue URL:
Issue reported by: @BartoszGrajdek
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694604963679959
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: