[HOLD for payment 2023-09-27] [$500] Animated: useNativeDriver is not supported because the native animated module is missing

[marcaaron]

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016259f6e7a833676a
• Upwork Job ID: 1701194832995864576
• Last Price Increase: 2023-09-11
• Automatic offers:
• bernhardoj | Contributor | 26653774

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Getting a useNativeDriver is not supported warning on the web platform.

What is the root cause of that problem?

React Native Animated can do the animation either on the JS or on the native side. useNativeDriver is useful to tell react native where to do the animation. If it's true, RN will do the animation on the native side.

However, on the web, doing the animation on the native side is not supported (we only have js on the web) so useNativeDriver will fall back to false, which is doing the animation on the JS and RN will give a console warning.

What changes do you think we should make in order to solve the problem?

We should set useNativeDriver to true only on the native platform. We already have a useNativeDriver.js file that exports true for the native platform, so what is left to do is to replace all usage of useNativeDriver: true to use the new file.

import useNativeDriver from 'libs/useNativeDriver'
...
useNativeDriver: useNativeDriver

[melvin-bot]

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

Based on a couple other similar issues, seems this needs to be sent external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016259f6e7a833676a

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[mananjadhav]

@bernhardoj's proposal here is good.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @mananjadhav

[melvin-bot]

🎯 ⚡️ Woah @mananjadhav / @bernhardoj, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @bernhardoj got assigned: 2023-09-13 13:51:23 Z
• when the PR got merged: 2023-09-15 20:19:18 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix useNativeDriver warning on web #27356

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @bernhardoj requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

Payment summary:

Contributor: @bernhardoj to be paid $750 for work completed and #urgency bonus via Upwork
C+: @mananjadhav to be paid $750 for work completed and #urgency bonus via manual request

[bfitzexpensify]

A reminder to complete the BZ checklist when you get a chance @mananjadhav - thanks!

[melvin-bot]

@nkuoch, @mananjadhav, @bfitzexpensify, @bernhardoj Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mananjadhav]

I couldn't exactly pinpoint a specific PR that caused this. I also don't think we need a regression test for this one.

[bfitzexpensify]

Sounds fair to me. OK, let's close this one out - thanks everyone!

[JmillsExpensify]

$750 payment approved for @mananjadhav based on BZ summary.