[HOLD for payment 2023-09-07] [HOLD for payment 2023-09-06] [$1000] Attachment- Uploading PDF displays error #26193
Comments
lanitochka17
added
the
DeployBlockerCash
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
|
Triggered auto assignment to @Li357 ( |
|
Do we have a stack trace for this? |
ProposalPlease re-state the problem that we are trying to solve in this issue.Attachment- Uploading PDF displays error What is the root cause of that problem?NewExpensify crash caught by error boundary - Cannot read property 'onPinchGestureChange' of null from this pr https://github.com/Expensify/App/pull/25529/files What changes do you think we should make in order to solve the problem?we need check attachmentCarouselPagerContext is there or not useEffect(() => {
if(attachmentCarouselPagerContext) {
attachmentCarouselPagerContext.onPinchGestureChange(false);
}
// eslint-disable-next-line react-hooks/exhaustive-deps -- we just want to call this function when component is mounted
}, [attachmentCarouselPagerContext]); |
|
@pradeepmdk That looks reasonable, can you show a video of the fix working? Since this is a deploy blocker, we want to fix this fast! |
Screen.Recording.2023-08-29.at.7.05.45.PM.mov |
|
@pradeepmdk's proposal works but let's see if @tienifr is able to raise PR quickly as it's in regression period. |
|
@aimane-chnaif @tienifr has gone offline and we want to keep this blocker fix moving. @pradeepmdk can you raise a PR? |
|
sure @Li357 i am ready |
Agree. @Li357 can you please assign @pradeepmdk (C) and me (C+) to the issue? |
melvin-bot
bot
added
Reviewing
|
Triggered auto assignment to @MitchExpensify ( |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-06. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
melvin-bot
bot
changed the title
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-07. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
|
Payment summary: Reporting: NA @luacmartins Was there a regression here just to be sure? Seems not but double checking |
|
yes, this was a regression - #26193 (comment) |
|
yes, regression but not affect payment. Both @pradeepmdk and me didn't work on the offending PR. |
|
Ok cool, thanks for confirming. Let's get the BZ steps squared away @aimane-chnaif - Issuing payment now |
|
Invited you to the job @aimane-chnaif Please apply to the job for payment, thank you! @pradeepmdk https://www.upwork.com/jobs/~01b6f875237866634b |
|
@MitchExpensify can you please invite me as well https://www.upwork.com/freelancers/~0146d771ed1c776acb |
|
Sent! @pradeepmdk |
|
@MitchExpensify Thank you!! accepted.. |
|
Paid and contract ended. Next step - BZ steps cc @aimane-chnaif |
|
@Li357, @pradeepmdk, @luacmartins, @MitchExpensify, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick! |
|
@Li357, @pradeepmdk, @luacmartins, @MitchExpensify, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
|
@aimane-chnaif could you complete the BZ checklist please? |
I believe this is one of the main flow which already exists in Testrail. And caught by Applause team. |
|
I think we're all done here, right? Gonna close the issue, let me know if we're missing anything. |
@luacmartins my payment is pending |
|
@MitchExpensify can you please check on that? |
|
Oops, sorry about that. Not sure how that payment was missed - Fixed! @aimane-chnaif cc @luacmartins |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The user must able to see preview and send pdf file
Actual Result:
The user was shown error message after selecting a pdf file
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.58-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
error.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: